Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp4928919iog; Wed, 22 Jun 2022 08:29:14 -0700 (PDT) X-Google-Smtp-Source: AGRyM1thWiOMUGlLtEp3g0d4x5tXAdhqWdGOr0qADl1G7f9b8s9wfXmyNIFq1UoaYMY5rGQiHth9 X-Received: by 2002:a63:711e:0:b0:40c:c08d:79e0 with SMTP id m30-20020a63711e000000b0040cc08d79e0mr3341989pgc.357.1655911754230; Wed, 22 Jun 2022 08:29:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655911754; cv=none; d=google.com; s=arc-20160816; b=LGQYpb2qurLGXnqruTHxLW6/0oIgg/SEes2AwNmJIGg5W/Hq5cWUF0SFL6FBkgEnf2 YBLUnXnPeWRKBV+XUuguoPQBxFYdy67u0jB5zLDvMNGrCFOX4qVtnjJY0AuaH/+ffmiR EaV9SdJfKCC4nXamSf3gwt5Y68wLfgUgN4p3xTFB9QTHRU+0xrAf22sLGsnW2H3PwUI/ eMSmPJKFNgBolnAYFnRsmWL0FARS+uaJjovbLIN44qKw+T+8uz2nCpAzTAIirM3mu/U7 0PxGW4c+ma2aCXQJunehzjVthjRmmJLOvqzCSOlLLO/XnqT1wLObUu/GJlQMDTbZEEWU rvvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=7EfYDaHp7o2ynwhzXdZuBel5ma4F158kz8ibpFaAXyU=; b=u7BXPLBv+GlZOcyNto4ojaoWg1cAVs0jyyA5LgYm8H5CYw5lLJTg3W5XBDe7sjaVcA xsBnud0V61CFI6Od7WrRG0KxkYLngWpjzq784MAYJwtnOV+UplakWUyogMmLqZOVSq2Y TUtB4a4WLgsNqrgLk1rVPb3RSmlTDOHh6k91qqBStLJKnWdE40g7ulN6BFbEOLyISxR6 kPA5CATghK+3BgO2vjou1l9Om/0KATWDUbOTTF4krRQMoAg/1u5rFr83nd5hdJaOpHT5 4E3SkImPk3a4Ywwb1Cwn4oLOE5v3DFNJ1/safEkS+vwdjQf5SDtcN/Q5Xhl2wl3pPmYk xudQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d17-20020a170903209100b0016a1f3f7c57si10909627plc.607.2022.06.22.08.29.02; Wed, 22 Jun 2022 08:29:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358533AbiFVOym (ORCPT + 99 others); Wed, 22 Jun 2022 10:54:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357566AbiFVOyk (ORCPT ); Wed, 22 Jun 2022 10:54:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8CCA26ACF for ; Wed, 22 Jun 2022 07:54:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7418B61CD2 for ; Wed, 22 Jun 2022 14:54:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B39B2C34114; Wed, 22 Jun 2022 14:54:37 +0000 (UTC) Date: Wed, 22 Jun 2022 10:54:36 -0400 From: Steven Rostedt To: Mark Rutland Cc: Peter Zijlstra , x86@kernel.org, linux-kernel@vger.kernel.org, Josh Poimboeuf , christophe.leroy@csgroup.eu, naveen.n.rao@linux.vnet.ibm.com, mbenes@suse.cz, Nathan Chancellor , Nick Desaulniers , Ard Biesheuvel Subject: Re: [RFC][PATCH] ftrace,objtool: PC32 based __mcount_loc Message-ID: <20220622105436.775ccf7f@rorschach.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Jun 2022 12:40:00 +0100 Mark Rutland wrote: > We have a similar issue on arm64, which is exacerbated by needing ABS64 > relocations (24 bytes per entry!) adding significant bloat when FTRACE is > enabled. I have patches that bring down the size quite a bit. The mcount loc is read into the dyn_rec, which has two longs (the second long is the flags that only use 32 bits, but is a long to make it aligned, as a 64 bit word followed by a 32bit word just added 32 bits of padding to make it an array). The patches make it into two ints (which bring down the size for 64 bit machines). The lists are broken up into blocks, and what I do is put the top 32 bits of a word into the top of the block, and make sure that they are the same among all the entries in the block. I guess its time to bring this back alive. -- Steve > > It'd be really nice if going forwards compilers could expose an option to > generate PC32/PREL32 entries directly for this.