Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Jun 2022 16:10:22 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        Smita.KoralahalliChannabasappa@amd.com, muralidhara.mk@amd.com,
        naveenkrishna.chatradhi@amd.com
Subject: Re: [PATCH 12/18] EDAC/amd64: Add determine_edac_cap() into pvt->ops
Message-ID: <YrM+7tii3AK00mvh@yaz-fattaah>
References: <20220509145534.44912-1-yazen.ghannam@amd.com>
 <20220509145534.44912-13-yazen.ghannam@amd.com>
 <YrCed0NnrVUjKoJh@zn.tnic>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YrCed0NnrVUjKoJh@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?w2BBG7m24SQITW1Y2dYemhsuX2o3LdDTHrWsk953jUR6QgLox8rAFijGljQm?=
 =?us-ascii?Q?cA7uxC6jhJZCPWxp5oTTWOU05mejmypxNzshxKeMFc1UxHiC157QSHVu5/iI?=
 =?us-ascii?Q?DXiVTAS8QQGeqAnlGzhvAC7/UWLjnDfpf6Y2dW0FOEk/7axK5qpLt5Pb20hq?=
 =?us-ascii?Q?WUDShY/uWNO8a7Fva5k3yxqm+cigHI2KGgi3GFsq37sFLwrG3sIZTkfczMcP?=
 =?us-ascii?Q?dKdpjmcIJeXJ0Ck/NgECW5BdhBFicCYvB5IS4yTfm80GE+EGQIlFoUHgtWtv?=
 =?us-ascii?Q?WnerBaJtyJOXptlVtWPL5KFFWqqzZw9Nk1Wp8wnuuUfe7CzYV+DSowVvaCrM?=
 =?us-ascii?Q?huBB1RmFUA0EQKgIPA2arD0GUfDhu3wAszA3GBnFI6M01wMS9OJXs1fhACzA?=
 =?us-ascii?Q?5qte2w0vYfUlfcs7pyYQQyMluywb3un5quHHF1dSp9IwxMZP9JZDsWBeVrZr?=
 =?us-ascii?Q?jcSLNMn1CoB1VJ/bUv3qIxvzjx/TfjH6xeBduUVVnKQGN4CgUb9o8jg+hmiD?=
 =?us-ascii?Q?F6lMjqGSoCQ1S872IqJConrYJVu89bRe/CktGdtRKV/FCMo8fvj7VfyIidVn?=
 =?us-ascii?Q?n8FlAg3m2/N8ypnEnAZ8huD/AIXPU0et8XZ/zdKeuH5Zd2Ly3g4htk8ZR+uV?=
 =?us-ascii?Q?l0a/OjO5pIqwS7gj5M6ajO2cxRKAaqPYyUmPZ00DXOYoUvF9Wx2Ib2LnVc9A?=
 =?us-ascii?Q?jNEBBNIA4h7yjK8Zkhqp15YEzVa5713qxpl/I2XOBgpNh9eTNc3fpfbmt50Q?=
 =?us-ascii?Q?XyniGN85EwxYuulNm2y56dMfGP1Vm9KTpLD6AXiLmwz0wd/w+UXuaYf6f6QQ?=
 =?us-ascii?Q?TmwXzwqC7fRsS8jXISm4YXAmVKlDvmU7aYBWY+U+VN7nmeDQqBZwS/Y/iCBH?=
 =?us-ascii?Q?kvj9+g1bNAq7VffCpzO1wpMuk4OpeOD1+2Mmbrp+XDjAysSXiIZvN6xBL3q9?=
 =?us-ascii?Q?+OKwvfmfuw6Kbmtn6LODVS0zP7KMsXJs1tAgVpONy08G+koD0mnE9uV8aNI0?=
 =?us-ascii?Q?v11+2mI62oCW3dZDJXwnwzUFC7hIfmy+aWDffPV4x28MSxm3H3rQDLQXsKDx?=
 =?us-ascii?Q?veBqGU8FBuyh8Mq29OGK88BNVXOfrpzFc7g/fKxVbcMy7kCIxEo5UT714ldx?=
 =?us-ascii?Q?/uKW9pROjjPQMU7OJbI0cSAQ9WvOjdxf9Nwidqkugf4bzauIaMGdW2F1WIJr?=
 =?us-ascii?Q?0rJWtDEFAL7dn5QLSRmSlLceOMuSWiKYwm2JkFncttinW7V6v8ISdLZLTJd6?=
 =?us-ascii?Q?Evyi798WE33CBqMT+Bd2gPPBFwdaqvJqeTkHIGj4/xGm6Rxp8249uUQehjwu?=
 =?us-ascii?Q?2ZIcvrVQ1RWrSyUgJZpUffJWIk7lCdM4EYDNlYACZJvNWXIOUSyQnCPv4JY3?=
 =?us-ascii?Q?hocvz0BeCBkv5kwDuPgAychtZHRKnydhQHGz9/zN8lP/KyKJxHipYLdvhsuH?=
 =?us-ascii?Q?XjOQC0w2i0T1HkWdR0MgYXAOwhtt1hEgk++i3YncGQSGLUmu9twrPzSGMWct?=
 =?us-ascii?Q?SZmsyCHGV89gXJdjPud05LlQbbbVpkNU9qByiwSABHnyIXIp3Z/MP2LFOmAU?=
 =?us-ascii?Q?3iKPntvrqCFVI1vVQnDUBBlaD12EYTpIoglR6OduNh40X8VHRMucasDo8tc0?=
 =?us-ascii?Q?bv7LAL5nseJBcnMPnTktOj5mvjVpK26w1oblg820JKmMpwk3Bo52KmB9L3kV?=
 =?us-ascii?Q?Qnn6SCYqaYmHGbhUm+MdvbElz8rPG7YptlTRPQ9JaFwVrDiuRaMeGKE3l8gF?=
 =?us-ascii?Q?huDcwIWv6g=3D=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df8924b8-2d9d-4a78-3715-08da5469b76d
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2022 16:10:25.4221
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xjCHhC0AAejaHDzVcxT/XDg1d5hEHnwJ4AWQVZSSVq8/vlU8XVDIESoUC4i8cZdv0ydN9SGk7diBFxB8K32wCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4056
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 20, 2022 at 06:21:11PM +0200, Borislav Petkov wrote:
> Back to those...
> 
> On Mon, May 09, 2022 at 02:55:28PM +0000, Yazen Ghannam wrote:
> > From: Muralidhara M K <muralidhara.mk@amd.com>
> > 
> > GPU Nodes will have different criteria for checking the EDAC
> > capabilities of a controller. A function pointer should be used rather
> > than introduce another branching condition.
> > 
> > Prepare for this by adding determine_edac_cap() to pvt->ops and set it
> > as needed based on currently supported systems.
> > 
> > Use a "umc" prefix for modern systems, since these use Unified Memory
> > Controllers (UMCs).
> > 
> > Use a "dct" prefix for newly-defined legacy functions, since these
> > systems use DRAM Controllers (DCTs).
> 
> Please refrain from adding those boilerplates to each commit message. Do
> it once for the first patch and then no need anymore. It is clear what's
> going on.
>

Understood, will do.

Thanks,
Yazen