Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp5016050iog; Wed, 22 Jun 2022 10:10:39 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vsSYbx41/MYBagsmZozikk1PpJAvBvxF5akAhk/bPlmwsslAJO9jMRV7G7DA2yvNQT08Ho X-Received: by 2002:a17:907:7e97:b0:718:f4d4:c970 with SMTP id qb23-20020a1709077e9700b00718f4d4c970mr4116707ejc.250.1655917838825; Wed, 22 Jun 2022 10:10:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655917838; cv=none; d=google.com; s=arc-20160816; b=sTCj8jkhGJ+0/Wg4ItbwK+Bs2NofnBOr/gSMXfvwMDAY1UCunb/krP03gz98/l3uHP ft5Up87Gdf1xm4Qa0BJKnzFvxWi3PWl+n2zcmDg+Nu4K4EA5NSJNieX1cxT5ay7Nmxka CQLPkmssC1lOVkzER+1rKQivyePVm9NZFanu7EnDAA9iMrUv99RiojZ4qmwoaJMAWFdT 4TJrCzHYthk/t7PiIWBtnkk94x/nwJWaS+gfUvUNSjP0s70CtzZrcoo8e5s+ngk0X1rP aVt4iIzNQehb9ZP6DogM1jy32QsZiU4nYkHeLy2WpLoWUvLnENE9V/uGthGZgQAvt3i2 nS4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9j9zzndE/FOkxrZHYw4KMWVBf+hlMNyXbzxHfN+72Nk=; b=Srh9h8iSE0rrCKaVMmOZDAVBVKYXOMgSUaKpLNJBjN3RxCcE8M4wrr55n691hJW28U WyiPc8D/FqpDGsUUKf/I5FwhVNN7FCPsdSddrgLTqH304/xw1Ua/YPC6z98RkGzyxK+m /flcDCuGSZQBwUduQPr39mrb96vaGnLPc/9OL9rhvh7XPJfh530V8FISyuBkxSeuYMt9 wcgjMyBhlE7Kr9/XqG3ZSeG3/eabqH4R30GY0Shth1xLLL56I0YYu73+5uFWVCYkkvLu 65sKfzZW6zwnwS6jtWAwdgooDq2eiJrw+mDLaSvpEF1uv0BaOEKjLNg0r1vixqYf4opx DX7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IhZwI4Q6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l4-20020a170906794400b0071076a14dc5si20267667ejo.774.2022.06.22.10.10.09; Wed, 22 Jun 2022 10:10:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IhZwI4Q6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376712AbiFVRIq (ORCPT + 99 others); Wed, 22 Jun 2022 13:08:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377306AbiFVRIY (ORCPT ); Wed, 22 Jun 2022 13:08:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4639142496 for ; Wed, 22 Jun 2022 10:07:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 242F661B89 for ; Wed, 22 Jun 2022 17:07:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2992AC34114; Wed, 22 Jun 2022 17:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655917639; bh=jgUJecCzFXvnTsqrwru1uRnoQwtYzOYNC/yDvPGBGoU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IhZwI4Q6iVlC+S04Q/J29TcboiwU+MljMXhoIKGg/AarqIIaTjhvPWG8Z5naLox1B n9KzIptntxltqPY1UQX7h6+eshcKX5oThDpAfbbkf+5lPHZNJDhE22vQrk6ovDr6oN 6Y17fZSrph0Xy4r8ZUdj4pEGcqUwbIhTfj8ATiOakPESMDJzko75CuWYd/Zhi8KQpt 6VBVVsuA1I+MzepLJnoupAngeGMWvT1Jz8keDZX/TCuwguPcCsaBPRgu7Kgxak/iez Grfx6FYsk6nAPs/Mx6RdBLf4M9kYE6s+/BCOLQj4HZkBCOSKpStEzvhVWHDEibsMvn /cE+zahQqxROw== Date: Wed, 22 Jun 2022 18:07:15 +0100 From: Mark Brown To: Dong Aisheng Cc: Aisheng Dong , "linux-kernel@vger.kernel.org" , "l.stach@pengutronix.de" , Peng Fan , "shawnguo@kernel.org" Subject: Re: [PATCH RFC 1/2] regmap: add option to disable debugfs Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8qqGhfl8w2IBtgLF" Content-Disposition: inline In-Reply-To: X-Cookie: Truckers welcome. X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --8qqGhfl8w2IBtgLF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 23, 2022 at 01:01:12AM +0800, Dong Aisheng wrote: > On Thu, Jun 23, 2022 at 12:48 AM Mark Brown wrote: > > Ah, right. That makes sense - we should relax the check to only apply > > if there is actually a cache. > If we don't remove the WARN_ON in regcache_cache_only(), how > would you suggest the fix? In exactly the manner I suggested above. --8qqGhfl8w2IBtgLF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKzTEIACgkQJNaLcl1U h9Diqwf+Nz4r4ln8IKyQtWv2S6rFk5jVlzqo7clQkJiexuryvvBKMzraOfs4olcX a5kjTZUEH3b5yW8+xvIaTt2AXOxnNwqnWc0Z//7FrL3+SUv4JlRJUQQwzSZ7UE7v 30Syy4I74zSePHlCMvXFz5Ji1lyAPuJgzLYKCh14+zj48JIfxCuY+Bbm+CRXqS84 XuQFwTq90Re41/8i9Q7tKMnNHwWT4CMlxXt7zBpCEvuiYfWnIzOYWIHuok0BO5Fm cRSMsQ9N4xeFPicCu59mEd101vxejcC3lrtjKtGdVGFzoG9nFUnxze9ErMESG0LN 08DQYKM4mPPMPNxGchA2Bqh001F/Dw== =NXAf -----END PGP SIGNATURE----- --8qqGhfl8w2IBtgLF--