Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\))
Subject: Re: [External] [PATCH] node: put_device after failing to
 device_register
From:   Zhi Song <zhi.song@bytedance.com>
In-Reply-To: <YqidROu44rHFaI6w@kroah.com>
Date:   Thu, 23 Jun 2022 01:12:31 +0800
Cc:     rafael@kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 7bit
Message-Id: <2BE06D43-725A-4006-B035-ABCC0B1CEEC3@bytedance.com>
References: <20220614143007.1730171-1-zhi.song@bytedance.com>
 <YqidROu44rHFaI6w@kroah.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Precedence: bulk

> On Jun 14, 2022, at 22:37, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> On Tue, Jun 14, 2022 at 10:30:07PM +0800, Zhi Song wrote:
>> device_register() is used to register a device with the system.
>> 
>> We cannot directly free dev after calling this function,
>> even if it returns an error.
> 
> the device is not being freed, why say this?
> 
> And you do have a full 72 columns to use :)
> 
>> 
>> We should use put_device() to give up the reference
>> initialized in this function instead.
> 
> There is no "instead" happening here.  The patch looks correct, but this
> changelog text does not.  Please fix up.
> 
> thanks,
> 
> greg k-h

Hi Greg,

I have submitted this fixed patch here:
https://lore.kernel.org/all/20220621171623.1959231-1-zhi.song@bytedance
.com/
take a look if there's anything wrong. :)

Thanks,

Zhi