Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp5031375iog; Wed, 22 Jun 2022 10:29:43 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v2AH3cQK43W20+JW0AqDQQFGOTRVtKOpjNCZi3bFSlLigY2gSm+jHOneOyQsKyn/MWwKVC X-Received: by 2002:a17:906:2001:b0:6f3:bd7f:d878 with SMTP id 1-20020a170906200100b006f3bd7fd878mr4319832ejo.133.1655918983370; Wed, 22 Jun 2022 10:29:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655918983; cv=none; d=google.com; s=arc-20160816; b=PXv01yXAFFn1w06/jCJMjARW3ih5+cyEzKcwJBLZEfTcsD6fLk0BMeAxvYInYWnIaZ DzxE09OGhmVLeqOh9hGUD1SGbxcMYKWmif3ficael0CrIHZpNlpjqalzSebk/b33sJ5j hVMLxmmkWs+ltkJm+wS9eEy1whCi7ki1CPU9OMEG09RYN1Sz6tSHnk10VhB2JjoMcLW/ QBf9v5CJRb0SoxAKsSkMZOcLnXvCWS2UAEJfUWUFNKQv+V2SWo2b+dE+7jgMlBhpjboc qud/+27SJz+7asmXV5l/PxFqT/8q0brK5pU81ruO7Pen+0UATlkZvglZWzkH6JP4fVbH ikFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=I/BeBQD32jCTPeN6apW0lD2i+HlHyWEEVlrkTexvA5U=; b=MR/aj64Rmk39bGyPSK8zW7OEVSrXHwjocuNe2GyfN90YluMkVB5qB/xzxDchOBz6l5 2GG7r6p6bEumQ86RSCe7f9swQzKwfcxHiqonCaOzFYogWtFX8NjwXNHaVrlnOC54gzSd QY7XKLEpQI+QZoBq3fIo30nE6UXRIibiJT+mdpu4psUl4v5iPxmbu0lMGwF+7jUwJrmr rVw/ha4XHeNIsCUwxO5ZfIrn3gjc4JMfqrmc6WZNEh8rhOyhz4WKdT2vLkgIxtLF4P2h u+Kzy9YdDlS/9p5h60UXCDfrlLzzSPmKDzImokP3dmCo5SxH4UmcmX+OzzgDqSQKnISf RQCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gn07NX4X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qk14-20020a1709077f8e00b0070337fc0e1asi22376744ejc.27.2022.06.22.10.29.17; Wed, 22 Jun 2022 10:29:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gn07NX4X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376973AbiFVQvM (ORCPT + 99 others); Wed, 22 Jun 2022 12:51:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376887AbiFVQu5 (ORCPT ); Wed, 22 Jun 2022 12:50:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 497CC40E73 for ; Wed, 22 Jun 2022 09:48:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DC4A961B1F for ; Wed, 22 Jun 2022 16:48:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF452C3411B; Wed, 22 Jun 2022 16:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655916536; bh=HKAwj6WqHsFCizeY3YQTqEfxSzWhZ074BWZUt4AykcE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gn07NX4XJW2TBPErhOJSQPWok8YUaMQHmpcwfee9PC84zM1ypWc/JkQCdfgXozvp8 1MrKfvqHUQRBW9kKHDbCIHoGblR9udb43LNsl1jgkF5A6onQVZLgMQdPk8L4xaFXf9 nZLW8BrU7y3bCxwDpYoUG8WmTttKiDgqeBNYJsHnfX5oLG3UI3MTdr3V2TmpChaEx/ Ek1YnHHx8FFM4ijCaBFSEDCOcQQqRCwluL7T9wizMdN9rzAZH1m4bm39Op3lE7TwFw kBTqJ5E9n5Qqku5LaB9ujVZc77vKdKsyWZ1QmJRD8nmvP7sfrxWSxplUKwfHZZOT8E lczUlS74UadJQ== Date: Wed, 22 Jun 2022 17:48:51 +0100 From: Mark Brown To: Dong Aisheng Cc: Aisheng Dong , "linux-kernel@vger.kernel.org" , "l.stach@pengutronix.de" , Peng Fan , "shawnguo@kernel.org" Subject: Re: [PATCH RFC 1/2] regmap: add option to disable debugfs Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xDUxxgqnT7sUsrLu" Content-Disposition: inline In-Reply-To: X-Cookie: Truckers welcome. X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xDUxxgqnT7sUsrLu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 23, 2022 at 12:42:51AM +0800, Dong Aisheng wrote: > On Thu, Jun 23, 2022 at 12:27 AM Mark Brown wrote: > > cache_bypass is only going to be true if something enabled bypass, why > > would a device that doesn't use a cache enable bypass? It does get > > turned on transiently by things like patching but those only make sense > > if the device can be accessed so caceh_only shouldn't be on then. > It was enabled by default according to the code: > __regmap_init -> regcache_init Ah, right. That makes sense - we should relax the check to only apply if there is actually a cache. --xDUxxgqnT7sUsrLu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKzR/IACgkQJNaLcl1U h9DGaQf/ZCq9VWO3ofHpZRx0yp3FDK4aUd7qAalJ1T73pWVSk7oN0B7WFLEEZUjp psfGcIzztckSoJIL7vxfGayS32ZsOXsetjkKDlRaitE2pHOx5nriGV3b888D1ysA 6jJk43hzFnEjU17YONVOmlSMPrNs8PV0YvIedT9V2WofKY+YWIRCnLgS4Gc0GvgK 4utsH9r12dYIQDtUkMcLWgrw/Sy7dw9SApe8NcbphkVKY2HVyf8ZFRjaIAIu3phI Q5sGhkVjAwrqOMocr+TEu+1tycGS53JpqrPSiIJJ/gITYfstLCd4hfZ4ciD0/xmF vnwAoLGLmg1EYxvvUYgm+C9meNyIQg== =Ke7G -----END PGP SIGNATURE----- --xDUxxgqnT7sUsrLu--