Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756474AbXEYEbn (ORCPT ); Fri, 25 May 2007 00:31:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751368AbXEYEbg (ORCPT ); Fri, 25 May 2007 00:31:36 -0400 Received: from 85.8.24.16.se.wasadata.net ([85.8.24.16]:50318 "EHLO smtp.drzeus.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751333AbXEYEbf (ORCPT ); Fri, 25 May 2007 00:31:35 -0400 Message-ID: <465666AE.5020600@drzeus.cx> Date: Fri, 25 May 2007 06:31:42 +0200 From: Pierre Ossman User-Agent: Thunderbird 2.0.0.0 (X11/20070419) MIME-Version: 1.0 To: Andrew Morton CC: LKML Subject: Re: [PATCH] Make prepare_namespace() wait for devices References: <4655834F.3050301@drzeus.cx> <20070524170654.5d674474.akpm@linux-foundation.org> <4656602A.3010000@drzeus.cx> <20070524211737.daa3c99c.akpm@linux-foundation.org> In-Reply-To: <20070524211737.daa3c99c.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 35 Andrew Morton wrote: > Whatever. I think you can work it out ;) > > Bare with me, I just woke up ;) > while (driver_probe_done() || (ROOT_DEV = name_to_dev_t(...)) == 0) > > perhaps? > > The loop-which-sleeps within a loop-which-sleeps seems poorly thought out? > I'd say a matter of taste. I'm not a big fan och cramming things into the while() clause. The idea with the double loops was to keep this thread asleep when we could detect meaningful work elsewhere in the kernel. You could just remove the inner-most loop if it offends you. :) Rgds -- -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/