Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp5062536iog; Wed, 22 Jun 2022 11:09:55 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ue4HMvmDtn3waZTJqCdgUv8TRzfk5v70wxKeWoEKnF+YZXTRIMNelIkteZgvE9he/kNX30 X-Received: by 2002:a65:588b:0:b0:3fe:4237:2ee5 with SMTP id d11-20020a65588b000000b003fe42372ee5mr3974295pgu.442.1655921395524; Wed, 22 Jun 2022 11:09:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655921395; cv=none; d=google.com; s=arc-20160816; b=JQ54RXYQGsowDdn0SWspxDBEb1dn6njZENcIJor4ky/1Bk602G0KL5YGdsB5nfTVnh AbqaD8vLu824oxnBgBj5G8/vvo+8gCoRhzLfg0MiFxF+tDABA8XGXhgeB0bfuDkx4LEb aJ50qiT7PeBdz97K/jp+ipulwGHsc/Xtegiaohp8h722ykadX8PqURWmTqP8bXd2Ho9A sxA/LKVL9PKAJboZpupi7q5C0FhDb2QqZ6WHRYf2UEhLCvjNyC70B/CFGF0A2YXrJaxm mMgj3QRZJiFYr8EOS/1Fw7PNR1w40CMvwrpJqG/u4us8sASwF+w4tOzcoiAkQWVO6kOi HyCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=opRo91P/GqK7yMzaovz4eIUEVNzRY22y9hP9e6SynAE=; b=Df75VvEBESH4sTjxddHLW9SeCF8/WDHou6YPrING9OEwqLk5WxozKRvxCVIUpiJpzf TY4puKC8MjjtAoOA7mQUTRaYzusEJtRvoYC5wcmjXiNr7giCaJ+RHe2nQyet4Dv1OfgT 5/UoirM4QX6T9ErodySKOTReKvODKB+j+mXkdIMRbAHTIm/M5BmPjg3ZZjDjwVIt3kJo J2CZUB73GgChT+Fw9yaR0euNztlfJ0G5tEmcnOvP7VR6SmS1VNxieIw72Gf3T+jUXZDg p908oGu2Ll/1y6XYQrOlSn/UUlywP9aFzt95oR5RSM/Tars9RA3yg7cYHky3djyehE4b 6MBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=D+jNeDTC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l16-20020a635710000000b0040c8a3cab3esi16886055pgb.638.2022.06.22.11.09.41; Wed, 22 Jun 2022 11:09:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=D+jNeDTC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377462AbiFVRuC (ORCPT + 99 others); Wed, 22 Jun 2022 13:50:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359446AbiFVRuA (ORCPT ); Wed, 22 Jun 2022 13:50:00 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2904933A1E; Wed, 22 Jun 2022 10:50:00 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DD03221B9F; Wed, 22 Jun 2022 17:49:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1655920198; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=opRo91P/GqK7yMzaovz4eIUEVNzRY22y9hP9e6SynAE=; b=D+jNeDTCFQct16h23qveyk5vzFvj/kMfo/QQR3E6yoNoigE+Frq/OOcIgnkqPh7y9namtq mj78bxp35TL74EPYrn99JM4gLqtVq/vNwS8vF00br3rWKiqQHWVE67NGbPEYqoanRFYTPU 2WNEO0SeZeekiINyeRZE7VxL9KstvGY= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B550A134A9; Wed, 22 Jun 2022 17:49:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id z7W3KkZWs2JOMwAAMHmgww (envelope-from ); Wed, 22 Jun 2022 17:49:58 +0000 Date: Wed, 22 Jun 2022 19:49:57 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Lin Feng Cc: tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cgroup.c: remove redundant check for mixable cgroup in cgroup_migrate_vet_dst Message-ID: <20220622174957.GB669@blackbody.suse.cz> References: <20220621092358.223594-1-linf@wangsu.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OXfL5xGRrasGEqWY" Content-Disposition: inline In-Reply-To: <20220621092358.223594-1-linf@wangsu.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --OXfL5xGRrasGEqWY Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 21, 2022 at 05:23:58PM +0800, Lin Feng wrote: > so explicitly checking in cgroup_migrate_vet_dst is unnecessary. Good catch. Reviewed-by: Michal Koutn=FD --OXfL5xGRrasGEqWY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCYrNWQQAKCRAkDQmsBEOq ucMQAQC0vzEGYqYMe6iT+QCRjrhLmh+/uMOR0c3LFFtmaHJ61QEAqVYmOYC4n0eP w/y9++DuP60Q2oG0yFUWmok1L6iL1gs= =mSj7 -----END PGP SIGNATURE----- --OXfL5xGRrasGEqWY--