Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp5085757iog; Wed, 22 Jun 2022 11:38:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vW6sBIY4X19an5twuWdqKrod774Mtn0IYpB8S9VRyO2vnB8rxYmXPAn5AsXQ5dT5Q7aEd0 X-Received: by 2002:a05:6a00:400b:b0:525:1c50:557a with SMTP id by11-20020a056a00400b00b005251c50557amr19846541pfb.4.1655923125724; Wed, 22 Jun 2022 11:38:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655923125; cv=none; d=google.com; s=arc-20160816; b=hdAnQbMzXidR0+CloN3Jr4b1pb8UR+3jLlvJbBu/DOpdiJ84NV2t2zht6rYCfMnRSf Y7mgGyxYR4is2nRkJ78SZz+L5TgPJBPrsJtfDuevFVyyoRQb9glQbm5HgDScD2el4bnh JHn5zLTy5x2zzQc/rglHL5Tss8pqfDqar1LWB+GK5K/i4QQa3TbQc78wtFf8qmgQLaoL zUMRAgcU8/UE90lkXZ3nP+VCPCC2h5DCrqcZ8tKVPreHYHb56ty3ZnsATLlcBX76EjLy PBk/CZC//xP3dlXf/8poGzbLUBo36m4JcUKsnYZ/3VXvof9VZoRhPyUc0xhu+l42SUQ1 4vXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=oI/BG6kMv7o508wnN9X1FBVaJUqCDUEafR/XV67HXDM=; b=IMNtMeDBLzNskDA71x09Ca0PChP36jlNu798n5FH2TeydKSfXHAn7dnLpS/cxK6Ow2 4//fSpiIkZytU63apTEmv40SSs44HDIpuXjMe5yAfNOY/z2XFMJwe4j00MjVUSPmfI0D qlZPd3lb7HvdYOEkcdcGzoeS4noahSpEn/R846whnudFjjodtC4wET7aKSBOJZgCHWRl 5yrgdPfqRJSzlU1wg9fGPcr9Ha70UQppaKUrL2HI98nb5DS1YQNXTh6aLDhX3Kn50QZZ lH900DFNSy5TeCkWpJSvuA2w2ujJLom8jxEvgaRFWHDLjMp/NIBV6sAlOzVrNtXmwL8I Ot4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=M1lnBRZa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x7-20020a1709028ec700b001639975025bsi22579596plo.437.2022.06.22.11.38.33; Wed, 22 Jun 2022 11:38:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=M1lnBRZa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377097AbiFVSKQ (ORCPT + 99 others); Wed, 22 Jun 2022 14:10:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377046AbiFVSKO (ORCPT ); Wed, 22 Jun 2022 14:10:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 727043A1AB; Wed, 22 Jun 2022 11:10:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1461B61CCA; Wed, 22 Jun 2022 18:10:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 62C5AC3411D; Wed, 22 Jun 2022 18:10:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655921412; bh=RdMpY98Dovcj8Z5McfPbAv7/dxekKq/qt1Sdz8M2fns=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=M1lnBRZaS91Spw1v4oBV9+wAMRBYZpEKHBZlajh/I4BZwsxJzUq/TN9FYY7dTowck 7+XYe0koh8xbcF9qhQfI/hA1fEDchj3QWRnqtfkTv+9B5zIN9fueH47uAqbCy8rCxG D5q0LIP7vLum99NLJIhVaCxA6s2PDrJmAR0YbcAebZVNwxWzZyR8qjtubKkKGDfeMw MUtdS5clzwM/Vo28yYszTNtQbe8QjUXLvQQXc264lUxGBcPXZq5PaY36A8sq9caJG5 jFVzNz75LQxpk8mljr6k9eIbV6IOgQh84y+sPRut1RbPi55soJGFQJ5DX4Hgf77lR+ 7RklIbc4+3DuA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 480A7E7386C; Wed, 22 Jun 2022 18:10:12 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] hinic: Replace memcpy() with direct assignment From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165592141229.24504.12499679747935394239.git-patchwork-notify@kernel.org> Date: Wed, 22 Jun 2022 18:10:12 +0000 References: <20220616052312.292861-1-keescook@chromium.org> In-Reply-To: <20220616052312.292861-1-keescook@chromium.org> To: Kees Cook Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com, leon@kernel.org, jiri@nvidia.com, olteanv@gmail.com, simon.horman@corigine.com, netdev@vger.kernel.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Wed, 15 Jun 2022 22:23:12 -0700 you wrote: > Under CONFIG_FORTIFY_SOURCE=y and CONFIG_UBSAN_BOUNDS=y, Clang is bugged > here for calculating the size of the destination buffer (0x10 instead of > 0x14). This copy is a fixed size (sizeof(struct fw_section_info_st)), with > the source and dest being struct fw_section_info_st, so the memcpy should > be safe, assuming the index is within bounds, which is UBSAN_BOUNDS's > responsibility to figure out. > > [...] Here is the summary with links: - hinic: Replace memcpy() with direct assignment https://git.kernel.org/netdev/net/c/1e70212e0315 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html