Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Jun 2022 15:57:47 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Alison Schofield <alison.schofield@intel.com>,
        "Vishal Verma" <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        "Ben Widawsky" <bwidawsk@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-pci@vger.kernel.org>
Subject: Re: [PATCH V11 3/8] PCI: Create PCI library functions in support of
 DOE mailboxes.
Message-ID: <YrOea1PQbSA09A6r@iweiny-desk3>
References: <20220610202259.3544623-1-ira.weiny@intel.com>
 <20220610202259.3544623-4-ira.weiny@intel.com>
 <62ad06a643ddf_844b1294f@dwillia2-xfh.notmuch>
 <20220620112328.00004f63@Huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220620112328.00004f63@Huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iOC7MQHof6SFoihCN2W9CH5I0c/s9IBkruMMWJZewIgwZj3HXBOzS+T4GhY+?=
 =?us-ascii?Q?jwR7c49v3baOx6j4yUUP4C70ZhlOJdGq+KGIT0BT0iLUgCM2kJKdbS0LxtDZ?=
 =?us-ascii?Q?K63Gptn/c32LhORDRgjUnApd4tuSGpM6r7utkdrYVS074g9Eu+WwcoF+a8R6?=
 =?us-ascii?Q?y4KnndHG0duAjLArNqjTBqK8B9OqA1pvV8OKvvcDgYSKfsiI6wybpD0NoTs0?=
 =?us-ascii?Q?+LPhK9XKD8PZ345uFYwrILg3erKTfNb9ymIM2HaIHE+xSEe8U+Vn2npF9kWI?=
 =?us-ascii?Q?tNN7O1ej0Ns4115hC4m8mejDy4OB5AJK1nL/Y9QkNW5voCAZlwBHVT/QQrL6?=
 =?us-ascii?Q?DBxf1Yg3GNOmUriNu2VU6VhVTt1i5VkSyU6gs02Ey+iFi9quGqt7Vk4pUey8?=
 =?us-ascii?Q?kxETnwNPR0Ho531fUzMlTF7UAE5Uz3iYjUb3N973xHvcUuFwvf1ZhjNZ9p7D?=
 =?us-ascii?Q?ivbAEftsv39QQQ21vSm2YI0KPx/aLEUdqZ9v54hGSzrfJ1FtleL9VJJFsXWs?=
 =?us-ascii?Q?kiOTNwZ5H0aebIA0qyTs5WQTLdBdqArjtvNalf1jd8pF+onqaAmI8zMcgmp8?=
 =?us-ascii?Q?0AlFk4AW+At/rGT3w0JY8erYKQs8T+a9S0qUGj6Olf67FwjNkIEKDtKGys5c?=
 =?us-ascii?Q?feijMdo3OnXJcAeaisOVM4sZ5G1fRhYne3dlmaKBzookkLiCNySfdguNte6E?=
 =?us-ascii?Q?lmXarVZx+d0FDujA7CXpiYNR6yiFWPjNvdDnyO8pVvfZ6RBGtc84TKWEQUkH?=
 =?us-ascii?Q?q7czek6i9k8sY+XeGEoFNCKtRa8OgM7c/yFNGAA+Gs9mh4yQSibX6Co2t9km?=
 =?us-ascii?Q?r9VsR3B1UzBwHgd83Nmi6jNMFSazWIOBj4rrfPpgxw6kS6MGENnCwESLFbHm?=
 =?us-ascii?Q?vT/WG5kYkp4tynW9qaoPeHAA7C1QwROA/Xu0n5dpEbGVhir41naafdi5W68g?=
 =?us-ascii?Q?wV/ZOQum17m0xrMiHrDefgESqbYtvR2YmrZN0q5uSKtMzAOif42T7tpe0oRi?=
 =?us-ascii?Q?xjicgWgpSehh12awQj9C4iPo1UUyNWuIyiaxI5IYulTGBmfJxW8Y8DFPcVT1?=
 =?us-ascii?Q?eXe/GzC8opO4FC6FxLUf+wJ2BGsUL+qa9QlUhuLK5DSJa7Y/PoCKIScZtmLN?=
 =?us-ascii?Q?u9uM62O/kxiVCGQx6O8mD6YijlW0Bx7q9tg5ve+ZqBCTrtY/tO6sOKsY7PSV?=
 =?us-ascii?Q?H4hbqspM+fWMhlfapNMDMHkenioBCp0GZYRjmQRwvQ2VXy/g5qev4j3vURfm?=
 =?us-ascii?Q?d7ZbIyMJrYoqs6ZaIgFHRjOq759D5LdD4tGCbOHQxxoWx4XQ4zcjqAV/X7xT?=
 =?us-ascii?Q?i4Uz76X2bLquDASqqkrAXvXl2pqOB+DsEeQATBKoxLeNsHb3bf9dX1T9pkJf?=
 =?us-ascii?Q?nQZeI0pgP+748SqjFk+5jOZOcezNNyiOh4LSNgtKRMPcKUmjgJJV4J6YT+rX?=
 =?us-ascii?Q?IkJxdoesZuB/oPsEZWt87LVL3t3VQMxPXe+ymMxLYxgtbZuZK4kjr+cciNf0?=
 =?us-ascii?Q?H024btrSiIyTselpW6M4jibaAfr/Yn5y+RY297FZawer+yeUUj25yeDSlD3B?=
 =?us-ascii?Q?szQCAPZ4D49PCCsa6GK4XzkRzPYsw6Qrx0HFXxesDCVctt08JTPB2ZX8VuZa?=
 =?us-ascii?Q?Cud2t69aAvJXzM1L4yOkntzMd0jyGfd1WN60kLcjk+HFkKv2gHhdRYBNqbvL?=
 =?us-ascii?Q?5qRWIH3s30DJQTjGFrR+DfCGla3lLMzYSA82TlV+rUTHnrMJ+5Ya+TiXY2F0?=
 =?us-ascii?Q?Ul4Ek5pilS2+lvLbUOh5K12bvT6dVVQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 66a0bf5d-c567-482f-0b75-08da54a2a31d
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2022 22:57:52.5621
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hzz5srQnc2bJ1AkrRsYU/rstWKBAt64bygROeNzu6tzUWitGA5D6Cfwzp1KdVNjxYU3PcxSnvid71J+N8PDvgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2162
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 20, 2022 at 11:23:28AM +0100, Jonathan Cameron wrote:
> On Fri, 17 Jun 2022 15:56:38 -0700
> Dan Williams <dan.j.williams@intel.com> wrote:
> 

[snip]

> > > +static int pci_doe_enable_irq(struct pci_doe_mb *doe_mb, unsigned int irq)
> > > +{
> > > +	struct pci_dev *pdev = doe_mb->pdev;
> > > +	int offset = doe_mb->cap_offset;
> > > +	int rc;
> > > +
> > > +	/*
> > > +	 * Enabling bus mastering is required for MSI/MSIx.  It is safe to call
> > > +	 * this multiple times and thus is called here to ensure that mastering
> > > +	 * is enabled even if the driver has done so.
> > > +	 */  
> > 
> > It is required for MSI/MSIx to work, yes, but if the caller that created
> > the doe object has not set it yet that's its prerogative.
> 
> We went around this in one of the earlier threads, and I think consensus
> was that it made sense to have this in core code.

Yes we did.  This is where Bjorn asked for this to be done I thought.

I verified that pci_set_master() is fine to call more than one time.  If the
caller asks for irq support I think it is fine to do this here to ensure that
support is enabled.

Ira