Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fb6f3d33-2d56-cf3b-25e8-85c24dcbb3d8@kernel.dk>
Date:   Wed, 22 Jun 2022 17:44:43 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: linux-next: Fixes tag needs some work in the block tree
Content-Language: en-US
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Dylan Yudaken <dylany@fb.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
References: <20220623092143.2b9d2e7e@canb.auug.org.au>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20220623092143.2b9d2e7e@canb.auug.org.au>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/22/22 5:21 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   1da6baa4e4c2 ("io_uring: move io_uring_get_opcode out of TP_printk")
> 
> Fixes tag
> 
>   Fixes: 033b87d2 ("io_uring: use the text representation of ops in trace")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").

I'll rebase on -rc4 anyway, I'll fix thie one up.

Dylan, here's what I use for adding Fixes tags:

[pretty]
        fixes = Fixes: %h (\"%s\")

and then I just do:

git fixes 033b87d2
Fixes: 033b87d24f72 ("io_uring: use the text representation of ops in trace")

to generate it.

-- 
Jens Axboe