Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp5477956iog; Wed, 22 Jun 2022 21:47:03 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s3fDUe9awIsAtPjAxXqi1Mh0SvI1thETjRTT5P8rOWkE8AvkrNTSXFZagnbOVeT/1ZB17w X-Received: by 2002:a05:6402:358c:b0:435:9daf:e825 with SMTP id y12-20020a056402358c00b004359dafe825mr8447127edc.375.1655959623522; Wed, 22 Jun 2022 21:47:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655959623; cv=none; d=google.com; s=arc-20160816; b=Y+8o6UK1l6MpWrjWudFOvG/XudEj8qAxZFP7b+qoGQ/XERGkc77Vkb16Zr+1fFHfK+ 4qSkwyGBpO5m70SdueeiZz3fLv0reBAh4XTWnAesQ1jorlm3uCY5AP8f/LnacQVcX3qf QkutfchBJcZrHzzQcEaCMXXTHG8fNuxcu8oiPdl1yFNaqYcCXJEK1eF8L3nU+i0a2POw HKqoVlcVMWq1coVWe9OLsHoE3MHFCelN4bArc5EtSOuzwkDsyIPC3hbpXvQKff13WqlK oSBaDWEho5083dHViZh+dpzWjED6rCQBNp6Z9hA/boLr+vJcYGc5liS71KgxjP//NSK9 pJxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Yo7zYlyTA2OYgWe0Dgq1eO9DdL8DF8e4FvAdBZBu6T4=; b=slBoc85la82AzzzNrM/rAaSiahyJmRBELJB7Ez02/szBz7tsU/qgQv3s3F09dgUF5x 8h0BU8TVki/hCZ5s6y/aJcQ6QtcbbZKmXfBme0NbXQhdXo6Tb6sViwkMvxCbQdg5w5nU +UUyCLVxYH2ZHZtkGvEdHjJMArEYzwQ500m0wQHqS6ymngOrSfhf5JW1Kdf76RQSh+2K elgrSztu1415p/Gx5RtJdhzUdIy1oWrwpb2MQPDl+zoI2LVo6XyRHPasT3vL7dpeb1Wz Oz0Fp86s+EBjwrRI6DIFRJjLSI1uz8R56cAKYtnCfrLtcp8/yUiBaRXYrf+GHBbGVqio WBCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n9-20020a17090673c900b00706d5138d5bsi7178157ejl.183.2022.06.22.21.46.36; Wed, 22 Jun 2022 21:47:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232297AbiFWEo7 (ORCPT + 99 others); Thu, 23 Jun 2022 00:44:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243710AbiFWDvF (ORCPT ); Wed, 22 Jun 2022 23:51:05 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 526D83DDE8; Wed, 22 Jun 2022 20:51:01 -0700 (PDT) X-UUID: e9475722f96d40ea95b54e3eaa8033a8-20220623 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.6,REQID:ec151897-e2bd-4893-9d1d-0a0478c2fb54,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:b14ad71,CLOUDID:dfc047ea-f7af-4e69-92ee-0fd74a0c286c,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: e9475722f96d40ea95b54e3eaa8033a8-20220623 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1569367820; Thu, 23 Jun 2022 11:50:55 +0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Thu, 23 Jun 2022 11:50:55 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 23 Jun 2022 11:50:54 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 23 Jun 2022 11:50:54 +0800 From: Stanley Chu To: , , , , , , CC: , , , , , , , , , , , , Subject: [PATCH v2 8/8] scsi: ufs-mediatek: Fix invalid access to vccqx Date: Thu, 23 Jun 2022 11:50:52 +0800 Message-ID: <20220623035052.18802-9-stanley.chu@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20220623035052.18802-1-stanley.chu@mediatek.com> References: <20220623035052.18802-1-stanley.chu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alice Chao NULL pointer access issue was found for the regulator released by ufs_mtk_vreg_fix_vccq(). Simply fix this issue by clearing the released vreg pointer in ufs_hba struct. Reviewed-by: Stanley Chu Signed-off-by: Alice Chao Signed-off-by: Stanley Chu --- drivers/ufs/host/ufs-mediatek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index 125d64e097f2..2404df9c3a01 100755 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -758,6 +758,7 @@ static void ufs_mtk_vreg_fix_vccqx(struct ufs_hba *hba) regulator_disable((*vreg_off)->reg); devm_kfree(hba->dev, (*vreg_off)->name); devm_kfree(hba->dev, *vreg_off); + *vreg_off = NULL; } } -- 2.18.0