Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Jun 2022 23:05:27 -0500
From:   Mike Rapoport <rppt@kernel.org>
To:     "Huang, Shaoqin" <shaoqin.huang@intel.com>
Cc:     Rebecca Mckeever <remckee0@gmail.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v3 2/4] memblock tests: add verbose output to memblock
 tests
Message-ID: <YrPmhzZDd9YFyEUa@kernel.org>
References: <cover.1655889641.git.remckee0@gmail.com>
 <004e021cc3cb7be8749361b3b1cb324459b9cb9f.1655889641.git.remckee0@gmail.com>
 <b7e6565b-d9f7-a5cc-8e66-087ea7b270d1@intel.com>
 <YrO3uyXee9DcMTzz@bertie>
 <d53b547a-1450-82de-a3c5-4bb09f2a728d@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d53b547a-1450-82de-a3c5-4bb09f2a728d@intel.com>
Precedence: bulk

On Thu, Jun 23, 2022 at 09:29:05AM +0800, Huang, Shaoqin wrote:
> 
> 
> On 6/23/2022 8:45 AM, Rebecca Mckeever wrote:
> > On Wed, Jun 22, 2022 at 06:32:04PM +0800, Huang, Shaoqin wrote:
> > > Just test it and everything works fine. And I think there are some thing can
> > > improve:
> > > 
> > >      The prefix_push() and prefix_pop() are used in so many functions and
> > > almost of them just put the prefix_push(__func__) begin in the head and the
> > > prefix_pop() in the end.
> > >      May be you can define some macro that when you output something and
> > > automatically push the __func__ as prefix. And when leave the function,
> > > automatically pop it. And only in some special place, you call it manually.
> > > 
> > Thank you for your review. I'm not sure how you would automatically push
> > __func__ since you have to be inside the function to access that
> > variable. Let me know if you have any suggestions. I am thinking about
> > adding another function in common.c that just calls test_pass() followed
> > by prefix_pop() since those are called together so often.
> 
> Just like:
> #define test_pass_macro()               \
>          do {                            \
>                  prefix_push(__func__);  \
>                  test_pass();            \
>                  prefix_pop();           \
>          } while (0)

This will not print the name of the failing test, e.g. instead of 

not ok 28 : memblock_alloc: alloc_bottom_up_disjoint_check: failed

with Rebecca's implementation it'll print

not ok 28 : memblock_alloc: failed

How about

#define PREFIX_PUSH() 	prefix_push(__func__)?
 
> This macro will automatically push the __fun__ as prefix when you call
> test_pass_macro(). And then pop it after test_pass() output.
> 
> And use this macro() to hidden most of the paired prefix_* functions.
> 
> And I think that's the simplist way. May be someone has a better solution.
> 

-- 
Sincerely yours,
Mike.