Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759765AbXEYHcQ (ORCPT ); Fri, 25 May 2007 03:32:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750937AbXEYHcF (ORCPT ); Fri, 25 May 2007 03:32:05 -0400 Received: from one.firstfloor.org ([213.235.205.2]:40712 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750911AbXEYHcE (ORCPT ); Fri, 25 May 2007 03:32:04 -0400 Date: Fri, 25 May 2007 09:31:58 +0200 From: Andi Kleen To: Satyam Sharma Cc: Ingo Molnar , Andrew Morton , Andi Kleen , linux-kernel@vger.kernel.org, Peter Zijlstra Subject: Re: [patch] sched_clock(): cleanups Message-ID: <20070525073158.GB8094@one.firstfloor.org> References: <20070525071005.GA6431@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 573 Lines: 21 > if (!f) > f = cpufreq_get(freq->cpu); > if (!f) > f = tsc_khz; > > ? > > Something's not quite right here :-) What do you think is wrong? cpufreq_get can return 0. Admittedly the second test could be inside a block of the first, but then it would make the code more ugly and this code is not performance critical. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/