Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp5487750iog; Wed, 22 Jun 2022 22:03:54 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vzJKUL4NSQKmuoM4zFMVBgnUrSxc9EDKog1dZcGVYK1nQDDl3lkaIe2fFpYkxneME99BIp X-Received: by 2002:a17:902:ecc9:b0:163:e41c:bf12 with SMTP id a9-20020a170902ecc900b00163e41cbf12mr37335662plh.164.1655960633865; Wed, 22 Jun 2022 22:03:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655960633; cv=none; d=google.com; s=arc-20160816; b=X2i8R0EkXNm6hctRlAKEl+kuQBHjy95ARePSxpiLnoHEFKgvDUmbQ6hrFEzDglzRt0 bGk6lzSqF0M+2CpoXHJ5fw5JYkIaBncQ8YWdLqEtWuBDEgGeOVaT6rVdPQ1APYEi6V45 cZlkSYU7WVBwyHtTjHxJd2lOHCYfdebiyrSrl45E3YRDs9N3s8xy/T8/fWbPfwnnSobr CMsXrh9/S5aO7gmwLTf7+UOEKomuy2wFoUVRAhC9Ffyo/GHFSua+tlFKKY20++a2w7N6 +dkLgsOR1rd5mKROHMzuTJYZlq546Sv12rtNq3R1GtiP21pii45DF5zwdKepJvSVWJZC 0QSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=vCFskEDXxGLafelUfJuN2H8kyMSCY3jQDRawFymduC8=; b=Kc5cKBqx896O2gXeALDtm9MpXYXwRA/yUi7Wef/XCuWb/x2yV1ONRM73bXtax9sKT/ RWaYNHdLNXjU3FCKrrMg/UbJqMyE6eubwherHJ//nY8F4AMQ537a0KYqr4HEnRX0wmLc HjETv7YyIBRCuneQVIlEa0/UyPQn/dwRr5G7UBCkaAfyFkx5Wt3l+jc2Ueh7lNhbrKPC Ml84sulo0EHPmn99pg3QWQsuoUXLR7rvMBIlD9U1aOIIufyx5w+8aEWTyJHKwD8y/5a5 tMsG4e5lp2Cwebdq6Fbd7HbGecjTg9VLmn8NZfwVndwhpW1QOytM3K5DyLA1mcsnR1fX COfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m17-20020a170902f21100b00153b2d16643si19254013plc.587.2022.06.22.22.03.41; Wed, 22 Jun 2022 22:03:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230338AbiFWElm (ORCPT + 99 others); Thu, 23 Jun 2022 00:41:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243717AbiFWDvF (ORCPT ); Wed, 22 Jun 2022 23:51:05 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 909933DDDD; Wed, 22 Jun 2022 20:51:00 -0700 (PDT) X-UUID: 06e06426f99a4bbb948a1232235a16ef-20220623 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.6,REQID:69527f6b-7b6c-431a-b3d4-1d23201969c0,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:95,FILE:0,RULE:Release_Ham,ACT ION:release,TS:95 X-CID-INFO: VERSION:1.1.6,REQID:69527f6b-7b6c-431a-b3d4-1d23201969c0,OB:0,LOB: 0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:95,FILE:0,RULE:Spam_GS981B3D,ACT ION:quarantine,TS:95 X-CID-META: VersionHash:b14ad71,CLOUDID:a23ed02d-1756-4fa3-be7f-474a6e4be921,C OID:928279929004,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,QS:nil,BEC:nil,COL:0 X-UUID: 06e06426f99a4bbb948a1232235a16ef-20220623 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 204413354; Thu, 23 Jun 2022 11:50:55 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Thu, 23 Jun 2022 11:50:54 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 23 Jun 2022 11:50:54 +0800 From: Stanley Chu To: , , , , , , CC: , , , , , , , , , , , , Subject: [PATCH v2 5/8] scsi: ufs-mediatek: Disable reset confirm feature by UniPro Date: Thu, 23 Jun 2022 11:50:49 +0800 Message-ID: <20220623035052.18802-6-stanley.chu@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20220623035052.18802-1-stanley.chu@mediatek.com> References: <20220623035052.18802-1-stanley.chu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Po-Wen Kao In MediaTek UFS platforms, UniPro will not return reset confirm if it is in POWERDOWN state thus hang issue may happen while disabling UFSHCI. Simply disable this feature before UniPro leaves POWERDOWN state. Reviewed-by: Stanley Chu Signed-off-by: Po-Wen Kao Signed-off-by: Stanley Chu --- drivers/ufs/host/ufs-mediatek.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index 8184e871ff8e..348966dbad78 100755 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -1079,6 +1079,11 @@ static int ufs_mtk_link_set_lpm(struct ufs_hba *hba) { int err; + /* Disable reset confirm feature by UniPro */ + ufshcd_writel(hba, + (ufshcd_readl(hba, REG_UFS_XOUFS_CTRL) & ~0x100), + REG_UFS_XOUFS_CTRL); + err = ufs_mtk_unipro_set_lpm(hba, true); if (err) { /* Resume UniPro state for following error recovery */ -- 2.18.0