Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760051AbXEYHio (ORCPT ); Fri, 25 May 2007 03:38:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750937AbXEYHii (ORCPT ); Fri, 25 May 2007 03:38:38 -0400 Received: from one.firstfloor.org ([213.235.205.2]:41715 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750871AbXEYHih (ORCPT ); Fri, 25 May 2007 03:38:37 -0400 Date: Fri, 25 May 2007 09:38:36 +0200 From: Andi Kleen To: Ingo Molnar Cc: Satyam Sharma , Andrew Morton , Andi Kleen , linux-kernel@vger.kernel.org, Peter Zijlstra Subject: Re: [patch] sched_clock(): cleanups Message-ID: <20070525073836.GC8094@one.firstfloor.org> References: <20070525071005.GA6431@elte.hu> <20070525072512.GA12683@elte.hu> <20070525072641.GA13025@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070525072641.GA13025@elte.hu> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1094 Lines: 35 On Fri, May 25, 2007 at 09:26:41AM +0200, Ingo Molnar wrote: > > > > if (!f) > > > f = cpufreq_get(freq->cpu); > > > if (!f) > > > f = tsc_khz; > > > > > > ? > > > > > > Something's not quite right here :-) > > ah, that's fine. It does this: 'try to give f a value', and then: 'if > still no value then give it tsc_khz as a last resort) > > call_r_s_f() still needs an urgent rerenaming though =B-) The whole thing would be much simpler if - cpu up callbacks had a way to request executing on the target CPU [i looked at this, but it was a little more involved than a simple cleanup] - smp_call_function_single had sane semantics regarding calling the same CPU similar to on_each_cpu() - C had anonymous lambda functions with nice syntax (ok one can dream) But right now so many callbacks are needed that I ran out of good names. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/