Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Jun 2022 10:05:19 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Felix Schlepper <f3sch.git@outlook.com>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] Staging: rtl8192e: Using kzalloc and delete memset
Message-ID: <20220623070519.GP16517@kadam>
References: <cover.1655909205.git.f3sch.git@outlook.com>
 <AM9P190MB12995D1FF1EECE4C633A865FA5B29@AM9P190MB1299.EURP190.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AM9P190MB12995D1FF1EECE4C633A865FA5B29@AM9P190MB1299.EURP190.PROD.OUTLOOK.COM>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: bLWy+3uFgEazvf20B4dm++NsFVpm0zUaVS4lCe2VMulNeAMZT8umWHRrmyeHl2pMjVohpltGNyIYGeDbE2XI5D7itM6y9Hpq/3L/06hNUTDYpI7686i0jSsrXct8e5RJ3athiJjSUrok/3JzHFmSzOhvRLgahufBIJVnTml/e/hDdSbS1yp1zrr2/wNiODqswhkiKgExc1/UvUSIZs56adpBVItcJl4I4dB/UfzouepX3bVAX20s5eLQnC4RGDeQ5eDSU7OFkdNfV7j6oXv2v65iRdg9pZ/FcY76u+JDBVFgWoWbs1mGvxfLRxNIPR+0rx6hx8zOTtH1rMmR558VOahq5/2oAh2NgN0MGgpqYDJNpzFp5WvJRmxNO9hAWb9qYqt9O2l8yK+BiltKPzVlFAITqH590O3KuC/bZmKlvZMGCLknhmW8ZwSTIFeIk8Inkh53OF1I0KG6C6Gq9Wq7XOOnI1pom3m0YbHC3fb+Ln4tMi8lNbBbhnoJOilDSQuZM60uEBGi2/oR4dQjZWwNWg8VfLkHY41LEqaj15mdNp/FTG+sA88HF5sp1tUul98CKNZL08k/WYmXme3UsCFHy94ooAiSwnqZcL/2N+k8qt7WbsJeNS39ucqX3rhezzguKKd0O5Wbml9fkoOAtO//oUKB2DWTt4ck3YgfUyQjz5MQNxSZWS8F6X2CMsqdfTFtjGXVFgBaBeg9dbh7dgM9MblJ1ohCi1/7Zfiwmmk82DxdFJ5qlUpBXXN39rnkSJ1Q
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15ae0932-38c2-4046-71f1-08da54e6c633
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2022 07:05:37.2380
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZS5WteM6spefFRHj5K457hZCnSOLFZ7X3l121l94HTptWBG7A9kJVrUpAqxSa8cGuSvcZ6dEWuMGfMj7AQgWxLnwXaZa6U6lr52LDn/sZeU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1566
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-23_03:2022-06-22,2022-06-23 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0
 mlxlogscore=999 mlxscore=0 suspectscore=0 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206230026
X-Proofpoint-GUID: Mz8TQ88T8NKWw29uOwF9YIB_V95aFHou
X-Proofpoint-ORIG-GUID: Mz8TQ88T8NKWw29uOwF9YIB_V95aFHou
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 22, 2022 at 05:12:45PM +0200, Felix Schlepper wrote:
> By using kzalloc, we can delete a memset and avoid
> memory initialization defects.
>

This commit message is slightly confusing.  The "avoid memory
initialization defects" bit is very vague.

The difference between the original code and patched code is that the
patched code zeroes out the txb->fragments[] array.  The original code
worked.  The new code is slightly cleaner, but also slower.  Whatever,
either way is fine.

But just state it clearly in the commit message.

  "By using kzalloc, we can delete a memset.  The practical difference
   is that using kzalloc() will zero out the txb->fragments[] array.
   The original code worked fine, but zeroing everything seems nicer."

regards,
dan carpenter