Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754234AbXEYID1 (ORCPT ); Fri, 25 May 2007 04:03:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752148AbXEYIDL (ORCPT ); Fri, 25 May 2007 04:03:11 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:32878 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752320AbXEYIDI (ORCPT ); Fri, 25 May 2007 04:03:08 -0400 Date: Fri, 25 May 2007 10:02:58 +0200 From: Ingo Molnar To: Andi Kleen Cc: Peter Zijlstra , Satyam Sharma , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [patch] sched_clock(): cleanups Message-ID: <20070525080258.GA21446@elte.hu> References: <20070525071005.GA6431@elte.hu> <20070525072512.GA12683@elte.hu> <20070525072641.GA13025@elte.hu> <1180078773.7348.31.camel@twins> <20070525075824.GD8094@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070525075824.GD8094@one.firstfloor.org> User-Agent: Mutt/1.4.2.2i X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.0.3 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 24 * Andi Kleen wrote: > Propose a better way to code this then? It's not my fault that dealing > with callbacks in C is so messy. _here just massages one callback > prototype (smp_call_function's) into another (cpufreq's) because both > callbacks do the same in this case. see the last iteration of the cleanups i did. Naming the function after what it does, and prefixing the preempt-unsafe one __ does the trick. > The r_s_f BTW stands for resync_sc_freq which is a function earlier in > the file and should be familiar to a serious reader. I consider myself a serious reader and it wasnt obvious to me. Names must always be descriptive, we cannot hold all the details in our heads all the time. Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/