Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp5621377iog; Thu, 23 Jun 2022 01:46:54 -0700 (PDT) X-Google-Smtp-Source: AGRyM1unS7PO+5TTC91Cmy7TzHT2nZ+Lpwp7sbM1y2PYx+d63jqcR6tQbdnwp/PgccRoY4XZHtYo X-Received: by 2002:a05:6402:b48:b0:435:728c:d127 with SMTP id bx8-20020a0564020b4800b00435728cd127mr9036001edb.392.1655974014575; Thu, 23 Jun 2022 01:46:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655974014; cv=none; d=google.com; s=arc-20160816; b=A/ygcKwHaXKy552QWL9y71NCJSMTk6H4xuT7L3QB/tRpSqQqekhSr5utFka9SOPQxZ siqcXpVAk2397nqVkX6z/LLLTbehRcfXEpYSoffo7GdBIULOiwYOj5AUb7BAihR04riD Wdq2gCkyYF84SLomLasp2G54lp4kO8kYCaJuHfloW2DXq6phUt26HQY/xsdTeK6eajk9 S+NPNImmUwsZSZkPexROBAFG9Xv3aVBENYvEl95LH3Smkj70x1yMie3npCskODYb9/mx Cm/wlMjoO1h73QmfvnwQz7sPO8yFvMPhUKNJgYUh4c67vLvf6vKGovXEz7YeuV6Fgs7m jikA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=aVZh+q1/JJRejiepCoeV8F3VVcaVHXVJxJkt0uNrfVM=; b=axRJo8fr8k9zlGdGCESn1HuSecYgSuvyQjQU4MY6XHK82U/3AMmY1wQjGUV3iI7ijN UxVC4jNO4AQbPv9nxJ4q6XcLOtUNYQxkXCWCPhIs+XwzoS969tz+jCGxji+dqiA/Aktq hKJbOcydl8Zt1P32jJUND1Yup7cxUgycm92Ak84m/YrVOHHCNeuIL1jzDLadF2F9GLvM w1bApMAr/ttHW03E4zpLT5ydtDBYLWp+tgnKk9yGSoxeK8lG08YDeQLsY2m7AAkreaco diB3imLCEqE3NsArV3u04EKCtO0w6Qz3AMp7zkMwOTvANVTLtENn+QpY+VCIe2hXhfhC JJYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bpb8gFH2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e3-20020a50ec83000000b0043581aaae70si500617edr.490.2022.06.23.01.46.29; Thu, 23 Jun 2022 01:46:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bpb8gFH2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230210AbiFWIKr (ORCPT + 99 others); Thu, 23 Jun 2022 04:10:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230171AbiFWIKo (ORCPT ); Thu, 23 Jun 2022 04:10:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 849154756E; Thu, 23 Jun 2022 01:10:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 43E03B82208; Thu, 23 Jun 2022 08:10:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6ECCEC3411B; Thu, 23 Jun 2022 08:10:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655971841; bh=R3uCGcBzcPhEjKLhoHYVr0mcT7inFO/vUdrx4pb+wmY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bpb8gFH2ZoatfRw2fHmWNw0l08XRetd1naHwiFW0SnH5+PLXNAt3WbYdpzFN7PyLR pzD04MEf/DFEbSUQ1MGQzaIK5f4MrFoqE9zicARpfwAD9aZ4rxKfmKsi3x89f8HGxq JwJEQK6tF7+7Rdml1BXBR2pQd/sIjPDso0xC/6kiD22LCbL/Yv5lrcj1iY7vAmZCXi aH0h4rk1zSQtdHP1ker7Mr+lTM2iRnrRi2N6aFCsSvQgHRVDQ5a3rd3EsdVD+zVxtL bYZv6hI4Vyh1F4EXWR/DBVc9ntWgGJWLS9WUrgJdUJ6D0F8Q1pBQEpwuvHg3GLbfkN tJ2T/s4H7XF4A== Date: Thu, 23 Jun 2022 13:40:37 +0530 From: Vinod Koul To: "Rafael J. Wysocki" Cc: Linux ACPI , LKML , Linux PM , Andy Shevchenko , Mika Westerberg , Hans de Goede , Sakari Ailus , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , alsa-devel@alsa-project.org Subject: Re: [PATCH v2 14/16] soundwire: Use acpi_dev_for_each_child() Message-ID: References: <1843211.tdWV9SEqCh@kreacher> <2653857.mvXUDI8C0e@kreacher> <9017824.rMLUfLXkoz@kreacher> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9017824.rMLUfLXkoz@kreacher> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13-06-22, 20:35, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Instead of walking the list of children of an ACPI device directly, > use acpi_dev_for_each_child() to carry out an action for all of > the given ACPI device's children. > > This will help to eliminate the children list head from struct > acpi_device as it is redundant and it is used in questionable ways > in some places (in particular, locking is needed for walking the > list pointed to it safely, but it is often missing). Applied, thanks -- ~Vinod