Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755498AbXEYIRH (ORCPT ); Fri, 25 May 2007 04:17:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750874AbXEYIQz (ORCPT ); Fri, 25 May 2007 04:16:55 -0400 Received: from viefep18-int.chello.at ([213.46.255.22]:40706 "EHLO viefep12-int.chello.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750936AbXEYIQy (ORCPT ); Fri, 25 May 2007 04:16:54 -0400 Subject: Re: [patch] sched_clock(): cleanups From: Peter Zijlstra To: Andi Kleen Cc: Satyam Sharma , Ingo Molnar , Andrew Morton , linux-kernel@vger.kernel.org In-Reply-To: <20070525075824.GD8094@one.firstfloor.org> References: <20070525071005.GA6431@elte.hu> <20070525072512.GA12683@elte.hu> <20070525072641.GA13025@elte.hu> <1180078773.7348.31.camel@twins> <20070525075824.GD8094@one.firstfloor.org> Content-Type: text/plain Date: Fri, 25 May 2007 10:16:39 +0200 Message-Id: <1180081000.7348.39.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1325 Lines: 32 On Fri, 2007-05-25 at 09:58 +0200, Andi Kleen wrote: > On Fri, May 25, 2007 at 09:39:33AM +0200, Peter Zijlstra wrote: > > On Fri, 2007-05-25 at 13:05 +0530, Satyam Sharma wrote: > > > On 5/25/07, Ingo Molnar wrote: > > > > > > call_r_s_f() still needs an urgent rerenaming though =B-) > > > > > > So does "call_r_s_f_here()" :-) > > > > That name makes me think of INTERCAL's 'DO COME FROM' statement. > > And any code that makes one think of INTERCAL is say,.. special.. :-) > > Propose a better way to code this then? It's not my fault that dealing with > callbacks in C is so messy. _here just massages one callback > prototype (smp_call_function's) into another (cpufreq's) because > both callbacks do the same in this case. I see you point; however a function called: call__here() just doesn't make sense. It says as much as: we should call some_other_function() but for some reason we dont. > The r_s_f BTW stands for resync_sc_freq which is a function earlier > in the file and should be familiar to a serious reader. It was. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/