Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753885AbXEYIRf (ORCPT ); Fri, 25 May 2007 04:17:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752217AbXEYIRY (ORCPT ); Fri, 25 May 2007 04:17:24 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:36063 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750874AbXEYIRW (ORCPT ); Fri, 25 May 2007 04:17:22 -0400 Date: Fri, 25 May 2007 10:16:53 +0200 From: Ingo Molnar To: Peter Zijlstra Cc: Andi Kleen , Satyam Sharma , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [patch] x86_64: fix sched_clock() Message-ID: <20070525081653.GA24308@elte.hu> References: <20070525071005.GA6431@elte.hu> <20070525073158.GB8094@one.firstfloor.org> <20070525073957.GA15207@elte.hu> <20070525074316.GA16821@elte.hu> <20070525074915.GA18400@elte.hu> <20070525075446.GA20140@elte.hu> <1180080906.7348.35.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1180080906.7348.35.camel@twins> User-Agent: Mutt/1.4.2.2i X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.1.7 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 28 * Peter Zijlstra wrote: > On Fri, 2007-05-25 at 09:54 +0200, Ingo Molnar wrote: > > Subject: [patch] x86_64: fix sched_clock() > > From: Ingo Molnar > > > > sched_clock() is totally broken on x86_64, because it is not defined by > > the architecture at all! It fell the victim to the opaqueness of > > __attribute__((weak)) and to non-testing. > > > > the i386 version was supposed to be used. This patch fixes that. Booted > > and tested on x86_64 and i386. > > > > Signed-off-by: Ingo Molnar > Acked-by: Peter Zijlstra > > This does indeed solve my issue. great! Btw., this is also accidental proof that CFS works well even with a jiffies granularity sched_clock() ;-) Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/