Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: XDXLo5ApAaRhi0afwnW74uDZsVX0lSUIPDN8rnv4CBqp63QZ1cWjeRrI4ezv7vJ5sGoPv0UCJ+
 RMlCwCXBue4SoLbv1oV3+H3OdeZ8Dk5Kz3+p8StJ4SRuFKRnUYKEjpWihza0vV7UmZP43a8t5m
 oG6q7TWA4GsN+sohKZTY2SCMU7tR9mri6kPaclpdZp4XCUJKyUQu8C3rK0UX+dxX4NTu6rTSiC
 m4zHKhW6HH1Orx9pKaUUhTLdXDC4HbiXWhXy91tFootiWiQ54hEUNSWSIcBiyT4Iy4+KkyIOyc
 0AkGiLAI7fse701pG39+mTrn
IronPort-SDR: 2hazUpMPcBpzorNqrDgkm+cC+yZ+ALgqj+krYfhrFUdvN4hQVTqPkB9ewjOOjs3kN4+1gnbVTI
 PeNy+OgUbkYZ/PapUzpmAGt/weKWrNtsIIbakCuwch+SZ2ZDNnaRm0h0ub7QIaKG/r8cBgwfIL
 Lb+5CmlwAteWyu6hYp3U7R3thlgh+9gRoe+AMWpGjFW0DOFiGgf7RmyxFd3BSt9622YEzk4Fqq
 5WwVRrsxqvJS0buTPqtWkHGOPNDYeufxwFBiFgMuUNKUmAgS8SOD+8ZnnkE+ShiYY86sJVErdf
 xPw=
WDCIronportException: Internal
Message-ID: <09091cc4-f652-0978-bb6a-b63f24fdcf49@opensource.wdc.com>
Date:   Thu, 23 Jun 2022 17:22:27 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] libata: add horkage for M88V29
Content-Language: en-US
To:     =?UTF-8?B?QsO2c3rDtnJtw6lueWkgWm9sdMOhbg==?= <zboszor@gmail.com>,
        zboszor@pr.hu, linux-kernel@vger.kernel.org,
        linux-ide@vger.kernel.org
References: <20220204125750.1771303-1-zboszor@pr.hu>
 <f726e9e1-bdad-ac8a-368b-aae423a00676@opensource.wdc.com>
 <78c29f43-3b67-8e70-0711-14e997f3efb1@gmail.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <78c29f43-3b67-8e70-0711-14e997f3efb1@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 6/23/22 16:47, B=C3=B6sz=C3=B6rm=C3=A9nyi Zolt=C3=A1n wrote:
> 2022. 02. 08. 9:07 keltez=C3=A9ssel, Damien Le Moal =C3=ADrta:
>> On 2/4/22 21:57, zboszor@pr.hu wrote:
>>> From: Zolt=C3=A1n B=C3=B6sz=C3=B6rm=C3=A9nyi <zboszor@gmail.com>
>>>
>>> This device is a CF card, or possibly an SSD in CF form factor.
>>> It supports NCQ and high speed DMA.
>>>
>>> While it also advertises TRIM support, I/O errors are reported
>>> when the discard mount option fstrim is used. TRIM also fails
>>> when disabling NCQ and not just as an NCQ command.
>>>
>>> TRIM must be disabled for this device.
>>>
>>> Signed-off-by: Zolt=C3=A1n B=C3=B6sz=C3=B6rm=C3=A9nyi <zboszor@gmail.=
com>
>>> ---
>>>   drivers/ata/libata-core.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
>>> index 67f88027680a..4a7f58fcc411 100644
>>> --- a/drivers/ata/libata-core.c
>>> +++ b/drivers/ata/libata-core.c
>>> @@ -4028,6 +4028,7 @@ static const struct ata_blacklist_entry ata_dev=
ice_blacklist [] =3D {
>>>  =20
>>>   	/* devices that don't properly handle TRIM commands */
>>>   	{ "SuperSSpeed S238*",		NULL,	ATA_HORKAGE_NOTRIM, },
>>> +	{ "M88V29*",			NULL,	ATA_HORKAGE_NOTRIM, },
>>>  =20
>>>   	/*
>>>   	 * As defined, the DRAT (Deterministic Read After Trim) and RZAT
>> Applied to for-5.17-fixes. Thanks !
>=20
> Thank you. However, I have second thoughts about this patch.
> The device advertises this:
>=20
> # hdparm -iI /dev/sda
> ...
>  =C2=A0Enabled Supported
>  =C2=A0=C2=A0=C2=A0 *=C2=A0=C2=A0=C2=A0 Data Set Management TRIM suppor=
ted (limit 1 block)
> ...
>=20
> but the I/O failures always reported higher number of blocks,
> IIRC the attempted number of block was 8 or so.
>=20
> Can the kernel limit or split TRIM commands according to the
> advertised limit? If not (or not yet) then the quirk is good for now.

Yes, the kernel does that. See the sysfs queue attributes
discard_max_bytes and discard_max_hw_bytes. What are the values for your
device ? I think that the "limit 1 block" indicated by hdparm is simply t=
o
say that the DSM command (to trim the device) accept only at most a 1
block (512 B) list of sectors to trim. That is not the actual trim limit
for each sector range in that list.

>=20
> Best regards,
> Zolt=C3=A1n B=C3=B6sz=C3=B6rm=C3=A9nyi
>=20


--=20
Damien Le Moal
Western Digital Research