Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Jun 2022 12:48:38 +0200
From:   Steffen Klassert <steffen.klassert@secunet.com>
To:     Nicolas Dichtel <nicolas.dichtel@6wind.com>
CC:     Eyal Birger <eyal.birger@gmail.com>, <dsahern@kernel.org>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <yoshfuji@linux-ipv6.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <shmulik.ladkani@gmail.com>
Subject: Re: [PATCH ipsec-next] xfrm: no need to set DST_NOPOLICY in IPv4
Message-ID: <20220623104838.GC566407@gauss3.secunet.de>
References: <20220520104845.2644470-1-eyal.birger@gmail.com>
 <8557f7a3-9fc6-393d-14bd-d7bd26c4e7fc@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8557f7a3-9fc6-393d-14bd-d7bd26c4e7fc@6wind.com>
Precedence: bulk

On Fri, May 20, 2022 at 02:01:19PM +0200, Nicolas Dichtel wrote:
> 
> Le 20/05/2022 ? 12:48, Eyal Birger a ?crit?:
> > This is a cleanup patch following commit e6175a2ed1f1
> > ("xfrm: fix "disable_policy" flag use when arriving from different devices")
> > which made DST_NOPOLICY no longer be used for inbound policy checks.
> > 
> > On outbound the flag was set, but never used.
> > 
> > As such, avoid setting it altogether and remove the nopolicy argument
> > from rt_dst_alloc().
> > 
> > Signed-off-by: Eyal Birger <eyal.birger@gmail.com>
> Reviewed-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

Now applied to ipsec-next, thanks everyone!