Message-ID: <4656A0F0.4050909@s5r6.in-berlin.de>
Date: Fri, 25 May 2007 10:40:16 +0200
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.2) Gecko/20070222 SeaMonkey/1.1.1
MIME-Version: 1.0
To: Jiri Slaby <jirislaby@gmail.com>
CC: Yoann Padioleau <padator@wanadoo.fr>, kernel-janitors@lists.osdl.org,
       akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] old declaration ritchie style fix
References: <87y7jemb1u.fsf@wanadoo.fr> <46568F7F.1040100@gmail.com>
In-Reply-To: <46568F7F.1040100@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 817
Lines: 27

Jiri Slaby wrote:
> Yoann Padioleau napsal(a):
>>  static int
>> -receivepkt (target, buffer)
>> -	int target;
>> -	unsigned char *buffer;
>> +receivepkt (int target, unsigned char *buffer)
> 
> When you are at it, you can also get rid of bsd return-type-on-its-own-line
> style

return-type-on-its-own-line is IMO OK if it occurs consistently in a
file.  It can improve readability particularly if long return types are
combined with long function names.

> + remove the space before parenthesis.

Indeed.
-- 
Stefan Richter
-=====-=-=== -=-= ==--=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/