Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp5780802iog; Thu, 23 Jun 2022 05:20:52 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v8TP1tXXMN301pPM1czDCeREOZLLye3MkB06js0T/FLllN6xM6JeYWfgohKS+WDysM3Kx/ X-Received: by 2002:a17:902:eac2:b0:169:847f:9443 with SMTP id p2-20020a170902eac200b00169847f9443mr34701603pld.156.1655986852670; Thu, 23 Jun 2022 05:20:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655986852; cv=none; d=google.com; s=arc-20160816; b=Kr52OBL8yFU3icTOizw3lMt3HVm9un92JDl5pOFpJecJkOfWi4QhbqvxhyIZMWGaI2 JOhXb/OzCGbv2JM75MgBWZ23dlfDOStDC/v8poWgShWwL89gWNTLDMXCEmXuGfMJ+q+B HfRBqJ/n1eqluHinxx7pZMKesw3wXB4Efla38JtNbcAS9EeOVOT+1LZYTYcZUH6Nh5zA XfxK7AhM3Wq8j8Mup8DgzxwyavVRqfeR35C0so0urPNWHpz2e0y19OOyMt9NgaPRHtTA ZC6NNRftqLsDwnRgevXejKtwiROrMoBYxvZ0JXrThCdlezK8D5EQtkDkBv8Sb+uR87TZ apKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=vmV9TLjxmp6Sv8yQSTuuC0cHR7DHzk13O3QG+7MFjEI=; b=KpXBcn/SbWIG6k9nGP/ioP8y0c5FXEBtvCWvkWHKIg6ioQAZ84WzjdDcw3bywku5oV 96FspM67XEMdq4GRH7xGANw0+lkMbomBXC00koaR9XbkdpqMNd6hOgmLVTRG5Yv1jvP7 U9ulKwQ3VVOqnwNGs399reGAbhp55p4UG06KO8xbclEBBfWEun6qkjlnOZnu3kV+QHyt fB2RyM4vxL0pm3TRQgKF01+fXRBZzRs8qbAfc4PGC2roc48IpY/tdqsZQzl4Qpxif7AS 6zuSgAEIlkRSuNVi9KmOVftcbZhIIm2FMkt/7km3SDG/JEJJgdlPUyslP2hUIllgmQzv dD+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a24-20020a1709027d9800b00168a2e1fea5si12090113plm.392.2022.06.23.05.20.40; Thu, 23 Jun 2022 05:20:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231612AbiFWMEf (ORCPT + 99 others); Thu, 23 Jun 2022 08:04:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231503AbiFWME2 (ORCPT ); Thu, 23 Jun 2022 08:04:28 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 830FB48E50; Thu, 23 Jun 2022 05:04:24 -0700 (PDT) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LTJm01YXWzkWYG; Thu, 23 Jun 2022 20:02:40 +0800 (CST) Received: from kwepemm600009.china.huawei.com (7.193.23.164) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 23 Jun 2022 20:03:53 +0800 Received: from [10.174.176.73] (10.174.176.73) by kwepemm600009.china.huawei.com (7.193.23.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 23 Jun 2022 20:03:53 +0800 Subject: Re: [PATCH -next v5 3/8] blk-throttle: factor out code to calculate ios/bytes_allowed To: =?UTF-8?Q?Michal_Koutn=c3=bd?= CC: , , , , , , References: <20220528064330.3471000-1-yukuai3@huawei.com> <20220528064330.3471000-4-yukuai3@huawei.com> <20220622172706.GA28777@blackbody.suse.cz> From: Yu Kuai Message-ID: <21aabcb3-9801-f159-103c-9e1c35983237@huawei.com> Date: Thu, 23 Jun 2022 20:03:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20220622172706.GA28777@blackbody.suse.cz> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.73] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600009.china.huawei.com (7.193.23.164) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, 在 2022/06/23 1:27, Michal Koutný 写道: > On Sat, May 28, 2022 at 02:43:25PM +0800, Yu Kuai wrote: >> +static u64 calculate_bytes_allowed(u64 bps_limit, >> + unsigned long jiffy_elapsed_rnd) > > Just noticed with all series applied this argument needn't be called > _rnd. (It's a nit.) > Yes, you're right. I'll change that in next version. Thanks, Kuai