Date: Fri, 25 May 2007 10:45:47 +0200
From: Andi Kleen <andi@firstfloor.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andi Kleen <andi@firstfloor.org>, Satyam Sharma <satyam.sharma@gmail.com>,
       Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       Peter Zijlstra <a.p.zijlstra@chello.nl>, akpm@osdl.org
Subject: Re: [patch] x86_64: fix sched_clock()
Message-ID: <20070525084547.GJ8094@one.firstfloor.org>
References: <20070525073957.GA15207@elte.hu> <20070525074316.GA16821@elte.hu> <20070525074915.GA18400@elte.hu> <20070525075446.GA20140@elte.hu> <20070525080209.GE8094@one.firstfloor.org> <20070525080415.GB21446@elte.hu> <20070525082018.GF8094@one.firstfloor.org> <20070525083430.GB27236@elte.hu> <20070525084109.GI8094@one.firstfloor.org> <20070525084426.GA29973@elte.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070525084426.GA29973@elte.hu>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 880
Lines: 23

On Fri, May 25, 2007 at 10:44:26AM +0200, Ingo Molnar wrote:
> 
> * Andi Kleen <andi@firstfloor.org> wrote:
> 
> > > arch/i386/kernel/sched-clock.c (now built on x86_64 too with the 
> > > patch i sent) uses the tsc_disable global flag which is non-existent 
> > > on x86_64. So my tsc.h change adds that global flag, always-defined 
> > > to 0.
> > 
> > My version of sched_clock.c doesn't have any reference to tsc_disable.
> 
> must be an -mm fix. I used -mm as a basis of my work. Please apply my 
> patch.

I would prefer to find out why the mm patch was added and then hopefully
remove it.  IMNSHO it should not be needed.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/