Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp5827147iog; Thu, 23 Jun 2022 06:12:35 -0700 (PDT) X-Google-Smtp-Source: AGRyM1shHJUzey2xpB2cifyH9RzJCpNLYBOT8fnRMP7HIQo6sdxyFoOpeLJ3rjXzTBejyIHdwt6c X-Received: by 2002:a17:90b:4b8c:b0:1ec:c7b8:7cb9 with SMTP id lr12-20020a17090b4b8c00b001ecc7b87cb9mr3970550pjb.86.1655989955285; Thu, 23 Jun 2022 06:12:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655989955; cv=none; d=google.com; s=arc-20160816; b=VTQzo0wjnso2OhFLDDfyJ08ME8cZtZJAWcXjk4+W1P+mwKe/dj4QgwVdBNRkyhYlE0 bnREQaI/8H/oy+hE7bP4nHUHs42AP//l2IpOLbZIEY0y8xNLux+qgrpwNPikYBcnQhsr Jea22OmbNsH7t9Cboc+Wa4dU6KzYsvdA2NjZXwAuRCb4pTn2L2pjEXG3PQPDyuez7gxF vu+6hV/MPsYyJclMDV6MD2l9wpl8iPlXi96KVlbXXUuin1QJ9ndG1qp+DvhQp0jUmJ/i ydUmiNmwhhs8mX31qMPBE2UZrBaYRJ8eIgm7Mk+X3I2X9zD59QnE9jB+VeM14aTLeVaW uhEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:mime-version :content-transfer-encoding:references:in-reply-to:subject:cc:to:from :date; bh=g12174EImAGdOVMHg7fzGaoy7MZ2qQlJWLiFod4X5MA=; b=MQxCFsrVtfXlCQ/Ohm1nWZ9OTYEgv9McfQ3zomc5frp7qyv1DXWt4uiKa2ejy3zYCS O5NNqarZPgOyoPI6Gr5gBKm0xHdl012ETJL+9CSo0bQsDJRqYBaWn59F9VILn8YrXr/G 8xWhQ+iO1Bzk+0JmvKh/zP4jgLgNriDjCirVvI7jWi/ht2+WwXNUIedY9UGOepOu6fqu JoA8zOg3j/Eod6jGvZhPhoCzhR32499T8+8HX5gGd7A2VBzZS6oID/fmno35Q5pMkykv oxmHy03xAzBBuWnj5rcWd3G6NLhSdegceivdmrDGg+BMx3FkNcIsiQtCnIuFCLqoSru6 RbPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e186-20020a6369c3000000b0040ca1e323cfsi17314109pgc.140.2022.06.23.06.12.22; Thu, 23 Jun 2022 06:12:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231451AbiFWMQ4 (ORCPT + 99 others); Thu, 23 Jun 2022 08:16:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229992AbiFWMQz (ORCPT ); Thu, 23 Jun 2022 08:16:55 -0400 Received: from zju.edu.cn (spam.zju.edu.cn [61.164.42.155]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 58AEC2DA84; Thu, 23 Jun 2022 05:16:52 -0700 (PDT) Received: by ajax-webmail-mail-app3 (Coremail) ; Thu, 23 Jun 2022 20:16:36 +0800 (GMT+08:00) X-Originating-IP: [10.190.71.226] Date: Thu, 23 Jun 2022 20:16:36 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: duoming@zju.edu.cn To: "Paolo Abeni" Cc: linux-hams@vger.kernel.org, ralf@linux-mips.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 2/2] net: rose: fix null-ptr-deref caused by rose_kill_by_neigh X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.13 build 20210104(ab8c30b6) Copyright (c) 2002-2022 www.mailtech.cn zju.edu.cn In-Reply-To: <30eac5047e0e3b6edce260fb31d3f6527e142dee.camel@redhat.com> References: <49f1e353c0a1e4f896cb255d77d08888d7b2e3fc.1655869357.git.duoming@zju.edu.cn> <30eac5047e0e3b6edce260fb31d3f6527e142dee.camel@redhat.com> Content-Transfer-Encoding: base64 Content-Type: text/plain; charset=UTF-8 MIME-Version: 1.0 Message-ID: <511a3b91.ba09.181907e28b1.Coremail.duoming@zju.edu.cn> X-Coremail-Locale: zh_CN X-CM-TRANSID: cC_KCgD3x8ikWbRixNG6AA--.14256W X-CM-SenderInfo: qssqjiasttq6lmxovvfxof0/1tbiAgYKAVZdtaXdKAACsj X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGVsbG8sCgpPbiBUaHUsIDIzIEp1biAyMDIyIDExOjMwOjA0ICswMjAwIFBhb2xvIEFiZW5pIHdy b3RlOgoKPiA+IFdoZW4gdGhlIGxpbmsgbGF5ZXIgY29ubmVjdGlvbiBpcyBicm9rZW4sIHRoZSBy b3NlLT5uZWlnaGJvdXIgaXMKPiA+IHNldCB0byBudWxsLiBCdXQgcm9zZS0+bmVpZ2hib3VyIGNv dWxkIGJlIHVzZWQgYnkgcm9zZV9jb25uZWN0aW9uKCkKPiA+IGFuZCByb3NlX3JlbGVhc2UoKSBs YXRlciwgYmVjYXVzZSB0aGVyZSBpcyBubyBzeW5jaHJvbml6YXRpb24gYW1vbmcKPiA+IHRoZW0u IEFzIGEgcmVzdWx0LCB0aGUgbnVsbC1wdHItZGVyZWYgYnVncyB3aWxsIGhhcHBlbi4KPiA+IAo+ ID4gT25lIG9mIHRoZSBudWxsLXB0ci1kZXJlZiBidWdzIGlzIHNob3duIGJlbG93Ogo+ID4gCj4g PiAgICAgKHRocmVhZCAxKSAgICAgICAgICAgICAgICAgIHwgICAgICAgICh0aHJlYWQgMikKPiA+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgcm9zZV9jb25uZWN0Cj4gPiByb3Nl X2tpbGxfYnlfbmVpZ2ggICAgICAgICAgICAgIHwgICAgbG9ja19zb2NrKHNrKQo+ID4gICBzcGlu X2xvY2tfYmgoJnJvc2VfbGlzdF9sb2NrKSB8ICAgIGlmICghcm9zZS0+bmVpZ2hib3VyKQo+ID4g ICByb3NlLT5uZWlnaGJvdXIgPSBOVUxMOy8vKDEpICB8Cj4gPiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAgcm9zZS0+bmVpZ2hib3VyLT51c2UrKzsvLygyKQo+ID4gCj4gPiBU aGUgcm9zZS0+bmVpZ2hib3VyIGlzIHNldCB0byBudWxsIGluIHBvc2l0aW9uICgxKSBhbmQgZGVy ZWZlcmVuY2VkCj4gPiBpbiBwb3NpdGlvbiAoMikuCj4gPiAKPiA+IFRoZSBLQVNBTiByZXBvcnQg dHJpZ2dlcmVkIGJ5IFBPQyBpcyBzaG93biBiZWxvdzoKPiA+IAo+ID4gS0FTQU46IG51bGwtcHRy LWRlcmVmIGluIHJhbmdlIFsweDAwMDAwMDAwMDAwMDAwMjgtMHgwMDAwMDAwMDAwMDAwMDJmXQo+ ID4gLi4uCj4gPiBSSVA6IDAwMTA6cm9zZV9jb25uZWN0KzB4NmMyLzB4ZjMwCj4gPiBSU1A6IDAw MTg6ZmZmZjg4ODAwYWI0N2Q2MCBFRkxBR1M6IDAwMDAwMjA2Cj4gPiBSQVg6IDAwMDAwMDAwMDAw MDAwMDUgUkJYOiAwMDAwMDAwMDAwMDAwMDJhIFJDWDogMDAwMDAwMDAwMDAwMDAwMAo+ID4gUkRY OiBmZmZmODg4MDBhYjM4MDAwIFJTSTogZmZmZjg4ODAwYWI0N2U0OCBSREk6IGZmZmY4ODgwMGFi MzgzMDkKPiA+IFJCUDogZGZmZmZjMDAwMDAwMDAwMCBSMDg6IDAwMDAwMDAwMDAwMDAwMDAgUjA5 OiBmZmZmZWQxMDAxNTY3MDYyCj4gPiBSMTA6IGRmZmZlOTEwMDE1NjcwNjMgUjExOiAxZmZmZjEx MDAxNTY3MDYxIFIxMjogMWZmZmYxMTAwMGQxN2NkMAo+ID4gUjEzOiBmZmZmODg4MDA2OGJlNjgw IFIxNDogMDAwMDAwMDAwMDAwMDAwMiBSMTU6IDFmZmZmMTEwMDBkMTdjZDAKPiA+IC4uLgo+ID4g Q2FsbCBUcmFjZToKPiA+ICAgPFRBU0s+Cj4gPiAgID8gX19sb2NhbF9iaF9lbmFibGVfaXArMHg1 NC8weDgwCj4gPiAgID8gc2VsaW51eF9uZXRsYmxfc29ja2V0X2Nvbm5lY3QrMHgyNi8weDMwCj4g PiAgID8gcm9zZV9iaW5kKzB4NWIwLzB4NWIwCj4gPiAgIF9fc3lzX2Nvbm5lY3QrMHgyMTYvMHgy ODAKPiA+ICAgX194NjRfc3lzX2Nvbm5lY3QrMHg3MS8weDgwCj4gPiAgIGRvX3N5c2NhbGxfNjQr MHg0My8weDkwCj4gPiAgIGVudHJ5X1NZU0NBTExfNjRfYWZ0ZXJfaHdmcmFtZSsweDQ2LzB4YjAK PiA+IAo+ID4gVGhpcyBwYXRjaCBhZGRzIGxvY2tfc29jaygpIGluIHJvc2Vfa2lsbF9ieV9uZWln aCgpIGluIG9yZGVyIHRvCj4gPiBzeW5jaHJvbml6ZSB3aXRoIHJvc2VfY29ubmVjdCgpIGFuZCBy b3NlX3JlbGVhc2UoKS4KPiA+IAo+ID4gTWVhbndoaWxlLCB0aGlzIHBhdGNoIGFkZHMgc29ja19o b2xkKCkgcHJvdGVjdGVkIGJ5IHJvc2VfbGlzdF9sb2NrCj4gPiB0aGF0IGNvdWxkIHN5bmNocm9u aXplIHdpdGggcm9zZV9yZW1vdmVfc29ja2V0KCkgaW4gb3JkZXIgdG8gbWl0aWdhdGUKPiA+IFVB RiBidWcgY2F1c2VkIGJ5IGxvY2tfc29jaygpIHdlIGFkZC4KPiA+IAo+ID4gV2hhdCdzIG1vcmUs IHRoZXJlIGlzIG5vIG5lZWQgdXNpbmcgcm9zZV9uZWlnaF9saXN0X2xvY2sgdG8gcHJvdGVjdAo+ ID4gcm9zZV9raWxsX2J5X25laWdoKCkuIEJlY2F1c2Ugd2UgaGF2ZSBhbHJlYWR5IHVzZWQgcm9z ZV9uZWlnaF9saXN0X2xvY2sKPiA+IHRvIHByb3RlY3QgdGhlIHN0YXRlIGNoYW5nZSBvZiByb3Nl X25laWdoIGluIHJvc2VfbGlua19mYWlsZWQoKSwgd2hpY2gKPiA+IGlzIHdlbGwgc3luY2hyb25p emVkLgo+ID4gCj4gPiBGaXhlczogMWRhMTc3ZTRjM2Y0ICgiTGludXgtMi42LjEyLXJjMiIpCj4g PiBTaWduZWQtb2ZmLWJ5OiBEdW9taW5nIFpob3UgPGR1b21pbmdAemp1LmVkdS5jbj4KPiA+IC0t LQo+ID4gIG5ldC9yb3NlL2FmX3Jvc2UuYyAgICB8IDUgKysrKysKPiA+ICBuZXQvcm9zZS9yb3Nl X3JvdXRlLmMgfCAyICsrCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykKPiA+ IAo+ID4gZGlmZiAtLWdpdCBhL25ldC9yb3NlL2FmX3Jvc2UuYyBiL25ldC9yb3NlL2FmX3Jvc2Uu Ywo+ID4gaW5kZXggYmYyZDk4NmE2YmMuLmRlY2U2MzdlMjc0IDEwMDY0NAo+ID4gLS0tIGEvbmV0 L3Jvc2UvYWZfcm9zZS5jCj4gPiArKysgYi9uZXQvcm9zZS9hZl9yb3NlLmMKPiA+IEBAIC0xNjks OSArMTY5LDE0IEBAIHZvaWQgcm9zZV9raWxsX2J5X25laWdoKHN0cnVjdCByb3NlX25laWdoICpu ZWlnaCkKPiA+ICAJCXN0cnVjdCByb3NlX3NvY2sgKnJvc2UgPSByb3NlX3NrKHMpOwo+ID4gIAo+ ID4gIAkJaWYgKHJvc2UtPm5laWdoYm91ciA9PSBuZWlnaCkgewo+ID4gKwkJCXNvY2tfaG9sZChz KTsKPiA+ICAJCQlyb3NlX2Rpc2Nvbm5lY3QocywgRU5FVFVOUkVBQ0gsIFJPU0VfT1VUX09GX09S REVSLCAwKTsKPiA+ICAJCQlyb3NlLT5uZWlnaGJvdXItPnVzZS0tOwo+ID4gKwkJCXNwaW5fdW5s b2NrX2JoKCZyb3NlX2xpc3RfbG9jayk7Cj4gCj4gWW91IGNhbid0IHJlbGVhc2UgdGhlIGxvY2sg cHJvdGVjdGluZyB0aGUgbGlzdCB0cmF2ZXJzYWwsIHRoZW4gcmUtCj4gYWNxdWlyZSBpdCBhbmQg a2VlcCB0cmF2ZXJzaW5nIHVzaW5nIHRoZSBzYW1lIGl0ZXJhdG9yLiBUaGUgbGlzdCBjb3VsZAo+ IGJlIG1vZGlmaWVkIGluLWJldHdlZW4uCgpJIHRoaW5rIHJlbGVhc2UgdGhlIGxvY2sgYW5kIHRo ZW4gcmVhY3F1aXJlIGl0IGlzIG9rLiBCZWNhdXNlIHdlIGhhdmUgaGVsZCB0aGUKcmVmY291bnQg b2Ygc29jayBhbmQgY2FsbGVkIHJvc2VfZGlzY29ubmVjdCgpIHRvIGNoYW5nZSB0aGUgc3RhdGUg b2Ygc29jayB3aXRoCnRoZSBwcm90ZWN0aW9uIG9mIHJvc2VfbGlzdF9sb2NrIHdoaWNoIGNvdWxk IHN5bmNocm9uaXplIHdpdGggcm9zZV9kZXN0cm95X3NvY2tldCgpLgoKSWYgdGhlIHNvY2sgaXMg cmVtb3ZlZCBmcm9tIHRoZSBsaXN0IGJ5IHJvc2VfZGVzdHJveV9zb2NrZXQoKSwgdGhlcmUgaXMK bm8gcm9zZS0+bmVpZ2hib3VyIGVxdWFscyB0byBuZWlnaCBhbmQgdGhlIHJvc2Vfa2lsbF9ieV9u ZWlnaCgpIHdpbGwgcmV0dXJuLgoKSWYgdGhlcmUgaXMgYSByb3NlLT5uZWlnaGJvdXIgZXF1YWxz IHRvIG5laWdoLCB3ZSBoZWxkIHRoZSByZWZjb3VudCBvZiBzb2NrCmFuZCBjYWxsZWQgdGhlIHJv c2VfZGlzY29ubmVjdCgpIHRvIGNoYW5nZSB0aGUgc3RhdGUgb2YgaXQgd2l0aCB0aGUgcHJvdGVj dGlvbgpvZiByb3NlX2xpc3RfbG9jay4gRXZlbiBpZiB0aGUgc29jayBjb3VsZCBiZSByZW1vdmVk IGZyb20gdGhlIHJvc2VfbGlzdCBieQpyb3NlX2Rlc3Ryb3lfc29ja2V0KCkgZHVyaW5nIHRoZSB0 aW1lIG9mIHVubG9ja2luZywgYnV0IHRoZSBzb2NrIHdpbGwgbm90IGJlIApkZWFsbG9jYXRlZCBi ZWNhdXNlIHdlIGhhdmUgaGVsZCB0aGUgcmVmY291bnQgb2Ygc29jay4gV2hlbiB3ZSByZWFjcXVp cmUgdGhlIApyb3NlX2xpc3RfbG9jaywgd2Ugb25seSBkbyBzb2NrX3B1dCgpIGluIG9yZGVyIHRv IGRlYWxsb2NhdGUgdGhlIHNvY2suCgpAQCAtMTY5LDkgKzE2OSwxNSBAQCB2b2lkIHJvc2Vfa2ls bF9ieV9uZWlnaChzdHJ1Y3Qgcm9zZV9uZWlnaCAqbmVpZ2gpCiAgICAgICAgICAgICAgICBzdHJ1 Y3Qgcm9zZV9zb2NrICpyb3NlID0gcm9zZV9zayhzKTsKIAogICAgICAgICAgICAgICAgaWYgKHJv c2UtPm5laWdoYm91ciA9PSBuZWlnaCkgeworICAgICAgICAgICAgICAgICAgICAgICBzb2NrX2hv bGQocyk7CiAgICAgICAgICAgICAgICAgICAgICAgIHJvc2VfZGlzY29ubmVjdChzLCBFTkVUVU5S RUFDSCwgUk9TRV9PVVRfT0ZfT1JERVIsIDApOwogICAgICAgICAgICAgICAgICAgICAgICByb3Nl LT5uZWlnaGJvdXItPnVzZS0tOworICAgICAgICAgICAgICAgICAgICAgICBzcGluX3VubG9ja19i aCgmcm9zZV9saXN0X2xvY2spOworICAgICAgICAgICAgICAgICAgICAgICBsb2NrX3NvY2socyk7 CiAgICAgICAgICAgICAgICAgICAgICAgIHJvc2UtPm5laWdoYm91ciA9IE5VTEw7CisgICAgICAg ICAgICAgICAgICAgICAgIHJlbGVhc2Vfc29jayhzKTsKKyAgICAgICAgICAgICAgICAgICAgICAg c3Bpbl9sb2NrX2JoKCZyb3NlX2xpc3RfbG9jayk7CisgICAgICAgICAgICAgICAgICAgICAgIHNv Y2tfcHV0KHMpOwogICAgICAgICAgICAgICAgfQogICAgICAgIH0KICAgICAgICBzcGluX3VubG9j a19iaCgmcm9zZV9saXN0X2xvY2spOwoKPiBJbnN0ZWFkIHlvdSBjb3VsZCBidWlsZCBhIGxvY2Fs IGxpc3QgY29udGFpbmluZyB0aGUgcmVsZXZhbnQgc29ja2V0cwo+ICh1bmRlciB0aGUgcm9zZV9s aXN0X2xvY2sgcHJvdGVjdGlvbiksIGFkZGl0aW9uYWxseSBhY3F1aXJpbmcgYQo+IHJlZmVyZW5j ZSB0byBlYWNoIG9mIHRoZW0KPiAKPiBUaGVuIHRyYXZlcnNlIHN1Y2ggbGlzdCBvdXRzaWRlIHRo ZSByb3NlX2xpc3RfbG9jaywgYWNxdWlyZSB0aGUgc29ja2V0Cj4gbG9jayBvbiBlYWNoIG9mIHRo ZW0sIGRvIHRoZSBuZWlnaCBjbGVhcmluZyBhbmQgcmVsZWFzZSB0aGUgcmVmZXJlbmNlLgoKSWYg d2UgYnVpbGQgYSBsb2NhbCBsaXN0IGNvbnRhaW4gdGhlIHJlbGV2YW50IHNvY2tldHMgYW5kIG9u bHkgYWNxdWlyZSBhIHJlZmVyZW5jZQp0byBlYWNoIG9mIHRoZW0gd2l0aCB0aGUgcHJvdGVjdGlv biBvZiByb3NlX2xpc3RfbG9jaywgdGhlIHNvY2tldCBjb3VsZCBiZSByZW1vdmVkCmJ5IHJvc2Vf ZGVzdHJveV9zb2NrZXQoKSBhZnRlciB3ZSByZWxlYXNlIHRoZSByb3NlX2xpc3RfbG9jay4gVGhl biBpZiB3ZSB0cmF2ZXJzZSAKc3VjaCBsaXN0IG91dHNpZGUgdGhlIHJvc2VfbGlzdF9sb2NrIHdl IGNvdWxkIG5vdCBmaW5kIHRoZSBzb2NrZXQsIGFzIGEgcmVzdWx0LAp0aGUgbmVpZ2ggY2xlYXJp bmcgYW5kIHRoZSByZWZjb3VudCByZWxlYXNpbmcgb3BlcmF0aW9ucyB3aWxsIG5vdCBiZSBleGVj dXRlZC4KCkJlc3QgcmVnYXJkcywKRHVvbWluZyBaaG91Cg==