Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Jun 2022 17:07:14 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Baolin Wang <baolin.wang@linux.alibaba.com>
Cc:     akpm@linux-foundation.org, rppt@linux.ibm.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/3] mm: Factor out the pagetable pages account
 into new helper function
Message-ID: <YrSPsqJHJTRcCmph@casper.infradead.org>
References: <cover.1655887440.git.baolin.wang@linux.alibaba.com>
 <e094c4a2e07ff66708f7a3a9f6b86eb694f33cf0.1655887440.git.baolin.wang@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e094c4a2e07ff66708f7a3a9f6b86eb694f33cf0.1655887440.git.baolin.wang@linux.alibaba.com>
Precedence: bulk

On Wed, Jun 22, 2022 at 04:58:52PM +0800, Baolin Wang wrote:
> +static inline void pgtable_set_and_inc(struct page *page)
> +{
> +	__SetPageTable(page);
> +	inc_lruvec_page_state(page, NR_PAGETABLE);
> +}

I don't like the names.  The accounting is also wrong for non-order-0
allocations.  It should be

	mod_lruvec_page_state(page, NR_PAGETABLE, compound_nr(page))

but it's probably better to change the API to pass in the number of
pages instead of recalculating it.

I can't think of a good name.  What's wrong with just adding

static inline bool pgtable_pud_page_ctor(struct page *page)

to go along with the pte and pmd variants?