Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp6012643iog; Thu, 23 Jun 2022 09:31:52 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tKGzKmTGxZ+E61J/ShAX/b98Qay/SFsapqfrmt6w/8YNjgoro6QYGl4bZE+USwbU6+PBCS X-Received: by 2002:a17:90b:164a:b0:1ec:b991:b69 with SMTP id il10-20020a17090b164a00b001ecb9910b69mr4826098pjb.173.1656001912258; Thu, 23 Jun 2022 09:31:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656001912; cv=none; d=google.com; s=arc-20160816; b=cJ8s13XWkR7zmMzz/T7m1ppNUsugqSLWshhvD6EFT3rOXSJsROU63PVoGwKXcNz3ck P9KrKbEWxbnUmLrgDoR4hJQfNHwrU98fvue+CtVXDxPTEcyG2e+kCdR4jWR0A8O+Unw2 tozw/LYN8EptdQT9uiRDIzWS3N00S+BB815XFRHZOfqtWm3fHrPfwQODEC59t7+jV0rb KJAHiBtZyBB3+7EoCdiGc3E0ao0SbUZe6h5vS9P/THim1+wuK8hMLq7nts9AoTb1YjWC 5o9JPbB4VOxF51BFtTKrPIoitwmhGHWeMrZXk13pid7K9RfhKeFJY6QWVE37QN9lxtr9 VrlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=kaKxILkdtC4aDj7nZJUbyZnqspnI1Ubc35AwgBp4zDc=; b=GEXzorBH7/i2j0BgzBluHMFH0j1LStwaI65VJ0XQnu2js73K1ZG1O17oYoyxJAnqWB Hviqb4Xk7Zn4E+/BEpXYRqPwvxWsW/msGCmGbubUOB+EDzZCzHDP4Wm3z8F1hw7qW9O1 AP4hl2a/uMyuhXHdRb2FCYrxJkBvsRQJfNnSITPNjfAItAhlqqFK1bS1GPTIvKCgXMu4 j2+F6H0v6UHxFyUlXn2q5ZjyW0JUkLUgYf6+XtNu02czJa60WTChFMkQNXksHR6YMqDC kwrUyOaTlR9zS7bF5nVMj5ezdILGJbISEWAwXH2VatDZyKYPXj65P47BybCliBx0sQTW qrIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rx4h6HYI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d5-20020a170902aa8500b0016a52344aa3si4944668plr.507.2022.06.23.09.31.40; Thu, 23 Jun 2022 09:31:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rx4h6HYI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231986AbiFWQWX (ORCPT + 99 others); Thu, 23 Jun 2022 12:22:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230338AbiFWQWV (ORCPT ); Thu, 23 Jun 2022 12:22:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68BD03A180; Thu, 23 Jun 2022 09:22:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1D2D8B8247D; Thu, 23 Jun 2022 16:22:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CAF6C3411B; Thu, 23 Jun 2022 16:22:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656001337; bh=YsoOAuqQs9dQOMHE2o4hFP7F/IQj/Aa/1OiV4zxOfJ8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rx4h6HYI0upiTLUuiAH06O5d9LWGE4od0bd8WR+5RsXZUqdZxy49KzUSjzcbgH8Mj MjElvwJO2Y+QwwnM947MOOVkfdyac5rpOROJAAaT9Gt3g1lZcQhiylgfiOeEakUn07 yUhUOeJNuSttz2BZC8NHc5W4TAVVI+nTTMYHFLcv4E2iOwHDbCIJX3kxpx7qlJABm8 +OUqgSAdE59V8zHW/HO1360g25aiRJk+f/fUho4v+fER1VrAQNTyl5mUWLyxkxCXLa s0gwXu8nq+hqNuwCIekgWs3SX/HBVuntfdy/cqo25InD2DgJ7tZdEPePgzkVyibJQf IQxXp1zdJ3MfQ== Date: Thu, 23 Jun 2022 09:22:08 -0700 From: Jakub Kicinski To: Jiang Jian Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, idosch@nvidia.com, petrm@nvidia.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mlxsw: drop unexpected word 'for' in comments Message-ID: <20220623092208.1abbd9dc@kernel.org> In-Reply-To: <20220623104601.48149-1-jiangjian@cdjrlc.com> References: <20220623104601.48149-1-jiangjian@cdjrlc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 Jun 2022 18:46:01 +0800 Jiang Jian wrote: > file - drivers/net/ethernet/mellanox/mlxsw/spectrum2_kvdl.c > line - 18 > > * ids for for this purpose in partition definition. > changed to: > > * ids for this purpose in partition definition. Please stop putting the change into the description. I think I already complained about this. This is exactly the same information as is in the patch itself. And as other people have pointed out - please say that the word is repeated not "unexpected". IDK why you made those changes because your patches on Wednesday where better: [PATCH] bnxt: Fix typo in comments Remove the repeated word 'and' from comments Signed-off-by: Jiang Jian https://lore.kernel.org/r/20220622144526.20659-1-jiangjian@cdjrlc.com/ I'm dropping these patches from you, please redo them: https://patchwork.kernel.org/project/netdevbpf/patch/20220623104919.49600-1-jiangjian@cdjrlc.com/ https://patchwork.kernel.org/project/netdevbpf/patch/20220622171711.6969-1-jiangjian@cdjrlc.com/ https://patchwork.kernel.org/project/netdevbpf/patch/20220623104601.48149-1-jiangjian@cdjrlc.com/