Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp6030508iog; Thu, 23 Jun 2022 09:55:11 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vXtmqOaQhZ1DOZ9EH2XCEEgVkmIqEkajmgFouUKSv4sBnXI8Flv6ruAeMWTvRcZFugQMTk X-Received: by 2002:a17:906:728f:b0:711:f680:3c83 with SMTP id b15-20020a170906728f00b00711f6803c83mr8893680ejl.122.1656003311495; Thu, 23 Jun 2022 09:55:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656003311; cv=none; d=google.com; s=arc-20160816; b=YPpOfSGTzmhgLV/ktskw0CxZDj8gstmquHNfMJ3PEfbUfxHzysgPKolyvv0fGMEzPx t08Q2sP2cvbhIY26Ev117a7FKo5Haj2ffSm7NwPCShnCe9mJiJeSmpXf3EE2Th6SLD8e 57iqRtEBU+IlK0+MEMaC1qjmRse3FeqWrz9iPuwA1HRfFa/eT+slAcfpxQuBonFJK/fu 7mF5ahchadO0wzMWU4PW7aQasfcqHbwUeaj0HIorinU5VBTn/BdpNNToYKbmur1gYo/I 9epKlhBkLN/vG8sNst0cx0/53o73838byrAxttEiure57bvDm4zjd4iCF8/9odMzCnu5 Y4dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=M/dYqgDi6L6MIFzlwbScPWA7/LwQ9p3aYQZWrYiM4e0=; b=NbWLMPdyCc2Xe/WPDCGOktxWSve0yGk9CHdv79jDhIyRFn/3Dz39M+kkqVa9q0A+mB brs8VHZhOUcqZRoW1wsfy4HVpCtp62/IpRM0uw6rq+A25MkWHXqRMFH9wgZjO7bptfD9 LXHoGtMVKYS3YXUNZ19XAc5hfPcp0Nz8GMly/w6ZNrgJCHGpL5PrrKM8FJhJQ+BFlwdV pPFZzwNSVzVsv2ZdmS4de65h+mJ9CqX7dShcCl1I5a6W5gYjCSLoU19ugKsKSySRiPQy PBvswku4KGkTRbSkdehfMJdzQTHCqFy0H1jvEqw7wDxr4qnAal7QeUnXsOgdkgzYhQqb wgsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="XHJYgpf/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sd23-20020a1709076e1700b007262b3cd387si1185276ejc.421.2022.06.23.09.54.46; Thu, 23 Jun 2022 09:55:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="XHJYgpf/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232111AbiFWQZW (ORCPT + 99 others); Thu, 23 Jun 2022 12:25:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232204AbiFWQZS (ORCPT ); Thu, 23 Jun 2022 12:25:18 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EC0C46CBF; Thu, 23 Jun 2022 09:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656001515; x=1687537515; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YBcyDm3+c63sXYAdzt+59szqAftpblBOv3+86OdD4RA=; b=XHJYgpf/yfI3tJuogK4n2XuPtBS8UROwjEN/04HUUrO4L6pR6v9R4wDR GQmnTrDdl/9Oo/B7UpLrQLFYuqfXKAbBlDk1ys5I6dwsgollfsZg/MXRG RYn7q3JYnWzNrnOsinRFE8ztMiWuU3WtNRbOGEn+p8Km4w5Ijt+aFuOnB ooKeMUpuG5IjrPYGTqUq9asKZb8UEzl3SgLWpbsYu7OqHW7yxL4hwAT24 qdoV7c0X5cljqVCW5bj4DGQTmstccCL29qX4D05FVh5GLXudbTpZllDnL ZtY5fNA3bIsh+rFvpJjh7lmydoMFxbrJbg7GVnJEfQSb6eOnv9zTFMsE2 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10386"; a="280814532" X-IronPort-AV: E=Sophos;i="5.92,216,1650956400"; d="scan'208";a="280814532" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 09:25:14 -0700 X-IronPort-AV: E=Sophos;i="5.92,216,1650956400"; d="scan'208";a="691094949" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 09:25:11 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1o4Pdj-000tCq-Le; Thu, 23 Jun 2022 19:25:07 +0300 Date: Thu, 23 Jun 2022 19:25:07 +0300 From: Andy Shevchenko To: Lino Sanfilippo Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, vz@mleia.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, lukas@wunner.de, p.rosenberger@kunbus.com, Lino Sanfilippo Subject: Re: [PATCH 3/8] serial: core: move sanitizing of RS485 delays into own function Message-ID: References: <20220622154659.8710-1-LinoSanfilippo@gmx.de> <20220622154659.8710-4-LinoSanfilippo@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220622154659.8710-4-LinoSanfilippo@gmx.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 22, 2022 at 05:46:54PM +0200, Lino Sanfilippo wrote: > From: Lino Sanfilippo > > Move the sanitizing of RS485 delays out of uart_sanitize_serial_rs485() > into the new function uart_sanitize_serial_rs485_delays(). ... > + /* pick sane settings if the user hasn't */ Be consistent with the style (capitalization) of one-line comments. It might require another patch to make it all consistent. (Below is left for a context) > /* Return clean padding area to userspace */ -- With Best Regards, Andy Shevchenko