Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp6045395iog; Thu, 23 Jun 2022 10:10:51 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vg+JoxB/DPjSxoS2uX6ifeJ5yoX8AhRqVDLIGc8FqOs7YNMQYy9SY47A7l/p0ENk1xKtKJ X-Received: by 2002:a17:907:9491:b0:722:f2a1:efb6 with SMTP id dm17-20020a170907949100b00722f2a1efb6mr8693999ejc.284.1656004251607; Thu, 23 Jun 2022 10:10:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656004251; cv=none; d=google.com; s=arc-20160816; b=NFeS0F2YDrkvolCzZRiu3yERbMulf49CKhuHF24HegmI65SHRbMlC+0jxouy0b4nnc oP/zoN23RC+OAigQ0KPkwv3CIb0CaaFTTin7eZN2Vaz0iKfBX6vQwR37H/uvJx0jXnNn ITwp2zZMm4w4XcizRpCAvHbOYpDLJen/zx8F49bSdwaumNyCtdOGqy3mBcdvKCCBvO3w iSAnBJYHpkxDcotBSsq+qfYgdMTx9pbQzkZoNdyI/cf80ZtIi3ECGrs/pGML/MJSYP62 CG+qCX68cqFoPi4GgeNuthVGEHOFzX5NGkGx1T6wCaCYNBHLvIS8bC/zai5e19MSAl3Q n7Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=scoWslx6Q/ZLen3h3DFysAz0MN8Fj7pUmNKG1L6FAcw=; b=qTZwhvcWPUmNu1DrBZXvc8IXLG5zAH16Ln8HwNKKCH4FV6vTRCuSXQJDaQtgCk+PIC 0/DSwPq3LCbWnFyXR/CUuCJHhZHlZPNxcwvTntUHezno0wY6wMgEMPRVAPZ7gvyddYGW 8cxrYf0Vb39aPX+RYeIPTflus97bGXLuN46T3wYS1cACdh3KaRCJ1hd5fRhYW5MDrD7R Y/m8kXpqxdOpQO1VTxHkg5E6jscvWCdWqrprf2RhOudH/OkwnQUmyOEn3Vr14lDxmsPh iYpN9KuS3i1F9cDF5UrEPskqvrbeo3SXS9f+ZTH/BvTpFjfXmXPjOO57bGVdJZKh/AJL 8V+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CkwirAD9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gn17-20020a1709070d1100b007262a185b63si2189124ejc.613.2022.06.23.10.10.25; Thu, 23 Jun 2022 10:10:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CkwirAD9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232848AbiFWQsi (ORCPT + 99 others); Thu, 23 Jun 2022 12:48:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232478AbiFWQrV (ORCPT ); Thu, 23 Jun 2022 12:47:21 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24E6349C82; Thu, 23 Jun 2022 09:47:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8E896CE25DE; Thu, 23 Jun 2022 16:47:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55E31C341DA; Thu, 23 Jun 2022 16:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656002836; bh=cmmyeAgpxGhy8P8hXLYAyi9xEgnudIeUVJlvOi7PvOg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CkwirAD9Xb3lsXDQn6qVH67vvmY0i6qWZFMcli6biUOzIqvtVPhpkSBlVMFA7hPV/ bkAWxkuMqhvWcXLCsZNVBoBtfUFArKbu9u6wkCADCtUMc38FLh4L8vNTuM6G98BiL2 xHo89Y6noehl4vLMmKaFOgQDA9+8dISFmdENbFBQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Fabio Estevam , Theodore Tso , "Jason A. Donenfeld" Subject: [PATCH 4.9 007/264] random: move random_min_urandom_seed into CONFIG_SYSCTL ifdef block Date: Thu, 23 Jun 2022 18:40:00 +0200 Message-Id: <20220623164344.267645441@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220623164344.053938039@linuxfoundation.org> References: <20220623164344.053938039@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fabio Estevam commit db61ffe3a71c697aaa91c42c862a5f7557a0e562 upstream. Building arm allnodefconfig causes the following build warning: drivers/char/random.c:318:12: warning: 'random_min_urandom_seed' defined but not used [-Wunused-variable] Fix the warning by moving 'random_min_urandom_seed' declaration inside the CONFIG_SYSCTL ifdef block, where it is actually used. While at it, remove the comment prior to the variable declaration. Signed-off-by: Fabio Estevam Signed-off-by: Theodore Ts'o Signed-off-by: Jason A. Donenfeld Signed-off-by: Greg Kroah-Hartman --- drivers/char/random.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -314,11 +314,6 @@ static int random_read_wakeup_bits = 64; static int random_write_wakeup_bits = 28 * OUTPUT_POOL_WORDS; /* - * Variable is currently unused by left for user space compatibility. - */ -static int random_min_urandom_seed = 60; - -/* * Originally, we used a primitive polynomial of degree .poolwords * over GF(2). The taps for various sizes are defined below. They * were chosen to be evenly spaced except for the last tap, which is 1 @@ -1957,6 +1952,7 @@ SYSCALL_DEFINE3(getrandom, char __user * static int min_read_thresh = 8, min_write_thresh; static int max_read_thresh = OUTPUT_POOL_WORDS * 32; static int max_write_thresh = INPUT_POOL_WORDS * 32; +static int random_min_urandom_seed = 60; static char sysctl_bootid[16]; /*