Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <09153aee-f05e-22ae-dcf5-0fbfb3b9823c@deltatee.com>
Date:   Thu, 23 Jun 2022 11:18:42 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Content-Language: en-CA
To:     Song Liu <song@kernel.org>
Cc:     open list <linux-kernel@vger.kernel.org>,
        linux-raid <linux-raid@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
References: <20220623165552.38645-1-logang@deltatee.com>
 <CAPhsuW50vG=M6JhBEe3qwef10GQt84cg9p_ji5tqyRnMA1-xRQ@mail.gmail.com>
From:   Logan Gunthorpe <logang@deltatee.com>
In-Reply-To: <CAPhsuW50vG=M6JhBEe3qwef10GQt84cg9p_ji5tqyRnMA1-xRQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] md/raid5: Fix divide type in raid5_make_request()
Precedence: bulk


On 2022-06-23 11:15, Song Liu wrote:
> On Thu, Jun 23, 2022 at 9:56 AM Logan Gunthorpe <logang@deltatee.com> wrote:
>>
>> 0day reports a build failure on the hexagon architecture:
>>
>>   ld.lld: error: undefined symbol: __hexagon_udivdi3
>>      referenced by raid5.c
>>         md/raid5.o:(raid5_make_request) in archive drivers/built-in.a
>>      referenced by raid5.c
>>         md/raid5.o:(raid5_make_request) in archive drivers/built-in.a
>>      did you mean: __hexagon_udivsi3
>>         defined in: arch/hexagon/built-in.a(lib/udivsi3.o)
>>
>> This is caused by using DIV_ROUND_UP on a sector_t type.
>>
>> The actual value is known to be less than 256 so a wide 64bit divide
>> here is not desirable. Thus cast the argument to an int to ensure it
>> uses a 32bit divide.
> 
> I force pushed an update that uses DIV_ROUND_UP_SECTOR_T instead.
> I guess that should also work?

Ah, yes, that'll also fix the bug. I chose to cast to minimize the
performance impact of an unnecessarily wide divide. But I don't have any
strong basis to suggest the performance will be worse with the wider
division. So fix it whichever way you think is best.

Logan