Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp6142824iog; Thu, 23 Jun 2022 12:14:02 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vvm8+gW/mrX58NVNa7EB+6Q1yueJlA4SiHiat21kXeoTIafe/cOC+XAIVcdfKbMtN68jkD X-Received: by 2002:a17:902:d4c4:b0:16a:2d0a:b609 with SMTP id o4-20020a170902d4c400b0016a2d0ab609mr18579733plg.5.1656011642011; Thu, 23 Jun 2022 12:14:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656011642; cv=none; d=google.com; s=arc-20160816; b=XOtn29caZcclfeXwEEOxiOGEiWsm8vy/R5rU7zWf1HvGBjiY3eGbJARwbYYAaiZ6xN D6vLbZq0cpEeZeHpE3RykHEUEbfdI2AjjfOPNbKzNUGz6qSRmTuG7mzKR9lryQbdAbcy VrDi1svOx/h6UdCSOv3z4CEbNEN/gC91c1GUoZjVX24/KyVINY7JfgmzBop74vsvJAIW fTpsZ8yqOaOnKE6RtUXWI4FsUZ8wC4cZA+IZgLJUt06gfPZNE7aJAZ8bKrVq4yETHMk6 SZIlS8KqLxX8tINfQShW5wd1sF7pgVMi4dOTiqtzKy/56jd22m6uCudoZhdI/0svA3gb rdNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CN4cxgk/OS5AJCw4s2I1d/yEJioRbGKlvHyak5wklcs=; b=Lq1kysFWEjnsH8tKjzlXWMBpBXDxh//zChFBEno4C0sobrBSImRKwsoxo/ykFVLw1h FVMkzAVCFdyqeUb3ZSlKFbPZfh/uc9XapnGp1Iix2a0XTyiqtvmRx8I8pVwxwh0quSAs ur5LgsZ92gWP8ItYAE4fr9MpGRCMP+VxJ514aMqE68idz2hFaYlPH1oxZxNUbFVjEPeh q2kZth6hHuqeNsdMcXQ7/Qnf62/7TYr38FZUieQF63CVDhd4ha3hVX6yYID8pUQ3NE7C /Xk+1dP8hUkPnhKCwJo9FvGiQOPr8Gt8aUY+klyZRTocQwtnoK491p/d6ifpsfSqWxvw rLJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Wb0ig/Bc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w69-20020a638248000000b0040d510ee269si2789128pgd.105.2022.06.23.12.13.50; Thu, 23 Jun 2022 12:14:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Wb0ig/Bc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235957AbiFWSKp (ORCPT + 99 others); Thu, 23 Jun 2022 14:10:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236732AbiFWSIY (ORCPT ); Thu, 23 Jun 2022 14:08:24 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F9FFBB30B; Thu, 23 Jun 2022 10:19:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E0F59B824BE; Thu, 23 Jun 2022 17:19:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D390C3411B; Thu, 23 Jun 2022 17:19:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656004782; bh=oC7uE7Rw1Ghn9TivFSc7Wmcc7UL8WyT0zdSQsUCYZZo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wb0ig/BcK1bxulngqFxSLfWxxsUNX7QGR9ynXOq7PWEDAh+TWyBQXWmjlFt8LMFxM lWETJgTWvJboEBiN2rgn8Fu1OE9bkpUVmmwA2lHonGj9M4u60Fq9KIl9nqE0i+UOZZ LXEtv/NHsx81K9PXARs1hPaGwkd7Drg2HB7fYDUA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thomas Gleixner , Arnd Bergmann , Max Filippov , "Jason A. Donenfeld" Subject: [PATCH 4.19 148/234] xtensa: use fallback for random_get_entropy() instead of zero Date: Thu, 23 Jun 2022 18:43:35 +0200 Message-Id: <20220623164347.243600867@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220623164343.042598055@linuxfoundation.org> References: <20220623164343.042598055@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Jason A. Donenfeld" commit e10e2f58030c5c211d49042a8c2a1b93d40b2ffb upstream. In the event that random_get_entropy() can't access a cycle counter or similar, falling back to returning 0 is really not the best we can do. Instead, at least calling random_get_entropy_fallback() would be preferable, because that always needs to return _something_, even falling back to jiffies eventually. It's not as though random_get_entropy_fallback() is super high precision or guaranteed to be entropic, but basically anything that's not zero all the time is better than returning zero all the time. This is accomplished by just including the asm-generic code like on other architectures, which means we can get rid of the empty stub function here. Cc: Thomas Gleixner Cc: Arnd Bergmann Acked-by: Max Filippov Signed-off-by: Jason A. Donenfeld Signed-off-by: Greg Kroah-Hartman --- arch/xtensa/include/asm/timex.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/arch/xtensa/include/asm/timex.h +++ b/arch/xtensa/include/asm/timex.h @@ -30,10 +30,6 @@ extern unsigned long ccount_freq; -typedef unsigned long long cycles_t; - -#define get_cycles() (0) - void local_timer_setup(unsigned cpu); /* @@ -69,4 +65,6 @@ static inline void set_linux_timer (unsi WSR_CCOMPARE(LINUX_TIMER, ccompare); } +#include + #endif /* _XTENSA_TIMEX_H */