Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Jun 2022 18:03:03 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     David Hildenbrand <david@redhat.com>
Cc:     Liam Howlett <liam.howlett@oracle.com>,
        "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "damon @ lists . linux . dev" <damon@lists.linux.dev>,
        SeongJae Park <sj@kernel.org>
Subject: Re: [PATCH v10 09/69] mm: add VMA iterator
Message-ID: <YrScxyQ5RRYYZFrj@casper.infradead.org>
References: <20220621204632.3370049-1-Liam.Howlett@oracle.com>
 <20220621204632.3370049-10-Liam.Howlett@oracle.com>
 <20192b57-30de-1426-6694-238e018104eb@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20192b57-30de-1426-6694-238e018104eb@redhat.com>
Precedence: bulk

On Tue, Jun 21, 2022 at 11:10:09PM +0200, David Hildenbrand wrote:
> > +#define VMA_ITERATOR(name, mm, addr) 					\
> > +	struct vma_iterator name = {					\
> > +		.mas = {						\
> > +			.tree = &mm->mm_mt,				\
> > +			.index = addr,					\
> > +			.node = MAS_START,				\
> > +		},							\
> > +	}
> > +
> 
> No __* and () macro magic?
> 
> I'd have expected at least
> 
> tree = &(__mm)->mm_mt,
> .index = (__addr),
> 
> ;)

Fair, fair.  Just testing that change now.  I always forget to do those
things until they bite me.

> Reviewed-by: David Hildenbrand <david@redhat.com>

Appreciate the review!

diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index acbd8d03e01e..8bcbffefdc02 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -686,11 +686,11 @@ struct vma_iterator {
 	struct ma_state mas;
 };
 
-#define VMA_ITERATOR(name, mm, addr) 					\
+#define VMA_ITERATOR(name, _mm, _addr)	 				\
 	struct vma_iterator name = {					\
 		.mas = {						\
-			.tree = &mm->mm_mt,				\
-			.index = addr,					\
+			.tree = &(_mm)->mm_mt,				\
+			.index = (_addr),				\
 			.node = MAS_START,				\
 		},							\
 	}