Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <10ee5d87-47bd-d423-75a5-611fefe7a656@ti.com>
Date:   Thu, 23 Jun 2022 13:21:28 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] arm64: dts: ti: k3-am62-main: Enable crypto accelerator
Content-Language: en-US
To:     Jayesh Choudhary <j-choudhary@ti.com>, <devicetree@vger.kernel.org>
CC:     <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20220623095955.161307-1-j-choudhary@ti.com>
From:   Andrew Davis <afd@ti.com>
In-Reply-To: <20220623095955.161307-1-j-choudhary@ti.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/23/22 4:59 AM, Jayesh Choudhary wrote:
> Add the node for sa3ul crypto accelerator.
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> ---
> On local testing, crypto self-tests and tcrypt tests were passing
> for SHA256, SHA512, ECB-AES and CBC-AES algorithms.
> RNG node has not been added due to the indirect access of the
> hardware random number generator from OP-TEE.
> 
>   arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index df3b9883e887..30bd22ff2fc9 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -165,6 +165,19 @@
>   		};
>   	};
>   
> +	crypto: crypto@40900000 {
> +		compatible = "ti,am62-sa3ul";
> +		reg = <0x00 0x40900000 0x00 0x1200>;
> +		power-domains = <&k3_pds 70 TI_SCI_PD_EXCLUSIVE>;


Change to TI_SCI_PD_SHARED as OP-TEE uses this too, otherwise looks good,

Acked-by: Andrew Davis <afd@ti.com>


> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
> +
> +		dmas = <&main_pktdma 0xf501 0>, <&main_pktdma 0x7506 0>,
> +				<&main_pktdma 0x7507 0>;
> +		dma-names = "tx", "rx1", "rx2";
> +	};
> +
>   	main_pmx0: pinctrl@f4000 {
>   		compatible = "pinctrl-single";
>   		reg = <0x00 0xf4000 0x00 0x2ac>;