Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753009AbXEYQTA (ORCPT ); Fri, 25 May 2007 12:19:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763453AbXEYQSo (ORCPT ); Fri, 25 May 2007 12:18:44 -0400 Received: from mx1.redhat.com ([66.187.233.31]:37109 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763432AbXEYQSn (ORCPT ); Fri, 25 May 2007 12:18:43 -0400 Date: Fri, 25 May 2007 12:18:37 -0400 From: Dave Jones To: Andi Kleen Cc: Chuck Ebbert , linux-kernel Subject: Re: Multiple free during oprofile unload Message-ID: <20070525161837.GA26105@redhat.com> Mail-Followup-To: Dave Jones , Andi Kleen , Chuck Ebbert , linux-kernel References: <4656FA04.5000403@redhat.com> <200705251742.35692.ak@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705251742.35692.ak@novell.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 919 Lines: 27 On Fri, May 25, 2007 at 05:42:35PM +0200, Andi Kleen wrote: > > > for_each_possible_cpu(i) { > > kfree(cpu_msrs[i].counters); > > cpu_msrs[i].counters = NULL; > > kfree(cpu_msrs[i].controls); > > cpu_msrs[i].controls = NULL; > > } > > > > Seems the patch makes all the cpu_msrs[] point to the same area? > > Yes I forgot to fix the free path. Will submit a patch. > > BTW that is why I'm not so happy with you being so trigger happy with stable > submissions. So what, the alternative is leave oprofile busted in 2.6.21.x even longer? Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/