Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp6378220iog; Thu, 23 Jun 2022 18:16:10 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tGcbOeYCYe019kQRYw3UmXRrFEtnPKTlnwI5tvyKgNtNunp49RgvceAl0P6aLkSrRlqyex X-Received: by 2002:a17:902:e747:b0:16a:58f2:1d1e with SMTP id p7-20020a170902e74700b0016a58f21d1emr5724320plf.17.1656033370041; Thu, 23 Jun 2022 18:16:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656033370; cv=none; d=google.com; s=arc-20160816; b=U8GWGoTQX/zAbl9Hp6wCQXQR9uioeGhGvmo61tcVJ98S83fUe/qzpUFx0rHMaiGGfx esj/MoUNH5zXJ8gDYFxfA/VUVWah2NyGm4wS/BSaEw+9OIJPXkyCr3PSyRdy9SUfNtFG U+xff6TIb2erbSt7stiIvHx/gXNuG+iAlVOikfAmgQYolcOxECt60BUy2ASnEKgLcPhq 5nR/fBWHstFPAB3BUZ3hABBFvqxZ59m7o1w6O6FHMpjgHr1s35D6OWuW8EkVoHrZh+bH /Nj9AU4VAzh5jOmQx1WYeCREqIGcv9CJkUdMGS1yIkoVQsrwOLxsPfUemDIn8/I0p17q bunw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=fN6C7UqqsMXxkb4/lsx5bPPapQNz2B21wd7UPLqNg9M=; b=kjF72SDaCXcjdcIb1aCxl+vh0EdYgQyJfOytBJsNbXi3RxdxsxpLON2HZUAa1HVrCS SW3NTv1NFNZswaQAWYGNosR8mM6EdCbP3+sB6GVDLXvmdTucYg6zvlcbuRpx/gBd6Wgh DUfdGBFRYj7nBgHScy0woiVLFRc6INBCtt2v2gf1AWjxRJbH0hLvb6WSe2EJWRHRItR/ /Y3aY8Dfg3r7EioFxiuDQ5w+TMsphk64ZgO6fND80M650G3r1mNpK9crlY8QuTK8gynd CL02s7OPX0yW3zg3w5qBM7m3ey9bdDYgOR91ZJjEn9XfbTdWcmz4MzFSdO7Qrp62y3EH clnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n11-20020a63f80b000000b003c1725602b4si796237pgh.627.2022.06.23.18.15.57; Thu, 23 Jun 2022 18:16:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230312AbiFXAum (ORCPT + 99 others); Thu, 23 Jun 2022 20:50:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230264AbiFXAul (ORCPT ); Thu, 23 Jun 2022 20:50:41 -0400 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D03623E5FE for ; Thu, 23 Jun 2022 17:50:40 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VHETPnp_1656031837; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0VHETPnp_1656031837) by smtp.aliyun-inc.com; Fri, 24 Jun 2022 08:50:38 +0800 From: Yang Li To: airlied@linux.ie Cc: daniel@ffwll.ch, orsonzhai@gmail.com, baolin.wang7@gmail.com, zhang.lyra@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH -next] drm: Remove unnecessary print function dev_err() Date: Fri, 24 Jun 2022 08:50:36 +0800 Message-Id: <20220624005036.37268-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./drivers/gpu/drm/sprd/sprd_dpu.c:808:2-9: line 808 is redundant because platform_get_irq() already prints an error Signed-off-by: Yang Li --- drivers/gpu/drm/sprd/sprd_dpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/sprd/sprd_dpu.c b/drivers/gpu/drm/sprd/sprd_dpu.c index 3664089b6983..de4848dc0d22 100644 --- a/drivers/gpu/drm/sprd/sprd_dpu.c +++ b/drivers/gpu/drm/sprd/sprd_dpu.c @@ -804,10 +804,8 @@ static int sprd_dpu_context_init(struct sprd_dpu *dpu, } ctx->irq = platform_get_irq(pdev, 0); - if (ctx->irq < 0) { - dev_err(dev, "failed to get dpu irq\n"); + if (ctx->irq < 0) return ctx->irq; - } /* disable and clear interrupts before register dpu IRQ. */ writel(0x00, ctx->base + REG_DPU_INT_EN); -- 2.20.1.7.g153144c