Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cf645f1f-9368-3466-6e6d-09ea48a9c3a0@huawei.com>
Date:   Fri, 24 Jun 2022 09:15:49 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [EXT] Re: [PATCH -next] NTB: EPF: Fix Kconfig dependency
To:     Frank Li <frank.li@nxp.com>, Bjorn Helgaas <helgaas@kernel.org>
CC:     "kishon@ti.com" <kishon@ti.com>,
        "lpieralisi@kernel.org" <lpieralisi@kernel.org>,
        "kw@linux.com" <kw@linux.com>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "jdmason@kudzu.us" <jdmason@kudzu.us>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <PAXPR04MB91861EE0E20E9EC71F4C494288B59@PAXPR04MB9186.eurprd04.prod.outlook.com>
 <20220623155524.GA1452766@bhelgaas>
 <PAXPR04MB91865EE1D156F47DB8D9EE4B88B59@PAXPR04MB9186.eurprd04.prod.outlook.com>
From:   Ren Zhijie <renzhijie2@huawei.com>
In-Reply-To: <PAXPR04MB91865EE1D156F47DB8D9EE4B88B59@PAXPR04MB9186.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

在 2022/6/23 23:58, Frank Li 写道:
>
>> -----Original Message-----
>> From: Bjorn Helgaas <helgaas@kernel.org>
>> Sent: Thursday, June 23, 2022 10:55 AM
>> To: Frank Li <frank.li@nxp.com>
>> Cc: Ren Zhijie <renzhijie2@huawei.com>; kishon@ti.com;
>> lpieralisi@kernel.org; kw@linux.com; bhelgaas@google.com;
>> jdmason@kudzu.us; linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org
>> Subject: [EXT] Re: [PATCH -next] NTB: EPF: Fix Kconfig dependency
>>
>> Caution: EXT Email
>>
>> On Thu, Jun 23, 2022 at 03:36:38PM +0000, Frank Li wrote:
>>>> -----Original Message-----
>>>> From: Ren Zhijie <renzhijie2@huawei.com>
>>>> Sent: Thursday, June 23, 2022 3:46 AM
>>>> To: kishon@ti.com; lpieralisi@kernel.org; kw@linux.com;
>>>> bhelgaas@google.com; jdmason@kudzu.us; Frank Li <frank.li@nxp.com>
>>>> Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; Ren Zhijie
>>>> <renzhijie2@huawei.com>
>>>> Subject: [PATCH -next] NTB: EPF: Fix Kconfig dependency
>> @Ren, please use a typical subject line for the file, e.g.,
>>
>>    PCI: endpoint: ...
>>
>>>> If CONFIG_NTB is not set and CONFIG_PCI_EPF_VNTB is y.
>>>>
>>>> make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed,
>> like
>>>> this:
>>>>
>>>> drivers/pci/endpoint/functions/pci-epf-vntb.o: In function
>>>> `epf_ntb_cmd_handler':
>>>> pci-epf-vntb.c:(.text+0x95e): undefined reference to `ntb_db_event'
>>>> pci-epf-vntb.c:(.text+0xa1f): undefined reference to `ntb_link_event'
>>>> pci-epf-vntb.c:(.text+0xa42): undefined reference to `ntb_link_event'
>>>> drivers/pci/endpoint/functions/pci-epf-vntb.o: In function
>> `pci_vntb_probe':
>>>> pci-epf-vntb.c:(.text+0x1250): undefined reference to
>> `ntb_register_device'
>>>> The functions ntb_*() are defined in drivers/ntb/core.c, which need
>>>> CONFIG_NTB setting y to be build-in.
>>>> To fix this build error, add depends on NTB.
>>>>
>>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>>> Fixes: ff32fac00d97("NTB: EPF: support NTB transfer between PCI RC and
>> EP
>>>> connection")
>>>> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
>>>> ---
>>> [Frank Li] Acked
>> @Frank: if you use the conventional style, e.g.,
>> "Acked-by: Frank Li <frank.li@nxp.com>", tooling like b4 will
>> automatically pick it up.  Just saying "Acked" is likely to get missed
>> or ignored.
> Thanks.
> Acked-by: Frank Li <frank.li@nxp.com>

sure, will fix it in patch v2.


Thanks,

Ren Zhijie

>>>>   drivers/pci/endpoint/functions/Kconfig | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/pci/endpoint/functions/Kconfig
>>>> b/drivers/pci/endpoint/functions/Kconfig
>>>> index 362555b024e8..9beee4f0f4ee 100644
>>>> --- a/drivers/pci/endpoint/functions/Kconfig
>>>> +++ b/drivers/pci/endpoint/functions/Kconfig
>>>> @@ -29,6 +29,7 @@ config PCI_EPF_NTB
>>>>   config PCI_EPF_VNTB
>>>>           tristate "PCI Endpoint NTB driver"
>>>>           depends on PCI_ENDPOINT
>>>> +        depends on NTB
>>>>           select CONFIGFS_FS
>>>>           help
>>>>             Select this configuration option to enable the Non-Transparent
>>>> --
>>>> 2.17.1
> .