Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Alan Stern <stern@rowland.harvard.edu>
CC:     Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Roger Quadros <roger.quadros@nokia.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Wesley Cheng <quic_wcheng@quicinc.com>,
        "Eric W . Biederman" <ebiederm@xmission.com>,
        Matthew Wilcox <willy@infradead.org>,
        Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
        Cai Huoqing <cai.huoqing@linux.dev>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        BMC-SW <BMC-SW@aspeedtech.com>
Subject: RE: [PATCH RESEND] usb: gadget: f_mass_storage: Make CD-ROM emulation
 works with Windows OS
Thread-Topic: [PATCH RESEND] usb: gadget: f_mass_storage: Make CD-ROM
 emulation works with Windows OS
Thread-Index: AQHYhq3rzhxyDFo2ik6AmHo1KwAqPK1dEz8AgAC9vcA=
Date:   Fri, 24 Jun 2022 02:11:09 +0000
Message-ID: <HK0PR06MB3202F448E528F2047E1C3B1080B49@HK0PR06MB3202.apcprd06.prod.outlook.com>
References: <20220623030405.1922980-1-neal_liu@aspeedtech.com>
 <YrR9PrjBXGV5O6bq@rowland.harvard.edu>
In-Reply-To: <YrR9PrjBXGV5O6bq@rowland.harvard.edu>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?E3lTgepvzf17iDinqXSTefKLLQi1PrhgGE1Id+WbZrLtXEXlYm9+10p2mPXa?=
 =?us-ascii?Q?ECW5+MiJfW1cKIoode15F5WahqnnbRI1tcblLgHXjnGAR0RRwqy8BxLcqh94?=
 =?us-ascii?Q?xoUKX2vVWGKsrPT60nS5NP0t/cPkg3TgbC/KsChPTu1/BH+pnkPS8AH2CB8u?=
 =?us-ascii?Q?xX40B/Ybrg++aPdVl+vi1D/AQEWYoQbn2LDNRl5KOXYHdgzP3VL0UQnFhxCh?=
 =?us-ascii?Q?m6s7piy4GBnn8LM9AVcbcA/ccRjbbmnKKKZ7hCRHev0nSPXmbWMtTMuWkBgm?=
 =?us-ascii?Q?Q/WlCZHThdvovets9PwaEG4ooyJSGLtcy4pI+Ys5FvuDKrJk9Ru577Em/r2d?=
 =?us-ascii?Q?XbgdLkJlOD7DjnYpBuxWztfpGwN2xkSbQG9+4Sg3je4GeVXJSlhLrv9DNUr5?=
 =?us-ascii?Q?SqYhNN3ndiD3B4/XpmXG4NF/LObEbHVFGAZCDam1K9iej5kFc6DorlECzbuH?=
 =?us-ascii?Q?mX5qEyKJhn7MM7Lrpti4RkiB1GsRTQubvGi8sV7YPKt7tY9N64BSjxutdNlD?=
 =?us-ascii?Q?4YaR7/EkoJj2v70a6niXkRh/bUHjbsjTVIV151Xub0odafGIAUXoZH4eiyRW?=
 =?us-ascii?Q?QLbW/nX1UavCQamfNyZejRR/RYGESD96fH1yhKOpztAV3iAweZ30xpC0uBwH?=
 =?us-ascii?Q?mMSz3BWcCuSyakihkF38gSbu1AadwgzrzSq56WQWIpRCB9FPlSQk2syt5uzZ?=
 =?us-ascii?Q?Bd2rhUE15FgEcQNzAbxPSjvS4QoX5HTW9RA1QP5itqhHzLDMufSe9xlayfPe?=
 =?us-ascii?Q?fRYdiAzFlJF2JWRpGUjdjzJvPnblpY80UAvONiTMwvsj4KLnPU2jnxobStSu?=
 =?us-ascii?Q?okeq9/QhU6dfsOpCpJqdET5Yp7x9Vr6ElHCRzFYkqp4PWCc90kCSak7ZR/i8?=
 =?us-ascii?Q?yOB+VeTixmvrbfkDF5Q5zJ/gQFfkuV+8dksHmeWUO+O+Ipby4JzU6Wh/SAdw?=
 =?us-ascii?Q?28L+TemDiUxKPYgqn9sdUgLE+CjvJvGNgnLzxk19Cez9oOBNbII2Rmhcd7O2?=
 =?us-ascii?Q?OGm12G8P0N1H/N+MX1ivN+2N3kkZIGgwcSwMK/6rpTbNpWwCX2Kdqx7W8d/b?=
 =?us-ascii?Q?fTF4yT2xqah+H6dj2IFm5NNlw1hLQgKb56Mm6K9t3YPdh/A90mdZi03rbDNh?=
 =?us-ascii?Q?QXShptnCLn30wClFQqdN2rOEbxc+qEd6irAMIyUopdZaXYz8DRqOtesp4ZWt?=
 =?us-ascii?Q?ctLo726irA1osKHlfGs5R9Imtqyn0IcyEmLUn3S5Nr0jwTDZMBY4j/VK9UX9?=
 =?us-ascii?Q?QskYw56fG6HhxBO1nATBnxyt+2Jqz/ruerDw9ea9z4mbtB9vGBKtE5TarkKi?=
 =?us-ascii?Q?6yJ3VP9xjJRYfTo/n21i4oYjpHvLpf7O5Puy33tSPCT48wJeh4BTXjih/hZB?=
 =?us-ascii?Q?iNLHZlaf2wtViTDnkzCDT2oqs4iurT4ZgrrHfpsxpECsLgZxB6zOpUKVQk2d?=
 =?us-ascii?Q?QnaJKt0bxB0UvJJR//m4Igo9kTFgwgJ4ONxAJQxoRmiA0/8f7Pdnfe2Q4w8d?=
 =?us-ascii?Q?D+Cj765HjskJmKmnYhVsYdLQ/Cj7g2zdenJrgLx5GRd4AZFhTCNL9sPE5dLV?=
 =?us-ascii?Q?1PXaS/OUsxF2+7/Q/xPcKY7CZ4OmPsBFHSn2ZkFA?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 585a9bae-f9b8-4963-e5a4-08da5586ce05
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2022 02:11:09.6349
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9wbS5Ua9KpK95+8pfWx8MOAHr9No5COQ2gQi0c9PeIRCg+I1BMj73oKnB744iT2+2tEft/MZL1m7HgP/ODjNBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB3089
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Thu, Jun 23, 2022 at 11:04:05AM +0800, Neal Liu wrote:
> > Add read TOC with format 2 to support CD-ROM emulation with Windows
> > OS.
> > This patch is tested on Windows OS Server 2019.
>=20
> This description says "format 2", but the patch actually adds code for th=
e case
> where format is 1.  This sort of mistake is not acceptable.

Sorry for typo. I'll update it for next patch.

>=20
> > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> > ---
> >  drivers/usb/gadget/function/f_mass_storage.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/gadget/function/f_mass_storage.c
> > b/drivers/usb/gadget/function/f_mass_storage.c
> > index 3a77bca0ebe1..3c2a5f1e8b66 100644
> > --- a/drivers/usb/gadget/function/f_mass_storage.c
> > +++ b/drivers/usb/gadget/function/f_mass_storage.c
> > @@ -1209,6 +1209,7 @@ static int do_read_toc(struct fsg_common
> > *common, struct fsg_buffhd *bh)
> >
> >  	switch (format) {
> >  	case 0:
> > +	case 1:
> >  		/* Formatted TOC */
> >  		len =3D 4 + 2*8;		/* 4 byte header + 2 descriptors */
> >  		memset(buf, 0, len);
>=20
> When format is 1, the driver is supposed to ignore the start_track value.=
  Your
> patch does not do this.
>=20
> The default case in this switch statement has a comment saying that
> Mutil-session is not supported.  As a result of this change, it now _is_
> supported.  The patch needs to update that comment.

Okay, thanks for pointing out. I'll update it as well.