Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4027cf04-d39e-d8fd-b3af-c1873757bb39@amd.com>
Date:   Fri, 24 Jun 2022 09:34:49 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v4] sched/fair: Introduce SIS_UTIL to search idle CPU
 based on sum of util_avg
Content-Language: en-US
To:     Chen Yu <yu.c.chen@intel.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Mel Gorman <mgorman@suse.de>, Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Barry Song <21cnbao@gmail.com>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        Len Brown <len.brown@intel.com>,
        Ben Segall <bsegall@google.com>,
        Aubrey Li <aubrey.li@intel.com>,
        Abel Wu <wuyun.abel@bytedance.com>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Tim Chen <tim.c.chen@intel.com>, linux-kernel@vger.kernel.org,
        Yicong Yang <yangyicong@hisilicon.com>,
        Mohini Narkhede <mohini.narkhede@intel.com>
References: <20220612163428.849378-1-yu.c.chen@intel.com>
 <76c94a3b-6ca2-e0e2-c618-42b147d2737d@amd.com>
 <20220624020723.GA11803@chenyu5-mobl1>
From:   K Prateek Nayak <kprateek.nayak@amd.com>
In-Reply-To: <20220624020723.GA11803@chenyu5-mobl1>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djZXY01GTFVEVWtYcTdGVU9VeDZlRld1U2dSSDQ5ckJzcUJtUjRWQ0pkV2xn?=
 =?utf-8?B?a2lBWEd6RVZmdHl2WmhlQnQya2J1amUvVjJLbmt3QlNvTGdMY0xndm9ORXlK?=
 =?utf-8?B?WGlRcXZ5TWtqZVhtNFc4N0k0aWRWZy9OYjg1SmJsQStGU2N0Q3VZTkdyUU5L?=
 =?utf-8?B?NW9Tbi80VURROXZKWVNhbjdsOGIvcGpLc2Y2VjQvaGp0UGxnYXZBNS93VXI3?=
 =?utf-8?B?Rkd5elVqT2FHeXZXeHpWUDZHK1o4L2s3OWgzOFZlL3d3VUREaHh1bjhDSUJ4?=
 =?utf-8?B?cFc4bUdvd254cU9URUtoamh6cWxoUm41bkNBYlMyR2FBdGJhRjUxbDN6WjNS?=
 =?utf-8?B?cEtMYWxvUStYb3FYa0xOd2ZKNjF6bk5sSGwwZUtKTTcxcksvQzVRMnVaSmxU?=
 =?utf-8?B?aHZ6MHh2TGlEZllrOFltdVJkamxsYks4MFRVTW9WQ3NsSHZ3QTZaM2JEcE82?=
 =?utf-8?B?YW1OQXNOdUFtcmVoV1hWNGhpLzZLRGIwcGF3eFA0M1hodHkxQTV6VWw5K3Q0?=
 =?utf-8?B?TnlkRTNZMjlkUnJrRGVMNXpIZEVFUXhMUXdLY2JRRHViQmpWd1lMWGo5cDdq?=
 =?utf-8?B?ck1jN3VzL1RxVGtZeFVzMzZVdXlVM2tHWG0wcElYZUhYUlhuR09qZjZ0bEl1?=
 =?utf-8?B?LzlBeC9lajVPTU96dDdxOSs3eVBRUlhpb1pHZklYV1FNZUUxUFlOTFI3OVBF?=
 =?utf-8?B?OGliMmxqS3VMTHRDYitUcTg4U0VUSHpFZjd6dkJtNVU4MG4zSU44TGxwNTBt?=
 =?utf-8?B?N2hrYjFoSzdKTXQxVVUzM1NMRWVDaTlnQnZUYUNqZEdpTzF1K0Fja1pzZWQr?=
 =?utf-8?B?UWZ6RTNlY2UwYU01WmhEdktmQVVORWJxdFFKRUhCTjQ2TnBZa1BXUm16QU52?=
 =?utf-8?B?SVFDaVVkRHV3M1VIRkRvdG5NNnIybzhOK3RtOGpod2RTYVltUnVMWW4wUzFu?=
 =?utf-8?B?MFhQRE5EV0ZMdDlXMStEQTJ5ZWd6MXFpS1hnYXpGVFVuNmJZZzQzSFJjM2xh?=
 =?utf-8?B?RnFLQnVESGtGck1GYXJ5cUxWZU42SnIydUhlRG1QM3o5YU5aV0s1dUpKZ2Fo?=
 =?utf-8?B?WmdRUUhxNFhDUENBNUtaQnV6M3N3K012dTVwTWRTclZmTTlrRnp5WmlnWEk1?=
 =?utf-8?B?YWRWd0F3dHBsaTk4MHJ1b0s2d1dXM05xb3ZDbUNsZy81NFUzZmNIdW5BUGxw?=
 =?utf-8?B?MFlMdTB5MWNhZ1U3RCtKNlgrTXA0dnZKZ2NCTlNzT29NbzVwNjVBNStqd2ZO?=
 =?utf-8?B?QUdlVjUrYndFU3BqdkN1V0cyVU92RnBlbmpzaEVEcTR5UWdyME5ubms1NkpM?=
 =?utf-8?B?TXJLa0FJS0ZUN2dIdVVpMDVUMmRBUjArdmZyak0rbkNQcnIxTDJnL1hJUVdW?=
 =?utf-8?B?NENPd085RTY0cEsyTUd4L3dCbzJReG12b05veFVuN1BhZ2U0QmtobTE2Um9r?=
 =?utf-8?B?aDFtenZ4SHFYUzZveXN3b2k5K2JCWUhFSGdoc3E0OGVpVkFVQ0ZNc1dXZTFM?=
 =?utf-8?B?WnpWRkxEZG1JYmdVUHZ0VzMyZVBvMEV3WWZNbUlicWlwMHNCdU9oZHpIVHhO?=
 =?utf-8?B?aE5pbE8wM1ZkR2U4aHpKZU1Tc1VZblNmYTJyMEp6b2U3cDQ0Sk9ualJjRzVV?=
 =?utf-8?B?bEw2NFdKbEJFWUhlVnd1S3ByWXl2eXh0anBRVCtOT3ZWdlhzaFF2RzRiWU5J?=
 =?utf-8?B?K3oxSldreFNuYjlJS3pZZ3h4Q3k0Mk1ISlpueXVGb1FOc21vUVNIYUdGVjgv?=
 =?utf-8?B?WHRCV1JjS1JoTW1VRjFyei9Sc2lUYWFxM1FMR055bzdqWkY3S3UxV3RRV0NI?=
 =?utf-8?B?WUhLQ0hMYWtEVDc0TzEvUnZuWHNnOVFQdVZvSTdVOFZoZWs2cUxyTUFtN1Jk?=
 =?utf-8?B?NlpZalhQRHcrTEhBL3lEOG5wb292aGNTK3RRSFhuRCtPZWFrYmFVLzJqd2R2?=
 =?utf-8?B?SFhpSlA3NVVaZkhKemZPdEp3ZE5SaWNlVktndCtkbTdGQm5jcTVkdThmcjZV?=
 =?utf-8?B?M2ptc1d1Rkh3TUYvdHhiVGhUR0lHSG5ZaDNVYWhtcGdkZDd6d3QzaFJMZkM4?=
 =?utf-8?B?OXZnQXRNbGJjc1B3OGs5QjJPVWM4Yjdxcm1INlRqNDBETzVSWEgxVGwxOWtM?=
 =?utf-8?Q?p3X0=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4378e6f5-61f9-4b96-3be1-08da5596b4bd
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2379.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 04:04:59.6164
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TWPm473C5SH8KtaDMyRIDAxioPtT0IZiytm13FmiHfMlz4QyB+KZImLwkeKxGIqFvcG5qtQQDlmdWzj9vsRbCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4515
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Chenyu,

On 6/24/2022 7:37 AM, Chen Yu wrote:

>
> [..snip..]>
>> With v4 on the current tip, I don't see any need for
>> a special case for systems with smaller LLCs with
>> SIS_PROP disabled and SIS_UITL enable. Even SIS Efficiency
>> seems to be better with SIS_UTIL for hackbench.
>>
>> Tested-by: K Prateek Nayak <kprateek.nayak@amd.com>
> Thanks again. Would you mind if I add this test report link into next patch
> version?

Sure.
I'm assuming the next version will disables SIS_PROP and only
keep SIS_UTIL enabled which is the same configuration we ran
during this round of testing. The results should stay the same :)
--
Thanks and Regards,
Prateek