Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b3ce0855-0e4b-782a-599c-26590df948dd@amd.com>
Date:   Fri, 24 Jun 2022 09:28:23 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
        Hugh Dickins <hughd@google.com>,
        Jeff Layton <jlayton@kernel.org>,
        "J . Bruce Fields" <bfields@fieldses.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mike Rapoport <rppt@kernel.org>,
        Steven Price <steven.price@arm.com>,
        "Maciej S . Szmigiero" <mail@maciej.szmigiero.name>,
        Vlastimil Babka <vbabka@suse.cz>,
        Vishal Annapurve <vannapurve@google.com>,
        Yu Zhang <yu.c.zhang@linux.intel.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com,
        ak@linux.intel.com, david@redhat.com, aarcange@redhat.com,
        ddutile@redhat.com, dhildenb@redhat.com,
        Quentin Perret <qperret@google.com>,
        Michael Roth <michael.roth@amd.com>, mhocko@suse.com
Subject: Re: [PATCH v6 6/8] KVM: Handle page fault for private memory
Content-Language: en-US
To:     Chao Peng <chao.p.peng@linux.intel.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
        linux-doc@vger.kernel.org, qemu-devel@nongnu.org
References: <20220519153713.819591-1-chao.p.peng@linux.intel.com>
 <20220519153713.819591-7-chao.p.peng@linux.intel.com>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <20220519153713.819591-7-chao.p.peng@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2ZHZDhTcjNHRDVRb0R6SlVZYjh1RjNZNmlXTzZkRDdmcE11ODBZa3Z4TWZG?=
 =?utf-8?B?alhQdSt3TUFKYkI5RjBoWmNFanROOEVzSXZOU0xWdnNDVnVRczJCWk9Wa3ND?=
 =?utf-8?B?VXF0RlFBaC9oR3JCZnVoNjZBWGF2VmZaRnYzbjhXMmNFY1RnUmpFcGhzMGVa?=
 =?utf-8?B?ZUNOVFNVOUdYemVqZ0ticWRkN0svK3VOTVN2QndYN1pCQzVNQ2ROKzdjMlBY?=
 =?utf-8?B?NlNTT3IyRnZWMThMWXVUMmZkVzZ4dmIrcHF1VUVwZi9YbGZOeDdPQUJXcFR4?=
 =?utf-8?B?bmZmNnpmRHdPWWU0enJKYUtaRFFJVFl3OEgwWGN1c3RXRnVGamg3dUxWWDA3?=
 =?utf-8?B?bFd6WmFreFE2NUpVVVI0THpTSHJmdGp6UlZuWXcvOW5ubWRTVHlMbFZzRm40?=
 =?utf-8?B?NnRiY2N6bitaMDBOTVk5L3NuSzdFWGV2SFl1ZFNOd1h1NTFJTkN1WXlVM1Nw?=
 =?utf-8?B?alNBdzJBZ01aajdxemtobXlDWDA4ZTl1OGt5aFBEUkt3amJBWVB5c0IwSWRp?=
 =?utf-8?B?cW1kNjM0UG5vcnNHWnUxTUtYRlVpZGFkNG1uRk92V0xxYWdGUTV0VXlMR0xF?=
 =?utf-8?B?YnpFSldDWDRoRHE4UzFkb1dQeE5FMnJZOVlxYVllOWdqRHY4V2liUUk2SUxC?=
 =?utf-8?B?SFNHMWMrOWQ5dmRsaW4xdS85MTdCTWVjNllFTnJIcUlTV202NGl0TDc4TUh6?=
 =?utf-8?B?REV6M3hveE85MjNXYUFhTXNQajVkZEl1YVVMNGRkODNpSWQybjB6SERVSmFZ?=
 =?utf-8?B?WTNRdXczMXhXSW82WkxmVlRPaVpRTHRPWlZuNXVkNG5pcWMvMVlSZUM4TzNz?=
 =?utf-8?B?OHFJY3RjUlVyYi9jTDlWSGV3cDVjM3BLR1hDR081UmJLT1hmYXBtRFRsMnNK?=
 =?utf-8?B?ODVhRXRSTnJPUnppQ01xNThXR0NGRmUzam1EeHNzMm9vSzhsOStOQ3FlSzVQ?=
 =?utf-8?B?TGpsMTFPM21odEl1R2RrcXRkVll5QWNkK2FsazhHNmlHUXdYMVgrbGdDdE5K?=
 =?utf-8?B?TXpjeXdSZm8wVExjYncxNURUZUhodDROY29rZW1yamNNY256RzBSQWNYQzdH?=
 =?utf-8?B?MnhLMlIybzJpU3NqN1JwYTFNZHBLeEltekwyTkZEN3U5OWxTd1hSUTVSV29u?=
 =?utf-8?B?dFJnRGF2dFVZeXpJaVRuV2ZJb2xjUnV4WEI1TmU1SmlSa29oTDMwRGtKSm9D?=
 =?utf-8?B?cG1TMk15Skw0MC95WFgwNzh5WWp2bkkyTWc0bGNwVXhNaHg5bGNHeTUrbzcv?=
 =?utf-8?B?NzF3SmQ2anlrcUpnWU5WRHRObHFpZ2hIUk1QOXByMkh2VlFtWXVVSU9Vem1U?=
 =?utf-8?B?K0lSU0Q0aUFjbHYyZ2p6SGxMRnpiYXBTWDA0cWhyNVZnUmVPaG9ZMGFOdkVv?=
 =?utf-8?B?RStPNTRDVWZ1Ry9IUjFSYldWTlYxeHBiWEVBcG1FZTQzdXRnQVZJWTNIeW1T?=
 =?utf-8?B?YlFReUNLbHhQZUZTQkU2cFppUVhhQlJ1Q3JXbW5PcHZGMHZkeEVYckRVUzhv?=
 =?utf-8?B?eW12MndHY3JidS9NbDB6YXhkVGZxekZYd1VkMnY0MytySXU1NTgzYUM0a1RF?=
 =?utf-8?B?a3E5SDFlMCtxUm5rRDRWcm0wVW92emVSNFZURWtvMFF5M3Y0M05aakwzR3M4?=
 =?utf-8?B?cWtKWm1WVHVOY1B1WHVlTm15QlJReG1LSzBIMVU2MjNLTGZ3NHJMYTByNjNZ?=
 =?utf-8?B?eG1xMXNiYVcyVDl6WTFjZ2ZYQ2dnSzUvSjVFc20xL3JFZGtXYWNRYUJSU0JB?=
 =?utf-8?B?SkxvVTZpNVdxckYzQ2JaWTVySXVrMy83c0V3UGltYWJXdTRsRmRQRENHckRN?=
 =?utf-8?B?aDR1ZXpDc1h5eFM5a3p2aHZwUEFyOGUxcHgrRmhOWmRkVlNmTjllUzB5L09Z?=
 =?utf-8?B?NlNmMnljY2xLRXlJblorek0yYXN5Z2FucGhsQ2l4b1FDUWxFb1NaU1Bxa0wr?=
 =?utf-8?B?YW5PRXd6YUhJeE1zc1Z3NEIxbm1OeGFYbnQxcDFHYWFEZjFvYkhkVzFxSEZx?=
 =?utf-8?B?eGJqZVpxL1hyNzJHSU50TUYyaytZWThmZW56YVdlYUhKa3VKcitOKzhKZkF0?=
 =?utf-8?B?eDdYclFyR2ZvWHUrMXh1ZU1wVlNJMkpObENVQkl5MTdodkJFMis1ZnlScFE2?=
 =?utf-8?Q?TXzeKmZOuW4YX7pMbuNDyFDJm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ddcf06f2-70fb-471c-4ce3-08da5595d307
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 03:58:40.8898
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j0gAnpk4Id/KcOplibB78PfNNpFv5eIaBcwOSNRYcelKpeeDPvz1ZIbsgk6ZTwE0IR9PJZEsFvY3Jasg1xm1+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR12MB2801
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/19/2022 9:07 PM, Chao Peng wrote:
> A page fault can carry the information of whether the access if private
> or not for KVM_MEM_PRIVATE memslot, this can be filled by architecture
> code(like TDX code). To handle page faut for such access, KVM maps the
> page only when this private property matches host's view on this page
> which can be decided by checking whether the corresponding page is
> populated in the private fd or not. A page is considered as private when
> the page is populated in the private fd, otherwise it's shared.
> 
> For a successful match, private pfn is obtained with memfile_notifier
> callbacks from private fd and shared pfn is obtained with existing
> get_user_pages.
> 
> For a failed match, KVM causes a KVM_EXIT_MEMORY_FAULT exit to
> userspace. Userspace then can convert memory between private/shared from
> host's view then retry the access.
> 
> Co-developed-by: Yu Zhang <yu.c.zhang@linux.intel.com>
> Signed-off-by: Yu Zhang <yu.c.zhang@linux.intel.com>
> Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com>
> ---
>  arch/x86/kvm/mmu.h              |  1 +
>  arch/x86/kvm/mmu/mmu.c          | 70 +++++++++++++++++++++++++++++++--
>  arch/x86/kvm/mmu/mmu_internal.h | 17 ++++++++
>  arch/x86/kvm/mmu/mmutrace.h     |  1 +
>  arch/x86/kvm/mmu/paging_tmpl.h  |  5 ++-
>  include/linux/kvm_host.h        | 22 +++++++++++
>  6 files changed, 112 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/kvm/mmu.h b/arch/x86/kvm/mmu.h
> index 7e258cc94152..c84835762249 100644
> --- a/arch/x86/kvm/mmu.h
> +++ b/arch/x86/kvm/mmu.h
> @@ -176,6 +176,7 @@ struct kvm_page_fault {
>  
>  	/* Derived from mmu and global state.  */
>  	const bool is_tdp;
> +	const bool is_private;
>  	const bool nx_huge_page_workaround_enabled;
>  
>  	/*
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index afe18d70ece7..e18460e0d743 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -2899,6 +2899,9 @@ int kvm_mmu_max_mapping_level(struct kvm *kvm,
>  	if (max_level == PG_LEVEL_4K)
>  		return PG_LEVEL_4K;
>  
> +	if (kvm_slot_is_private(slot))
> +		return max_level;

Can you explain the rationale behind the above change? 
AFAIU, this overrides the transparent_hugepage=never setting for both 
shared and private mappings.

>  	host_level = host_pfn_mapping_level(kvm, gfn, pfn, slot);
>  	return min(host_level, max_level);
>  }

Regards
Nikunj