Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 08:21:18 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Felix Schlepper <f3sch.git@outlook.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/3] Staging: rtl8192e: Cleaning up error handling
Message-ID: <20220624052118.GT16517@kadam>
References: <cover.1655975970.git.f3sch.git@outlook.com>
 <13b32131cd00a1f0b8793657a24ada71240a8350.1655975970.git.f3sch.git@outlook.com>
 <CAHp75VcQcKaYUP_JsmTFOY-pbOR39+TMw=5ADbb2BRGoMijCMw@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75VcQcKaYUP_JsmTFOY-pbOR39+TMw=5ADbb2BRGoMijCMw@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IQ6brmtgva0SNhkDIL8kunywtfPIDQvBCtYpPywqBu9a6H8htjA7FIXpuwCD?=
 =?us-ascii?Q?bAlUvgrOeRQRW4eF44xxFFucnrRLAMWWl1CprSFqtRnaTv66gmR4sEd380Mn?=
 =?us-ascii?Q?7BH3hbf3B6TQ2hOy9TkPsGR9i7zKUdO158FSPgt39FKaJEo0STSaqI5x3NOg?=
 =?us-ascii?Q?SvToLRfsLjKiXBSN04a2r/Ta9UyERFSDR5ssTD0SzOllNZpPoCvf0i2GMT8S?=
 =?us-ascii?Q?KLQcplw6DaJAX/L5ZFu6ycOH77oyNq2LYi9o4+p//YWuK1yhzvAcxEnQpOtj?=
 =?us-ascii?Q?YQPNrQcZflKYEJvJEGHjRQp+QQ4spD2UO46FBc+Rfq9ltBIulFUOakGoN6+O?=
 =?us-ascii?Q?FHTmOHPtW4er26+vLBgnDTzmEWrJGVoQpmbxDdb4W0vRzw2GsaZVifsS/YC5?=
 =?us-ascii?Q?tLjCBUyIh8k519wvlwLZPTycgkFIAXtHl0DUac7WwKGugMB80aLJsCHO0dcU?=
 =?us-ascii?Q?4q6kuTNalgkoBu4Xj/TapGOnavGVPLMiWWI/u3DRdpC0nZq8hxjz2JVe5KyF?=
 =?us-ascii?Q?SqhI9T0Q6p9GNltQB48FQsLVPeonHRN1XaAV8J6fY58b6TyAp5QmrOUaUvCt?=
 =?us-ascii?Q?/4+7kRtSCWojYXRmrg1L+WLiFBw0h1Ae4VBofITEf6WSVwjCJWQmoUkzZoPG?=
 =?us-ascii?Q?KoHcHcgYJSXEeoZsiHBI2/+nxX1DHFo1F8+Hq4VK7IjPI7VtN6c5osrGTtYO?=
 =?us-ascii?Q?yAj7GmqlxqRA1KM+iKA7RLBeW9fHxL+DyE3wLhWd1u0RtiI4Ls5eiCFy9RJS?=
 =?us-ascii?Q?+HUrKmlhN9lp7oKIic5Abx0zemAQaWopj6QTpemUpZ3nK6Sob6okTBxrk5hh?=
 =?us-ascii?Q?HIom4EsyIh1T1hIv+52RuOIUpbTLz1Z3HGHBSfkYtNdLzu69OA/c4GuS142k?=
 =?us-ascii?Q?ByF8ha0R2TrQtukMmek2mtnYOnt4GURJdLJ45Ku22vbxzNtudxD2zo+E6iXH?=
 =?us-ascii?Q?I2mbcld5Q+YZ10iqtgqUFVW6XOltr0JxZMl8lGrUc3WUyz7y31XFTkWOveXS?=
 =?us-ascii?Q?jQEqXoYB9+V+YGN6iMpSGA+oFmaLoBl/kc3S936pRncINBQ5/+j4ut1CIDTo?=
 =?us-ascii?Q?rXmUSjN8Z+aY2PiQbVrV8goWYUTp43eNlxb9tq+O9PQdujVZYjHc+GAU+T5o?=
 =?us-ascii?Q?3jI3vEsARAKHH3b3HMAWkHyvua8VFxvPMmUmSklcIpq6hLzLW5RDWH6L8+ki?=
 =?us-ascii?Q?dxCwTmRuYxAhIS4zRe2fWag64Y8VXoKKZycofZDsvmfoTjYEF2C/iTu5v171?=
 =?us-ascii?Q?PMIZr1hyQHeZJ9v/M8CoJOFtvt3ISzEtDPUb2w/H18r3tsXDToxPUdOc9lRC?=
 =?us-ascii?Q?bMQinA4aVpqG/p4TrQWZZm+TWb7/nHdbBAT4l9Q89WapN2Mc5zGa27KKBwXY?=
 =?us-ascii?Q?F/tUXkS7Rgl9tncwdd3PhryI1BYlNgaX4ZtABm1g915uu5FN42cWrcVIRQgS?=
 =?us-ascii?Q?z/fqEkEtWzZxY5UH2bNKNOw9EdSPbDFVsLNiyAc4MS5a8cOzkEEwpeXnAek+?=
 =?us-ascii?Q?IS5BlT8VEVLwHdTDbc4yWHI3YUXhtOL9tMHWg27BezLnpYy7cSP3brg85neO?=
 =?us-ascii?Q?W8TIPiK2stJWp6+cSoEIKeVuxwqcPseWPZY2XamsEzuwA+l25Xmd67dPWCvt?=
 =?us-ascii?Q?fA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d7d945c-de0f-4882-18ec-08da55a16884
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 05:21:36.3398
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NvGTik4KwyateqJbXlUxcMp1S69Hne9p4xaRG9on91YpGHATZf8DA957uvTHJw7ILEo/ztp9ZCR33cRdxb+/Zsm+vgazkiVKXWheBKyCywQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR10MB2610
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-24_03:2022-06-23,2022-06-24 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=953 suspectscore=0
 phishscore=0 malwarescore=0 mlxscore=0 spamscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206240019
X-Proofpoint-GUID: lQqWREJET9mKm0r4Z0fSxLrPdcUJEOvg
X-Proofpoint-ORIG-GUID: lQqWREJET9mKm0r4Z0fSxLrPdcUJEOvg
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 23, 2022 at 11:20:49PM +0200, Andy Shevchenko wrote:
> On Thu, Jun 23, 2022 at 10:44 PM Felix Schlepper <f3sch.git@outlook.com> wrote:
> >
> > Moved error handling to one common block.
> > This removes double checking if all txb->fragments[]
> > were initialized.
> > The original code worked fine, but this is cleaner.
> 
> ...
> 
> > +err_free:
> > +       while (--i >= 0)
> 
>   while (i--)
> 
> will suffice.
> 

Either one is fine.  You prefer this format.  I prefer that other
format.  I told Felix he could use either format without expressing any
bias and he chose my format.  That means he loves me more.

regards,
dan carpenter