Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 08:39:30 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Chang Yu <marcus.yu.56@gmail.com>
Cc:     Greg KH <greg@kroah.com>, Larry.Finger@lwfinger.net,
        phil@philpotter.co.uk, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: r8188eu: combine nested if statements into
 one
Message-ID: <20220624053930.GU16517@kadam>
References: <20220623031515.402691-1-marcus.yu.56@gmail.com>
 <20220623051404.410632-1-marcus.yu.56@gmail.com>
 <YrQ2Izg1b399yJou@kroah.com>
 <YrUw3lejTP0UyWmt@zephyrus-g14.localdomain>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YrUw3lejTP0UyWmt@zephyrus-g14.localdomain>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Qa6veGI8NYDJsNJRUUVAwToMlxEpHmtNePLwNBK4+L8InG/NikGIRRG0T0OC?=
 =?us-ascii?Q?9XwjbHpu1tDTPaaIwT2A98R3UEmPp+Y0fiKM/E5sYLE4CsaAeTRo+19oViz4?=
 =?us-ascii?Q?C/rARqvD2DhxoTGJ31ZjJF+wh5MlI4V1yeJOYavBH7tvv+Xtw+pMQeCuXKPP?=
 =?us-ascii?Q?GCTPFHNgvS3AibI9xHXOaJ6pV87Va5AoZJb85vAo1xKm7JgJ/OG9A14chRm2?=
 =?us-ascii?Q?yUpPvRp+aF8Fd/m+ZSpJ9uhqadUKazsswYZxDw9qUmSPzYSXPyl8Sdhpo5m6?=
 =?us-ascii?Q?KzPnf598DxuucybKOAM6n4c5KIOT5EAxcK3Z/QpXEUGDQkPfK2Xv1pFv49tP?=
 =?us-ascii?Q?vgsQyVKQwFcVipiaC4ldHm8XxAp3HZp0w52XAMTL3SwKWtejRh8f2z//Q5Jo?=
 =?us-ascii?Q?E9ukml6itZ3dh0TN3t81L1mynsrhaMWSG+16231mGkSsDQNPTx0FsLvNAxAl?=
 =?us-ascii?Q?O2AIN1L+Qpcm0Hqe5aTtEUivOzz/NmBj4GqroUs2e5mpma4VBEqPwIn+KFqr?=
 =?us-ascii?Q?Nn4A9+KYmQF1lBJaxmqQHEPjVPwgezjoCMJzU9ILoiMZ2VbgBIm/H8RuzA9E?=
 =?us-ascii?Q?k3LGT1nOeXuENg9Pjnb7y0T/gY75TMmEc99KXxRB95ucZG9OClTA/AN2iyhh?=
 =?us-ascii?Q?rFlJOTqk+tWrCv70A2uwkRhq7PFILwdL+fXscCiTRiqEMza1qqWYSIhEpdsA?=
 =?us-ascii?Q?Bl76zagf92a5x//V4/QZX4vWXtY5lwmxOlopNTsY29Z1R0L0icd/m2MjzZs6?=
 =?us-ascii?Q?JRXee3sIME9caoVPf/M7FG5w75CxrlyjJ7edDV0VvSQsSKD/03pL/VuY5x7j?=
 =?us-ascii?Q?MVRxs6Ka5+wdISY3AN1uDcweyQDT9hndG+zlK/+715gqfzvUznSn6eJmed6V?=
 =?us-ascii?Q?H1ytinqmN6yDqq9BA6dAg9Pwi6a3OntspmIzZsLBiXWMcKhQEzq/KQVgXpkZ?=
 =?us-ascii?Q?VWkwKp3Q5Q4FZXWUy5jxnrqpynhOU1IE7qemS+BCGoW1e0KZB/QVzu1E4rtT?=
 =?us-ascii?Q?WD5AZkXaKgt2R6azmCsklx3B/IWWdaLDNkAhBC6rNdcCaLlTT/Xtp+l0lPXV?=
 =?us-ascii?Q?LDoZljog8KgduzG+JCCJt9veuMNRnzptwgDrXDDWgUlAcKsO3BMdL3wXqP30?=
 =?us-ascii?Q?HPTQY69uVLjh+VmxJSJQRyQMDCBtERdDJLNHn0QN1u37O9P6vIVe0R08CY6h?=
 =?us-ascii?Q?1/tiuSUvEGJ5E4GqObauvClUTsDJlZZtrNjd4t4HHDWSfI4MDuQlLnqfu/oq?=
 =?us-ascii?Q?95FYkhMgFlHRusMB5p4VnWQxJZ1JFNpLIEC3cCxoj+09mzDhybhPimPrP6d5?=
 =?us-ascii?Q?uHW0zCxDFnHNoQXqQ5KAym+ac2RmBDkfJvaeTqEsOD2K9qTyTS+csKTYl3Jd?=
 =?us-ascii?Q?bRR7sEbd5vbAAP4uk2KfEyUWL7wWux0yUQUdYX2NR6bVQpyNVtvO0E1b7/vm?=
 =?us-ascii?Q?jVrms4EHLAX6P6wgyCXAti2eAC+YblW1RV90dN7nQWQ39W5GfkY3H3hKWxw1?=
 =?us-ascii?Q?nYajmFl83skYYsTWmK30pu42jrxmU12On0zVLQfVsme9sOqQmsiLj931zlEr?=
 =?us-ascii?Q?HauhW+n4l1JPmnkb8WrV3LFqaG359A8NCuY40vYq0TDflujvw2uK6phrjM4k?=
 =?us-ascii?Q?vg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 382b666c-2ddd-4fd3-6e6c-08da55a3f386
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 05:39:48.6924
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 46viGUc/z3Ko6uTc3G9vTOcYq5gnriudtctzWBvpnZ3IXxTuT0IO2Oy5sdWqlb4TyhzgYaIz5+MsCMCVjhsw0EC6qLo/SdHRfEzjmNU1ywU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3485
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-24_03:2022-06-23,2022-06-24 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxscore=0
 phishscore=0 adultscore=0 suspectscore=0 mlxlogscore=715 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206240020
X-Proofpoint-GUID: unQ_Ne6mzJl56QrTLwgc-rve2xhlE2ry
X-Proofpoint-ORIG-GUID: unQ_Ne6mzJl56QrTLwgc-rve2xhlE2ry
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 23, 2022 at 08:34:54PM -0700, Chang Yu wrote:
> > - You did not specify a description of why the patch is needed,
>
> I'm not entirely sure how to fix this. I checked the original patch
> again and the subject and the body looks OK to me. I'm still a newbie so
> I might have missed a couple of things. It would be greatly appreciated
> if someone could point out what's missing.

What's the advantage of combining if statements?  Out of all the if
statements in the kernel why did you pick that one?  Probably it's
because the indenting was wrong, no?

Write the commit message like this:

[PATCH v3] staging: r8188eu: clean up if statement

I noticed that the if statement was strange and the code was indented
too far.  It is cleaner to combine both if statements as well.

regards,
dan carpenter