Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp90685iog; Thu, 23 Jun 2022 23:18:35 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tji63ChE4NMzGhhzFmXR9559yiSlwlVHZ3oDbUnLLGJbINydYW1Ecxuc4GGZng2IPkLwD4 X-Received: by 2002:a63:9244:0:b0:40c:531f:d9a6 with SMTP id s4-20020a639244000000b0040c531fd9a6mr10595649pgn.104.1656051514767; Thu, 23 Jun 2022 23:18:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656051514; cv=none; d=google.com; s=arc-20160816; b=J/ENjy4Jkl1mTjnB1c4wRIszMw3y54p8AO6GW0OwR8pQBu9FqgIuMmXDBVKdJW3rw+ c2Hy6BGNEnAGBpyaMA3BNAtfQ0bO8wrMoOq8ENV9VXtY4szOXZM+hvXzLQj4IKdVfK0o i2362Uw2kmY1d8yU5D+MlI4CCvCYfZX94uH6uQ+kHbifg2IMwgsUewShVGVA70V9+Z4Z oKIOjlqDrlraxbr/c3YNGQ6q4z0w9VMwSivfs44rD4aE5XAlVXxwh8SWRvpTanaIUZlu aJmRsklmGmdBsHRuYQNQHrORXCIREGlI+yYBc6hmEzKSGNEb1IRsebmFLvmSzSafsxYc Bg8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=uHRDeZq+dVuIh6mjrBm4pg/ttsqtVPO0YJ382Q+/I1g=; b=VciXVC3373d8QUaiMGjc1VALus29J3qEFjp8lvIKYs1yvhaJ7eurCP8Md7azAQO658 tTpRaxMfx6UxTG3ytmDhOuv6zOe8sIQbIeo2fIRKi6VM8NxkhQ6TX2aA5tmIq66Alius 1nWT5IXPiioZBZPIsOG9JhzW/lOcpiuBCYBgFe8UoVlLQSWHUgeR2KKhtx+21V+GTWkN alhFycLfNVBjOz9m+HADHZslZD8xRCws6IjHzlWWAfKLYboV57UO5wRs9+RM3dvRu53/ k2Nq7+KOLnS9qOuI/ASrLbjMQBip44ESjwA2ossJzMAVSEbsmdUA+LFzl9rCq0zxFwUA hc3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y23-20020a1709029b9700b0016a03c01742si1853242plp.184.2022.06.23.23.18.23; Thu, 23 Jun 2022 23:18:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230312AbiFXGLo (ORCPT + 99 others); Fri, 24 Jun 2022 02:11:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbiFXGLl (ORCPT ); Fri, 24 Jun 2022 02:11:41 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 53E8935DEE; Thu, 23 Jun 2022 23:11:40 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3F88B19F0; Thu, 23 Jun 2022 23:11:40 -0700 (PDT) Received: from [10.162.41.7] (unknown [10.162.41.7]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BE6293F66F; Thu, 23 Jun 2022 23:11:32 -0700 (PDT) Message-ID: <378e124f-914a-36b1-ff2f-9f4ea3b946a5@arm.com> Date: Fri, 24 Jun 2022 11:41:30 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH V4 02/26] mm/mmap: Define DECLARE_VM_GET_PAGE_PROT Content-Language: en-US To: Christophe Leroy , "linux-mm@kvack.org" Cc: "hch@infradead.org" , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , "sparclinux@vger.kernel.org" , "x86@kernel.org" , "openrisc@lists.librecores.org" , "linux-xtensa@linux-xtensa.org" , "linux-csky@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-m68k@lists.linux-m68k.org" , "linux-snps-arc@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-um@lists.infradead.org" , "linux-sh@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20220624044339.1533882-1-anshuman.khandual@arm.com> <20220624044339.1533882-3-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE,SUSPICIOUS_RECIPS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/24/22 10:58, Christophe Leroy wrote: > > Le 24/06/2022 à 06:43, Anshuman Khandual a écrit : >> This just converts the generic vm_get_page_prot() implementation into a new >> macro i.e DECLARE_VM_GET_PAGE_PROT which later can be used across platforms >> when enabling them with ARCH_HAS_VM_GET_PAGE_PROT. This does not create any >> functional change. >> >> Cc: Andrew Morton >> Cc: linux-mm@kvack.org >> Cc: linux-kernel@vger.kernel.org >> Suggested-by: Christoph Hellwig >> Signed-off-by: Anshuman Khandual >> --- >> include/linux/mm.h | 8 ++++++++ >> mm/mmap.c | 6 +----- >> 2 files changed, 9 insertions(+), 5 deletions(-) >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index 47bfe038d46e..237828c2bae2 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -428,6 +428,14 @@ extern unsigned int kobjsize(const void *objp); >> extern pgprot_t protection_map[16]; >> #endif >> > I think the comment above protection_map[16] in mm/mmap.c should be > moved here. Sure, makes sense. Will move.