Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp153408iog; Fri, 24 Jun 2022 01:00:51 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tJetxYOdGGaz0n5Oglf25dns09NHEtkYXJ93TjAcrCdsNdWLDw3kgAvTerGR+PknzHH942 X-Received: by 2002:a63:6a49:0:b0:3fd:df6d:5ba3 with SMTP id f70-20020a636a49000000b003fddf6d5ba3mr10780621pgc.385.1656057650538; Fri, 24 Jun 2022 01:00:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656057650; cv=none; d=google.com; s=arc-20160816; b=t4OIX5ozyNE1Fyn6+q5eKs8fPPiVLCU2mkxys31zGgDysZayNfsuGaRiblsOkCg5If MLo34KUMIfjMgwGOcSUB2gpx9/2iOJFZDydICw56RpYSr0DQvQWTIrfK58ksgG7UDQL6 SXgTdsPD2+dd42MFtXGSbyTKt0SrV+HnRWOBdKFpa8pQBiI3pVxNg8xRdTF2ASBA10DR sj6CaqhuzKH+mMF6F8HCk3yjM2p1FWwa4TUMYkbbLYhnJ3RHMHzgrYIqYWXlMMaTK1VH ilYxCy9yXNBzF3OCfXgmiOUGZlUnhZ7nICR7eHA/a+wSnAJ/vikTxQDkoq/wbCbVJwTo QwUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=KIEyGSVyVYvnBqJODG83/KTLjDBT27Um9Qw3r1tIIAs=; b=aZZNnwiukLrORZ2uNv/vkOyHiT5MKNK1JBt7FsGzj6qg6Q2kEzzF52s7/ZroHLtfQW VN9vopv2k9vWSVA70TaKnJPqNVOXClTdUs7jEK9iOBPkMrfF+qP+41OJCHHqxOuUbLZU /0bI7tjqRw6H99pWNSOc7k8QIQjm2/2A4JwTO2wOBzDfKSTawY3w5mNKp1Wk6fjj53Rv /in25rlXutdVcqJorxLqFVdUcWU41M2op6J6OzA1Y9UonIqRLe2jS8SwqM4LXF6ETBPj s36CKq7Xm3Zj8NsVYfREvpmTtq9yKQ8MwiB3/5cqrkZQ96pWwQcwFUTIGT1TT0sH53pU cGdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g14-20020a056a001a0e00b0051b9d2bc523si1594418pfv.253.2022.06.24.01.00.36; Fri, 24 Jun 2022 01:00:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229830AbiFXHv5 (ORCPT + 99 others); Fri, 24 Jun 2022 03:51:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbiFXHv4 (ORCPT ); Fri, 24 Jun 2022 03:51:56 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D7B9522E6 for ; Fri, 24 Jun 2022 00:51:55 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o4e6S-0005uf-NV; Fri, 24 Jun 2022 09:51:44 +0200 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1o4e6O-002NyL-HD; Fri, 24 Jun 2022 09:51:41 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1o4e6P-00DAhh-6r; Fri, 24 Jun 2022 09:51:41 +0200 From: Oleksij Rempel To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Oleksij Rempel , Anton Lundin , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Lukas Wunner Subject: [PATCH net v1 2/2] net: usb: asix: do not force pause frames support Date: Fri, 24 Jun 2022 09:51:39 +0200 Message-Id: <20220624075139.3139300-2-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220624075139.3139300-1-o.rempel@pengutronix.de> References: <20220624075139.3139300-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We should respect link partner capabilities and not force flow control support on every link. Even more, in current state the MAC driver do not advertises pause support so we should not keep flow control enabled at all. Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support") Reported-by: Anton Lundin Signed-off-by: Oleksij Rempel --- drivers/net/usb/asix.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/usb/asix.h b/drivers/net/usb/asix.h index 2c81236c6c7c..45d3cc5cc355 100644 --- a/drivers/net/usb/asix.h +++ b/drivers/net/usb/asix.h @@ -126,8 +126,7 @@ AX_MEDIUM_RE) #define AX88772_MEDIUM_DEFAULT \ - (AX_MEDIUM_FD | AX_MEDIUM_RFC | \ - AX_MEDIUM_TFC | AX_MEDIUM_PS | \ + (AX_MEDIUM_FD | AX_MEDIUM_PS | \ AX_MEDIUM_AC | AX_MEDIUM_RE) /* AX88772 & AX88178 RX_CTL values */ -- 2.30.2