Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 10:03:37 +0200
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Cc:     kernel@pengutronix.de, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH net-next v1 1/1] net: asix: add optional flow control
 support
Message-ID: <20220624080337.GA14396@pengutronix.de>
References: <20220624080208.3143093-1-o.rempel@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220624080208.3143093-1-o.rempel@pengutronix.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri, Jun 24, 2022 at 10:02:07AM +0200, Oleksij Rempel wrote:
> Add optional flow control support with respect to the link partners
> abilities.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

This is a net-next patch, depending on other net patch:
https://lore.kernel.org/all/20220624075139.3139300-2-o.rempel@pengutronix.de/

> ---
>  drivers/net/usb/asix_common.c  | 10 ++++++++++
>  drivers/net/usb/asix_devices.c |  2 ++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c
> index b4a1b7abcfc9..c9df7cd8daae 100644
> --- a/drivers/net/usb/asix_common.c
> +++ b/drivers/net/usb/asix_common.c
> @@ -420,6 +420,8 @@ void asix_adjust_link(struct net_device *netdev)
>  	u16 mode = 0;
>  
>  	if (phydev->link) {
> +		bool tx_pause, rx_pause;
> +
>  		mode = AX88772_MEDIUM_DEFAULT;
>  
>  		if (phydev->duplex == DUPLEX_HALF)
> @@ -427,6 +429,14 @@ void asix_adjust_link(struct net_device *netdev)
>  
>  		if (phydev->speed != SPEED_100)
>  			mode &= ~AX_MEDIUM_PS;
> +
> +		phy_get_pause(phydev, &tx_pause, &rx_pause);
> +
> +		if (rx_pause)
> +			mode |= AX_MEDIUM_RFC;
> +
> +		if (tx_pause)
> +			mode |= AX_MEDIUM_TFC;
>  	}
>  
>  	asix_write_medium_mode(dev, mode, 0);
> diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
> index 5b5eb630c4b7..1bb12bbc34bf 100644
> --- a/drivers/net/usb/asix_devices.c
> +++ b/drivers/net/usb/asix_devices.c
> @@ -677,6 +677,8 @@ static int ax88772_init_phy(struct usbnet *dev)
>  	phy_suspend(priv->phydev);
>  	priv->phydev->mac_managed_pm = 1;
>  
> +	phy_support_asym_pause(priv->phydev);
> +
>  	phy_attached_info(priv->phydev);
>  
>  	if (priv->embd_phy)
> -- 
> 2.30.2
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |