Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1db60157-9f26-cc09-9a8d-2813a3a3ac95@linux.alibaba.com>
Date:   Fri, 24 Jun 2022 16:41:47 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [RFC PATCH v2 1/3] mm: Factor out the pagetable pages account
 into new helper function
To:     Matthew Wilcox <willy@infradead.org>
Cc:     akpm@linux-foundation.org, rppt@linux.ibm.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <cover.1655887440.git.baolin.wang@linux.alibaba.com>
 <e094c4a2e07ff66708f7a3a9f6b86eb694f33cf0.1655887440.git.baolin.wang@linux.alibaba.com>
 <YrSPsqJHJTRcCmph@casper.infradead.org>
From:   Baolin Wang <baolin.wang@linux.alibaba.com>
In-Reply-To: <YrSPsqJHJTRcCmph@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/24/2022 12:07 AM, Matthew Wilcox wrote:
> On Wed, Jun 22, 2022 at 04:58:52PM +0800, Baolin Wang wrote:
>> +static inline void pgtable_set_and_inc(struct page *page)
>> +{
>> +	__SetPageTable(page);
>> +	inc_lruvec_page_state(page, NR_PAGETABLE);
>> +}
> 
> I don't like the names.  The accounting is also wrong for non-order-0
> allocations.  It should be
> 
> 	mod_lruvec_page_state(page, NR_PAGETABLE, compound_nr(page))

Yes, seems need another patch to convert using compound_nr().

> 
> but it's probably better to change the API to pass in the number of
> pages instead of recalculating it.

Lots of callers will not calculate the number of pages, so I think we 
can just add the compound_nr() in the API firstly, which also can avoid 
changing lots of callers.

> I can't think of a good name.  What's wrong with just adding
> 
> static inline bool pgtable_pud_page_ctor(struct page *page)
> 
> to go along with the pte and pmd variants?

IMHO that means we will need another function like 
pgtable_kernel_pte_page_ctor/dtor() to account kernel pagetable, however 
they do the same thing. So a common function which only do 
'__SetPageTable' and account pagetable will be more helpful.

So how about pgtable_page_inc()/pgtable_page_dec()?