Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp208477iog; Fri, 24 Jun 2022 02:27:13 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ttOLnMzeQvol5ZnQl8vlP12wiLht+nI722w+S8DYpIHLePGXSzmg3oc5mo22aU5N38bF/c X-Received: by 2002:a17:902:cec9:b0:16a:416c:3d27 with SMTP id d9-20020a170902cec900b0016a416c3d27mr14560270plg.107.1656062833633; Fri, 24 Jun 2022 02:27:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656062833; cv=none; d=google.com; s=arc-20160816; b=KIu/+gl6DARRJsXLBQhLUYEHDxYDbqINdKiClZ+3HrRnY5XVWLhqg4xo+7bdMc6g92 fvoNQQGVVyIf2A8RRJnjfyoFguhUnLRPtZv8U3k67DPtmzBGU27MwMHAwdXwh0vqeS8a IupxT/6xvP1jE1TWyGlMmAW9+jxAV2WqaoQg/7Cc0ce2AX2dHLGrZuo+Ww54FJvEMSkS j/esiNAEwNEFMI9PI3wEN83cgcVmcIJ9Mf+qLEMLNIgl4n2ZlzBHYXDef74yf60UwTJy 0HHAImGxyr+cKL79JTc9uJCX7UXq4Z5Sje4Q9lvMDLdydftq32NAbhLTRR/9F6AERqrk hjQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gwHj45c/Lzbv7zoSvue7Ivw1fU8rWw/o6Tb9jyjusEc=; b=g1VErArP0M5KvdEaXxEgMFYN8eUOPpff8Wz1SoBBrJShaTYcBjyM7L/vRXqbJBokwm oy7mxU6DwHdSw/2/wiSW8CBagg+CYf396mdbdpgSgPbxJiWd1Gq1pf4cLTizcqWS1f9L NUun9mwSWcGJ3fgVxfpp0HI1SgzyD9rYFp8Xrp1uqLxtQmmE4685ryayQWDdg8c/Te67 8CRQbfxFJRGf4iuHUwTwgWyknPs/36k5Qozah0UgW6X+FDXC4gwz9lt+1JhyJfDzp6cG dxPVA/xHxkFyIbt1tuFX8AV+hXYGxwXJnaBUk17QLurYRmkgUzQQw5igowlf80lj7ACC B9ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kPZGhr5+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 73-20020a63044c000000b0040504f9e815si2149183pge.81.2022.06.24.02.27.01; Fri, 24 Jun 2022 02:27:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kPZGhr5+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230061AbiFXJ0Y (ORCPT + 99 others); Fri, 24 Jun 2022 05:26:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231634AbiFXJ0O (ORCPT ); Fri, 24 Jun 2022 05:26:14 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 103416F4A3; Fri, 24 Jun 2022 02:26:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656062774; x=1687598774; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nphOBXs/+SI9u+eGqjgatvTTn0XBshiwzlb3vatLVc0=; b=kPZGhr5+BCuYXMy56Yw1CIT32+ous5PJmFPlCmV9KbhXtJZpE2ZUoXmN j/85ClvZazLJyZZTn1UupiJYjqUk8EgEMFaUbejP86LhZjd6Nr9uheOmD 0HLJYBVqNkRi3gpWFLWQoRMk4pCikK6/Q/5Ra1tvG3Ye9aXEAMBFFH7BE JdB4+Ta0uH5rbbGDXutcIuaINSuU04tsNL0xI008JIu1p7jflAaQOk9EP /kZdC5k6na/dLhaHl0vVBJVNI6eyXWNqvJIRFm6anIoLmCVr4WY9wZW05 xfR1DCMRKozwUxmMChF4SObfedTEvFswgnl/3ZavMXioD87SdFjFnykmN w==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="261389188" X-IronPort-AV: E=Sophos;i="5.92,218,1650956400"; d="scan'208";a="261389188" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2022 02:26:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,218,1650956400"; d="scan'208";a="691454943" Received: from unknown (HELO localhost.localdomain.sh.intel.com) ([10.238.175.107]) by fmsmga002.fm.intel.com with ESMTP; 24 Jun 2022 02:26:11 -0700 From: Tianfei Zhang To: yilun.xu@intel.com, lee.jones@linaro.org Cc: hao.wu@intel.com, trix@redhat.com, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, russell.h.weight@intel.com, matthew.gerlach@linux.intel.com, Tianfei Zhang Subject: [PATCH v3 1/3] mfd: intel-m10-bmc: rename the local variables Date: Fri, 24 Jun 2022 05:22:27 -0400 Message-Id: <20220624092229.45854-2-tianfei.zhang@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20220624092229.45854-1-tianfei.zhang@intel.com> References: <20220624092229.45854-1-tianfei.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It had better use ddata for local variables which directly interacts with dev_get_drvdata()/dev_set_drvdata(). Signed-off-by: Tianfei Zhang --- drivers/mfd/intel-m10-bmc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/intel-m10-bmc.c b/drivers/mfd/intel-m10-bmc.c index 8db3bcf5fccc..7e521df29c72 100644 --- a/drivers/mfd/intel-m10-bmc.c +++ b/drivers/mfd/intel-m10-bmc.c @@ -86,15 +86,15 @@ static DEVICE_ATTR_RO(bmcfw_version); static ssize_t mac_address_show(struct device *dev, struct device_attribute *attr, char *buf) { - struct intel_m10bmc *max10 = dev_get_drvdata(dev); + struct intel_m10bmc *ddata = dev_get_drvdata(dev); unsigned int macaddr_low, macaddr_high; int ret; - ret = m10bmc_sys_read(max10, M10BMC_MAC_LOW, &macaddr_low); + ret = m10bmc_sys_read(ddata, M10BMC_MAC_LOW, &macaddr_low); if (ret) return ret; - ret = m10bmc_sys_read(max10, M10BMC_MAC_HIGH, &macaddr_high); + ret = m10bmc_sys_read(ddata, M10BMC_MAC_HIGH, &macaddr_high); if (ret) return ret; @@ -111,11 +111,11 @@ static DEVICE_ATTR_RO(mac_address); static ssize_t mac_count_show(struct device *dev, struct device_attribute *attr, char *buf) { - struct intel_m10bmc *max10 = dev_get_drvdata(dev); + struct intel_m10bmc *ddata = dev_get_drvdata(dev); unsigned int macaddr_high; int ret; - ret = m10bmc_sys_read(max10, M10BMC_MAC_HIGH, &macaddr_high); + ret = m10bmc_sys_read(ddata, M10BMC_MAC_HIGH, &macaddr_high); if (ret) return ret; -- 2.26.2