Message-ID: <46571F99.1050307@intel.com>
Date: Fri, 25 May 2007 10:40:41 -0700
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
User-Agent: Thunderbird 2.0.0.0 (X11/20070420)
MIME-Version: 1.0
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
CC: randy.dunlap@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] [condingstyle] Add chapter on tests
References: <20070525172509.5138.56430.stgit@localhost.localdomain> <20070525172515.5138.13652.stgit@localhost.localdomain> <46571E08.1050509@s5r6.in-berlin.de>
In-Reply-To: <46571E08.1050509@s5r6.in-berlin.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 866
Lines: 19

Stefan Richter wrote:
> Auke Kok wrote:
>> +If you give your variables and pointers good names, there is never a need
>> +to compare the value stored in that variable to NULL or true/false, so
>> +omit all that and keep it short.
> 
> I agree with this in principle.  But do we have to standardize it?

yes, I think so. Not only does it remove useless fluff but it forces you to pick 
your function and variable names decently. It really doesn't hurt to mention it 
especially when you see how many drivers have copied bad style over without 
knowing better. Now we can refer them to the CodingStyle doc right away.

Auke
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/