Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 13:36:42 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     lewis.hanly@microchip.com, conor.dooley@microchip.com,
        b-liu@ti.com, linux-riscv@lists.infradead.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: musb: Fix missing error code in mpfs_probe()
Message-ID: <YrWhyppxkpQQ6Y8U@kroah.com>
References: <20220624072515.123646-1-jiapeng.chong@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220624072515.123646-1-jiapeng.chong@linux.alibaba.com>
Precedence: bulk

On Fri, Jun 24, 2022 at 03:25:15PM +0800, Jiapeng Chong wrote:
> The error code is missing in this code scenario, add the error code
> '-ENOMEM' to the return value 'ret'.
> 
> This was found by coccicheck:
> 
> drivers/usb/musb/mpfs.c:185 mpfs_probe() warn: missing error code 'ret'.
> 
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/usb/musb/mpfs.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/musb/mpfs.c b/drivers/usb/musb/mpfs.c
> index 99666ef8af06..c8bf6570bcc4 100644
> --- a/drivers/usb/musb/mpfs.c
> +++ b/drivers/usb/musb/mpfs.c
> @@ -181,8 +181,10 @@ static int mpfs_probe(struct platform_device *pdev)
>  	glue->clk = clk;
>  
>  	pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> -	if (!pdata)
> +	if (!pdata) {
> +		ret = -ENOMEM;
>  		goto err_clk_disable;
> +	}
>  
>  	pdata->config = &mpfs_musb_hdrc_config;
>  	pdata->platform_ops = &mpfs_ops;
> -- 
> 2.20.1.7.g153144c
> 

Dan beat you to it, and provided a better fix:
	https://lore.kernel.org/r/YrVmLEc/FOEzNdzj@kili

thanks,

greg k-h