Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Jun 2022 14:09:17 +0200
From:   Marcus Folkesson <marcus.folkesson@gmail.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Kent Gustavsson <kent@minoris.se>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/10] iio: adc: mcp3911: add support for oversampling
 ratio
Message-ID: <YrWpbcjHSY+se1Aj@gmail.com>
References: <20220623170844.2189814-1-marcus.folkesson@gmail.com>
 <20220623170844.2189814-6-marcus.folkesson@gmail.com>
 <CAHp75Ve+gDa46MRhTR-5dOutGhXqakZbSX14TurwnsuT4OeuYQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="mjYFCl1wg8k8qrkO"
Content-Disposition: inline
In-Reply-To: <CAHp75Ve+gDa46MRhTR-5dOutGhXqakZbSX14TurwnsuT4OeuYQ@mail.gmail.com>
Precedence: bulk


--mjYFCl1wg8k8qrkO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 23, 2022 at 09:20:01PM +0200, Andy Shevchenko wrote:
> On Thu, Jun 23, 2022 at 9:08 PM Marcus Folkesson
> <marcus.folkesson@gmail.com> wrote:
> >
> > The chip support oversampling ratio so expose it to userspace.
>=20
> supports
>=20
> ratio, so
>=20
> ...

Thanks
>=20
> > +static const int mcp3911_osr_table[] =3D {32, 64, 128, 256, 512, 1024,=
 2048, 4096};
>=20
> Spaces inside {}.

Not sure what you mean?
>=20
> ...
>=20
> >  }
> >
> > +
>=20
> Unwanted blank line.
>=20
> ...

Removed
>=20
> > +               switch (val) {
> > +               case 4096:
> > +                       val =3D FIELD_PREP(MCP3911_CONFIG_OSR, 0x07);
> > +                       break;
> > +               case 2048:
> > +                       val =3D FIELD_PREP(MCP3911_CONFIG_OSR, 0x06);
> > +                       break;
> > +               case 1024:
> > +                       val =3D FIELD_PREP(MCP3911_CONFIG_OSR, 0x05);
> > +                       break;
> > +               case 512:
> > +                       val =3D FIELD_PREP(MCP3911_CONFIG_OSR, 0x04);
> > +                       break;
> > +               case 256:
> > +                       val =3D FIELD_PREP(MCP3911_CONFIG_OSR, 0x03);
> > +                       break;
> > +               case 128:
> > +                       val =3D FIELD_PREP(MCP3911_CONFIG_OSR, 0x02);
> > +                       break;
> > +               case 64:
> > +                       val =3D FIELD_PREP(MCP3911_CONFIG_OSR, 0x01);
> > +                       break;
> > +               case 32:
> > +                       val =3D FIELD_PREP(MCP3911_CONFIG_OSR, 0x00);
> > +                       break;
> > +               default:
> > +                       ret =3D -EINVAL;
> > +                       goto out;
> > +               }
>=20
> I understood why the table above, but this is a waste of resources.
> Use that table

Yep, I will use the table instead
>=20
> ...
>=20
> > +               ret =3D mcp3911_update(adc, MCP3911_REG_CONFIG,
> > +                               MCP3911_CONFIG_OSR,
> > +                               val, 2);
>=20
> sizeof() ?

sizeof() what?


Thanks,
Marcus Folkesson

--mjYFCl1wg8k8qrkO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAmK1qWgACgkQiIBOb1ld
UjLRIhAAxjpsZF7muOuTgCKiTvY0MQGsqb059NkGOLpiiiB39A0g4r+Oj3yHDdZk
RmynAm/qheM70moQNU2GUDKUm96bHVHrPmbpl8TpOZ0QldlPanXs3gZ+vBeGlO95
t0s4NPLVHnxKusVRDSMeWa5EETjm0DWTfwbwE/tDp5Gd9U56+vsJ+fndhIwolLo3
4kjkDo1oPXlFeJUwAHOZ9HNp+987NVoS0u9SDotb/CkWK63hNfpP9aL6Knk07cby
PgtLzefWXf47NVOAErZIfE0UzNQkRTP7ijH20JcX+CLYKavovEYbrMXyhVwQky4c
NrWFjHYy1DhW6WKMc2qW76q1vPrQgQo4y/rsbLlF/25TWCfN3ruFOdpGzijPkDku
r4buN5L2C7M+MOdfT6R+4Uo2RzQoeK7ZuheU51rn9B/8FQbtldD99mCoBARoEdEq
JSzIpdnheTmQwZH4BNgzEoe6/NrG08fAtG9oET+7NvCK4fA+h+KasgZ+Ixo/MbOw
jD8B3m0nNGd1RBRm41/KGUnO4IFzDWmLZAwIHGTRIMpJ3cT5BxR84mmi48EcngS6
x42I5s1LmfvwCh1k+YXcUWhttZEK/qv6NiEPFRdlK/GomREs4aVDqviveRy0TLnA
cscGoik2YWh0sOAkmxoOmPhuiNLwL3IW7YhybhrYiTh95p1lrTE=
=3t6v
-----END PGP SIGNATURE-----

--mjYFCl1wg8k8qrkO--